Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <94a80f47-d28d-5638-1492-f1b4a3e3410c@intel.com>
Date:   Tue, 3 Oct 2023 14:15:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 11/24] x86/resctrl: Move CLOSID/RMID matching and
 setting to use helpers
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-12-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-12-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3FqTDJrV1J2NFZwa2J5dTZ0ZlNrTXZVV3BGdU1jZzRLS1FXVW1pMmhLQ3lD?=
 =?utf-8?B?dFN6WlNKNHFKWkgwRWI1OEo0Ymg5SkZIelVQSEpUMldRbndZVFl6MVk2TVNL?=
 =?utf-8?B?SmZiZVVGZ2kzSDE0MXFSeVJ6U2ZNMXZQUER0R1E0SW9NUnM3dXpEVmFVRnRQ?=
 =?utf-8?B?WWFURnlRUGF6OXZTS05nT0FYVUVySWRVdGlpN1dPTjNsZXUvZHVmdlYwZjVY?=
 =?utf-8?B?OE5VUWV4UGtobUF0TWxxL0pORDIzS0V1TUhzQUNFemsxdHVKbjdSaVYxU0tF?=
 =?utf-8?B?UGxpMHFCZzROVisyYVZvcC9JUUZUbHpYamttRC92N2dvQXBOSENBWU1wU2lv?=
 =?utf-8?B?U3lOVDBOOVkrcnhES3g0bkRtYk9zL3ZDZ1dPVzFvZVRMSkZ3alduYmVHZGV6?=
 =?utf-8?B?Z1NVb0RYeXlFV0VrNzRVS25SR0Y5VjVIWGREcW4yNUJDUjBGTC9kUnBHdDI5?=
 =?utf-8?B?Qk93aE1mM3cvamNhRHBVZEtjcjJUc2dMOWFMTHQ0T2xYQmZDVVQxREI3bDlq?=
 =?utf-8?B?UHdIMXhEbEhGUnFIMGdYMmNSU0p5YW16cy9HQmo0YWJsSXVNZmMwQnFCdjcr?=
 =?utf-8?B?a3p0U3dVMW5nc0NrRHJOcmtoNytrRkJ2dFBheW85RHZ4aVpvMGZKRzgzNXJu?=
 =?utf-8?B?S20xS3ZsMzRDOE5MT2pNd3RZdUdDbUQ1ekgvWmNLMHBFTFdVYnN3YVFJZWIr?=
 =?utf-8?B?bkxlME9tRW4ybUJodWtTc2hYdmMwTGNCL3hjSXBnS2FiaEJoT2ZTSURJSmc0?=
 =?utf-8?B?U0VuakZLWU54YVR1Ry9jVVdrczFGWEMvYjg4MUl2YmpNOEZTZDNCR2M2dGJo?=
 =?utf-8?B?OFhMWXRRNWQ4b0Q1c1l2UitkZ2VmUVdPZkJhcE9aUVhxaG52Ky9zcmxKWkZJ?=
 =?utf-8?B?Q0s3Tm8wTFkzTnF2NFBFeGFrVGl6N1NzanBtbHJERFdmOGdFWWRseXh1VnEz?=
 =?utf-8?B?Qk1yaU5vdW1ZMFZsOERENEJBVzUzRHJyb3N3MkRlYnVjOTZrOU0zSlJ3d29w?=
 =?utf-8?B?OTlXTzFVWFpZcFUrM2hlbm43UHAvNVgvZS9CODFDRnJwS0RDVzlaN3hKa3Yx?=
 =?utf-8?B?TGcyQTNhSjF1UWszTVJNMmpkWXhRV3BSTXh3Zk9nSXZWekQvQXBHYlJ0S280?=
 =?utf-8?B?ZWpOMzhJM3ZMd3N6QlNuNk1VNDRPZ1ZtZ1I2SWFkSXV5aWgyN25vL0w2STdD?=
 =?utf-8?B?ZmRIVmdlV1lGNWIvclRIaloydjdYZ014a1BEUGlJTnVrb3hGRkQ5dEMydHhZ?=
 =?utf-8?B?T2JqNkJ4Vk9CRm1kQjdaODk1MFhUU0EvZ1J5UnErK01GNEtMYVFEZjdzelZa?=
 =?utf-8?B?Mjl2VjB3Z1VHYm9oV2ExZG1oUlRvT3RIclQ4YkczdGNlZXlCOXNFMVY1SzRh?=
 =?utf-8?B?cXZkbjNMTzl2ZFlPS1VRMDd5NytvUkhpYWZWSk5hNnVET09aNjF2YUV1emsr?=
 =?utf-8?B?QmFnRmRva2tyY3duRERqSDd0L21weEoxYlhoQzIzb3E3ZzUwakJhKzAycXFN?=
 =?utf-8?B?a0N5RkJKQzdDK2ExMDd1SWsrenlNS055Nm1jb2t5MHBxaUFsUnE4SGJmenNX?=
 =?utf-8?B?RGY5OEFQRE90eVh2ZnNMT09ENUE0bnZMVldXdjI5Q3dOcHVVM1Y4NlR2T0ty?=
 =?utf-8?B?SU9SdnlVZ2dYREVEbGhpcUJnR1FhaTU0R3QrdlZZZk9veFpFTlZjcHZCQnB3?=
 =?utf-8?B?UkNPekFnbVVhWE9zaldTemlKYWJUU2hlRkYweC9ZQlIzaWtMQXJLWThqTGlY?=
 =?utf-8?B?V296TWdTTFBVZmZNUXhYQlN3TDFVY05EMnBjcFBTTFVnOE1VVCtENm9tc3ha?=
 =?utf-8?B?Y2N6THFqWHl5bHZja2xFWVhzSnBkMUs3ZW9YV09nVE5wbkd2Z2l1VERsRHBZ?=
 =?utf-8?B?ZTN1MWRFZlppMkorZHpFZ1g4Q1QyMXhpc1JNZklTY2V3Y2NLZHQvK3hXYjYv?=
 =?utf-8?B?OEZGMlcyL0o0ZlN5K1lWMDI2cW5WeEdVcVlWMk52MnJuWmdUQk0vMlBId1Ri?=
 =?utf-8?B?dEE3YzdYMlZZRmFQMHVHdllnbStvVGFIdWwwSjZFWDlzdWUwVStSMDliMFBi?=
 =?utf-8?B?b1dhQnNNMmQ5N21SbGpycGRBbS9ZYXdUUWcxd25NOGFIRDNqaUpUVDhpcVph?=
 =?utf-8?B?OEZVQWFGOXpoTTlHczgwWXJuY3NoUk12VkkrSW4wbVoreG1sdFRSODZQWTE3?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ce94bda8-f007-460e-5385-08dbc455d528
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:15:13.1796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mSKM6N0h2Janjdl4v6Gj5VRivc3M7WATXONRm4NILyVl8vX0WwVuVPv6PXAdeM78UCetKBXWgC64eFvbnQt9lBPdlcHrlEwLEeegaKNkLn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6059
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:15:39 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> When switching tasks, the CLOSID and RMID that the new task should
> use are stored in struct task_struct. For x86 the CLOSID known by resctrl,
> the value in task_struct, and the value written to the CPU register are
> all the same thing.
> 
> MPAM's CPU interface has two different PARTID's one for data accesses
> the other for instruction fetch. Storing resctrl's CLOSID value in
> struct task_struct implies the arch code knows whether resctrl is using
> CDP.
> 
> Move the matching and setting of the struct task_struct properties
> to use helpers. This allows arm64 to store the hardware format of
> the register, instead of having to convert it each time.
> 
> __rdtgroup_move_task()s use of READ_ONCE()/WRITE_ONCE() ensures torn
> values aren't seen as another CPU may schedule the task being moved
> while the value is being changed. MPAM has an additional corner-case
> here as the PMG bits extend the PARTID space. If the scheduler sees a
> new-CLOSID but old-RMID, the task will dirty an RMID that the limbo code
> is not watching causing an inaccurate count. x86's RMID are independent
> values, so the limbo code will still be watching the old-RMID in this
> circumstance.
> To avoid this, arm64 needs both the CLOSID/RMID WRITE_ONCE()d together.
> Both values must be provided together.
> 
> Because MPAM's RMID values are not unique, the CLOSID must be provided
> when matching the RMID.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette