Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <57554be0-5be8-ee03-a9dc-88deaac43453@intel.com>
Date:   Tue, 3 Oct 2023 14:17:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 13/24] x86/resctrl: Queue mon_event_read() instead of
 sending an IPI
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-14-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-14-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmFLMTJvMWZyNmFtSkM1cXFKNm9HUy9pQVNZOHlBUmxrMzNXVFlZQm5mVmpw?=
 =?utf-8?B?TjBwZmlQalNwTzUxekNBcW02aGI5MHgzaGxaVklQSkxNc0JsWEJEc0lIM2lI?=
 =?utf-8?B?Ujh2b3Jhb2VmY3lJMlozaC9OdmhPRnJRdWFCOTlGYkdObVVjMDJXa3B2dkgw?=
 =?utf-8?B?UTMrS3FIZlMyUW5CNVJyc1BLT2x4SE9oM0UxQVVoTUQvUkVIMGtSaytCZmdv?=
 =?utf-8?B?Ly9pZWtkd1YrTTJWY3dzQlJLdTEraHlaV25CUUxWenFWL2RZekdTUTlpK2FE?=
 =?utf-8?B?UVU1WWcweGx1c0hLOUkrM1FBYm9DRzgzMGNucE9STmhmblJYL0pGSW5JMGJk?=
 =?utf-8?B?Z1FsY3FWTmM5aDRvVDViSTh6eHZYRGI4TW01UFM3TTkzVGpQb29uR3JTL3lG?=
 =?utf-8?B?QWZMSTFpVE9FQmNtNUc3MU5HM2I1ZzJjV0YwKyt6ME9hZXo3THVVQUMwRkpu?=
 =?utf-8?B?em1KM3hRT2p4ZDVTUDRIMHhqQjdkWTl3Z0VVQ0k1bGsyM0tvWW1KNWZCRlp5?=
 =?utf-8?B?Zmdnc2c1ZElqZ0VlaWh2ZDRUeWI0R210ZThkRzRoN0ViNlR2YVlvTUx6YVFJ?=
 =?utf-8?B?Tjlvc1FSU29HZlNmZlhQUEdEeStXYXRzZ3NvWHJrb0JNWnFzUGxiMkJWVnNK?=
 =?utf-8?B?RWpzRHFjL3N4K2ZTVjlkcjlkR09Yb1lrOEladnpLMXdMR3BEYVllbGR6dm1V?=
 =?utf-8?B?TE9tZDZVV0kzZWhCOUx0MjQ4Y2xFUTU1MVl1UnZMREh3ODBtMTVwM2Y4SklN?=
 =?utf-8?B?cFQ2N3VlSE5LN1pwRnhiZmdCRGdRLzhVaXhWMUpUUXlwd0RQNHBwbG96cDll?=
 =?utf-8?B?ekFSYnlSbUFuKzh3STRtTjdwcFMyeUM5T3pmcEtWVloxL3prck9LbDZDeGRB?=
 =?utf-8?B?NVFmUEJzZTNlM084bEpRUVBhdWo3N3BhMWtQNXpEVjdlMU5JdmtweTA3VTVY?=
 =?utf-8?B?RlFxWWUzTjdCRStqODBFenVQM1FmSWcwL2U1bi85OWhJUjh2TDUyUmNURlQw?=
 =?utf-8?B?SlNOSS9JcVMzUVl0WGVqN09MV1B3TzNrQUc2ZU95RTgwSnlscDdicldKek1s?=
 =?utf-8?B?WXNZd1h0elF6UE9JUTJ5SVVqL1BDMU8zdXBJVjdSUlFuQ1E5Ynk0c1Zjd2Vs?=
 =?utf-8?B?WHM0cWNWaHgyVEorYkxXa2NBOWVMNGlwdVJBdkFSRzI5REN6OHNQbnBvOTJW?=
 =?utf-8?B?UmMvUUNzTFN2cnlCaU1TQ2FWdXUxYTZkSXJWR3hXZVVzSXBQbERzRVV5R0Jv?=
 =?utf-8?B?eTlEOThsa29DOHdLTGpDYk9venIzREZkZTFONjI3QWtXVFZBWEhTZXV2SzJm?=
 =?utf-8?B?ak1NZ1J2V3lxYTdCSU1LdnVreE8vc09DbHNZZEw1RU9aMkxFU09HVUtId29Z?=
 =?utf-8?B?a3RqMXBXakE4ZGhGVjRqY2tnWW96RURrSzRudG40OXZyd3R3bGQzbmhZZ1hV?=
 =?utf-8?B?bkhQNE1zbUhJSlh5eVJDNzVuQ1JEdUNybC9XOWNUbldsem16dFdQdEV5bEJV?=
 =?utf-8?B?UUMzRzdWY1g4S25sYUhoNXpheTRGVTJMQnBTOFNJVTEwdjRoZ2VYbHJxWmxZ?=
 =?utf-8?B?UDZIYUg5THBvaUE1cW1OWS8wRlVkZTYrNyszU2tpUDVZZmJvaGxkSHVSOXJ5?=
 =?utf-8?B?eEs0Z0NJMmhDU2hhWFIzZ0dHaGV3Z2JobTF4T1crU1ByZWpCSjZHdm9WVm5R?=
 =?utf-8?B?MmxhNDVWSXczU1lWdE84KzhPVkxUYWJkbzA1UGl0TERBUThBOGp0VVFxdGZB?=
 =?utf-8?B?WFNaMzg1Nkh3SXpsajdaOHdkdEV4Z3Z1eWRNVWhFS2FaQ05rbDlNZUlERTBP?=
 =?utf-8?B?dGFpVFZQN2FDVUpLM09JUlRrelhnM2dLR0JadXhsUENucmVMS3JNWEY0enNF?=
 =?utf-8?B?dWNEMmIxbjN4ZzQzSlIzSnhRV0ZMbVRYbVlPZjV4S3RxRUtWRVpFeks2K0xD?=
 =?utf-8?B?aFM1Zlh2Vnh0eXJJNVRnRU56NmQ2bzV1c3Q1WlZyQVdPSDNtNDFtaWFDTlJE?=
 =?utf-8?B?ZXBwZHY2Z1pGaW96c1YvZG1hdWY3Y0w3SjdGZmpaMHk3R2l5NWVRRmRta3BV?=
 =?utf-8?B?cEwraWF6Qks5cHRNcjVPdDlyVVRsZU5OMjdVQXJQRmJoallxMUdteExkUVZW?=
 =?utf-8?B?Vk42dzNZcHNOS2NOTTJMWEdPS0J5Y2locFpFeGdEalQzOG5uUFFBVG9Sd0hz?=
 =?utf-8?B?cXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b28cd46-7d08-47ba-8495-08dbc45635c3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:17:55.2484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BKVTftuAzXbg+WDApkUsTTo3u+/sTdwrmdyQbeMSHx9kc+42fy6SD10h1sk1bmlSLa+D53Bmq9D0mZX3tCqgSIrLGscs3MpPxPDf/Hxg0sc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6059
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:18:22 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:

...
 
> diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> index b44c487727d4..bd263b9a0abd 100644
> --- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> +++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> @@ -19,6 +19,7 @@
>  #include <linux/kernfs.h>
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
> +#include <linux/tick.h>
>  #include "internal.h"
>  

Please keep the empty line between groups of header files.

>  /*
> @@ -520,12 +521,24 @@ int rdtgroup_schemata_show(struct kernfs_open_file *of,
>  	return ret;
>  }
>  
> +static int smp_mon_event_count(void *arg)
> +{
> +	mon_event_count(arg);
> +
> +	return 0;
> +}
> +
>  void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
>  		    struct rdt_domain *d, struct rdtgroup *rdtgrp,
>  		    int evtid, int first)
>  {
> +	int cpu;
> +
> +	/* When picking a CPU from cpu_mask, ensure it can't race with cpuhp */

This comment is not accurate at this point. It should accompany the code it applies to.

> +	lockdep_assert_held(&rdtgroup_mutex);
> +
>  	/*
> -	 * setup the parameters to send to the IPI to read the data.
> +	 * Setup the parameters to pass to mon_event_count() to read the data.
>  	 */
>  	rr->rgrp = rdtgrp;
>  	rr->evtid = evtid;


Reinette