Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <45ac8c02-5188-9599-ad5a-380197ce7251@intel.com>
Date:   Tue, 3 Oct 2023 14:19:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 16/24] x86/resctrl: Make resctrl_mounted checks
 explicit
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-17-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-17-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmJqU3BzczRkSTI4NUVaVmUvOGhVSW03QjJLbWwrMjBSVkpWSWJrRmRjVjI3?=
 =?utf-8?B?enVQdXlsTnQya0I0RlFhKytMTVlVM3BXVWZ0Wm5lMnN0cE5pTndDWi9OTHlU?=
 =?utf-8?B?Nkx0Y1puNUxZRDBIUXhNb0thL0NNSXdMcG84NUpsLzh6bm5pWUJqSmJQSk5u?=
 =?utf-8?B?V2pOTkpQYW5ZR0NXUXRPVUN3ZHAwbG9sVUFhM2d1a3JraVpXWmFaL0J5OHBO?=
 =?utf-8?B?OTBNVGsvRzBLakVFR0QxblpNc2RrZEdBV2duZGwzSUt2UVdVTUFnMXZ2TnBn?=
 =?utf-8?B?SnpZa1c5RkxtdHJaR2doWXpzVFN4UUZDV1I5cnVXRWF3a0g1eWVKeFN0aTlY?=
 =?utf-8?B?YVBoWFY3bzFoNWFUTlAzRGRpYkY0c09hSzA5R1FqQ3I1Q1ZjNndTUXlWSTJV?=
 =?utf-8?B?ek5RQmZsamF2aHNXdmE4cGlNZEREUkE0WGpSR2c4d0o3S0lWOFp3cC9McTl0?=
 =?utf-8?B?Um9nK1Nwdmpmd2JoM0FMcXFhcERsaTNqZytmZUNwblRnVFBhd1k1UGp4UWdx?=
 =?utf-8?B?dkk4UVlJbmVhbDRpUkt1aDRVeXo0cVA0dThOZHNNbXQvb290Z0NNTHUwaTdC?=
 =?utf-8?B?RkVGZDlacUh3N040bkRaaDJOVVNaUUhySFZOZmx4Qk0wRGczRWRYNC8rVDJj?=
 =?utf-8?B?SnJlWWdNOFBudGhTTWpPVmRSbVBLMXUrV0xPNzJlUXcxY1BTdVg4emZtR3By?=
 =?utf-8?B?NS9WUG1weEcxUmdITVZybDN0WjQwbUVSUG9ZOTR6Uk5TaWtUVHBaUjhaMkZR?=
 =?utf-8?B?Y1lQSUMwMXUvYjNwQ1FjaDVZSDVjeUlRNWRJRVJ1dElBY0NweTMvUnRWUU5I?=
 =?utf-8?B?VGp6SnR4UEhNMGFHaUxrenh0N1M3Um9kVmMxbGtESzBKT0ViaUw2ckxEOUM2?=
 =?utf-8?B?WXVzS2dLckhIOURnL2twei91RENsOUhmREo2UlZoU1luTkRPSS9IZWd1WVcy?=
 =?utf-8?B?YUxlRm5ONVo0c2V3eHYzMHJ6dXNzQUhTYThjbFlrSGh5K3R1RnpSU1grQnN2?=
 =?utf-8?B?MVloTEltL09UMndQN2k1T0RIeGdUb05nNFJ1S3JqZVRuaGZOQloxbkZjTXJY?=
 =?utf-8?B?ckhqSVRZZDhZVXo0Sy9GUFgyNElsR05Wb3JxTVg4OXV6NklrT3NOMDhiSnBm?=
 =?utf-8?B?TFdRNm1DVGdGcHlld29IK2lUVWNvVWUrUVkvZWlqKzE2dUdIaS90c2Q5bFpM?=
 =?utf-8?B?M2F0Qms4VUlDMGV4NzRqellNZWVpWHRJVFhySXlGQXFsSmpHRy9IUWM3cEdN?=
 =?utf-8?B?ejM1ajk5SUJxMnkrQ2kwc3FSZ3RPTkF4TmpiL3JuOGxrVmZiNVBuU2pWVmtO?=
 =?utf-8?B?elMzd0tGSGYrNXlKWnhQanhiQkJJOVRzeFFCY3A1K0M1c2w0Zkozam9ncGNT?=
 =?utf-8?B?cFpkTURqbjlwMzc4UWhqU01NcllxVVNUNll1OXBwUmhFM3FCUjgwdnRzbXcr?=
 =?utf-8?B?eDF6dVNTUFFSQzlFWjlPUFhMZlhVcXpvUWwyTDhlc0VDUVV0ZDdvTEttS2sw?=
 =?utf-8?B?by9YK0psSUN2MGF6eUdaU2VGQVEwTVFYVHVnQnJXMmw2TkZUY295N1VXSkhk?=
 =?utf-8?B?REFQY0NCYUtONWVjQmk0aXZ6eVBqTUdrbTdpcFh4WVRzZXdGU3V1K1hURjhU?=
 =?utf-8?B?T0h5Z3FoaHdrbG5zOTdodFhoc1BmcUlVaUZremp2NjY0SWl5d1BSZFNNTzdE?=
 =?utf-8?B?ejk2emhjZHVZbGRhcit0a25maSsvVzhLMlB0TlJLUFk0QU5pSXd3RUsvSjVm?=
 =?utf-8?B?QjB5eUk3akZsdG9wTmpFdzUxL2xBb2RpOHM2U2RralFtY0l4Nms3T0Y0UkN0?=
 =?utf-8?B?QUZUaDN4QXl2TFZhQ2ZuQ3VFM0hPd0dkTFlTNEZtQ0UvUVlQUWYxVkRUYkpW?=
 =?utf-8?B?aytuc3N5b2RvV2lQMXVNQ3Z0eEF1SlVjY1RRZ2xaczFVQ2NHQThpNkx4cDRC?=
 =?utf-8?B?ZWRiRTRING1kMlFnSWFIZFlwNG5mMFZtYWo2cXJFL0wxQ3Jzb01wRmtZbUdR?=
 =?utf-8?B?T3RQWEZ4K1Fyclo4UmhUa1ArQ1k1eW13dXBFU3h3ZmZNK2ZIUS83c1dKZno1?=
 =?utf-8?B?ZDY2RkVTZ2ZHOGkvL2h4bGlFaWhVQ28zUlZBUGZpV2ZOajF4eGJxMjVjYVlw?=
 =?utf-8?B?NHlqaEw0cHlpNGI3THBLdmE0SC95bkF3VjdhNVBKaHhaSmtTYWl3UWJvRFVu?=
 =?utf-8?B?aGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 74a1e7cd-6cbd-4e2a-bfbb-08dbc45663a1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:19:12.2085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wGFENaWPR1D06FRDvGOUly1bY3SDYrzQvX6v6oJhBuE7bMqQLoPMv182GKoXsgOOX5dhRo5CtC74SBei+COzl+0v1bwm9wk2k4CRDQc8YY0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:19:28 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> The rdt_enable_key is switched when resctrl is mounted, and used to
> prevent a second mount of the filesystem. It also enables the
> architecture's context switch code.
> 
> This requires another architecture to have the same set of static-keys,
> as resctrl depends on them too. The existing users of these static-keys
> are implicitly also checking if the filesystem is mounted.
> 
> Make the resctrl_mounted checks explicit: resctrl can keep track of
> whether it has been mounted once. This doesn't need to be combined with
> whether the arch code is context switching the CLOSID.
> 
> rdt_mon_enable_key is never used just to test that resctrl is mounted,
> but does also have this implication. Add a resctrl_mounted to all uses
> of rdt_mon_enable_key. This will allow rdt_mon_enable_key to be swapped
> with a helper in a subsequent patch.
> 
> This will allow the static-key changing to be moved behind resctrl_arch_
> calls.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> 
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette