Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <ae09459f-9412-16ff-de90-1e51504de4f0@intel.com>
Date:   Tue, 3 Oct 2023 14:19:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 17/24] x86/resctrl: Move alloc/mon static keys into
 helpers
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-18-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-18-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDE2cU9FTTFjZGsrR3VmeFFOMmtSUm9XTUJKcG83UHNJR0E2NEZhZVAvTEJ3?=
 =?utf-8?B?SkRVelQ4OTFvOEMzTHNUc0dTL3YxLzNqd0MwZTFpQkhNaXFRM2NYczNpbjhJ?=
 =?utf-8?B?QjJTY0VZanY2U1ByMGlwM1FhaWtiT3lCMjdheWowOG5aTXhlZGtEMysxNDU5?=
 =?utf-8?B?aVpvdDByNlAvUHFQL1dTdzEwWHZBcmRvMUVvSUZNNytzWUp4bzFXclJqL04x?=
 =?utf-8?B?Tnh2Q0FTR0JpMk44QnkvemRNeTFmekpQS09aZS8wZ2ZoQTFKVkp0RjlsQXhC?=
 =?utf-8?B?a1BpTkRmeUswTXlZaDUwRHg2WHJqQlFqbFdXNHVjYnByQVpOZFdPM003V3Jh?=
 =?utf-8?B?Vi8xRmlhZC9jeHk2NlZjVUNWQlZZTVNBYjlUbnlrYnNGdkN5M2lRL0xJY292?=
 =?utf-8?B?MktiNzNqYmZWVWZFd0JSUVJYRzM3YzJ5L2pFNmNqVTRYR0E3d1A0Y1JrUlcw?=
 =?utf-8?B?bitSWW1vTTRkR09kczlkbkpiQ3kzYVd4eVpSa0ZzeERadDY1UmEzV0FBN1dP?=
 =?utf-8?B?Y2VCSzk3c254U2xUVmlXTjE1TWFJUUNyVWpwTkd5bks5NjY1b3hKTGp0MnpW?=
 =?utf-8?B?enZsbU4yVWNKS0ptZENpQ2xWUXNzZHAxcExmV1hIcEJ1RTR2Ni94SnFOTENS?=
 =?utf-8?B?Q1pnckxxeVJzeXVoUG55UzQvSFNaS0lwOVR5cmxLb01YNDR2YmlQL0FEdStq?=
 =?utf-8?B?S3E4WUhNZW9vNVpzWTdsaFZISGUvRENtekhSUWRERk5IczZFbUdCT09WZWZO?=
 =?utf-8?B?TVIwcy9pV2I3UkhoQXNsK05PWWp1RmxwUDJNYTNGMVRSMVZxelVINnF1SHBz?=
 =?utf-8?B?RjFWU29ZWk1aTVZFWmRGcVU3c0IrYlkvbXRpRXMrUXJCUm1WckVYTVhEcTho?=
 =?utf-8?B?WVNnNXdJTTdlQWZhK1orYmpqZlV4dkRzV2ZQNkkrWDZnc0JtdXAzWUd5QkxS?=
 =?utf-8?B?MlJNT0ZmTTVISkVlUnVFb0cvWkxjMEMxVy9GZTVuL09vdlBnci8xNFBpUXBo?=
 =?utf-8?B?Zm1ScVE0cEpuTGR2Z1N5WDM1UXFCU3I3SE80eFI3WUxwNTdOTzNzVTNsZzJD?=
 =?utf-8?B?ZmQvNkIrZ21QeTVwc2NPbUVmKzhiakJJYkJKQTlsVk11TzVVZjhCTG5pZmFL?=
 =?utf-8?B?akphZjZtZXBhMURMTFowZXhkOURhKzl1eStVQ1RWQVdZUlJTYis2S0xuWWp5?=
 =?utf-8?B?OG9vVGtESHBMLzJYang2N2U0cFZyRUtxREFtbGh3NDlwUHliL3I1R0QzUG1a?=
 =?utf-8?B?TmU3M0k1NkMxR0pVbGtRME1HdHphTWpEL3pHZnJmWERheExTSE9YcUp5bG14?=
 =?utf-8?B?ajBNSHVieVp6b3o0R3Y2WXN4SW1JM3ludHlTNDFCZCtOS1AwWDlITDU2WVBz?=
 =?utf-8?B?N1VIU2RoMzNQdUdxVTE3ZUtqRk04RkRPQnhMZWYxdlRzNlFDREFrRlMrTFM5?=
 =?utf-8?B?UVZIRmdCYmRkeXZoNlFoT1RMZDhVUUV2VU9SdGZqRlpSVkc3ZWtyL2Ztbmxu?=
 =?utf-8?B?VjZURVJ1WjRaS29kVmxhT1hpSHBXS3pwUTcvWmt2cDFZWEthUCtHKzVGK2Ji?=
 =?utf-8?B?Z00ycXZMTGxqclYzSlJMaHRJYUNEUFFvUElWWFp1dmdLMnJtbVlBRDNGZFdC?=
 =?utf-8?B?VW90UlpMZk53eTBkektoMld5c0hodjZTeU5nWm1DOGVCc0h5bm5kN2c0MGpS?=
 =?utf-8?B?aCtmQ3RWeERxMkcxZFVMbXBPUysvL2Vab1NpSUNWUlhXN09WNkZ6N0dLSnZm?=
 =?utf-8?B?aGtDUFFyM3JZYVhQSUxIL0JBRXJybTYwZlZTQU0vaXRqSlhaQlljRjZkK2hX?=
 =?utf-8?B?ampNYWNvYnBKN2hDeTFaUWR5cStXTmhmeWlRNHY1UHo4a0EvMVVOVGJxWmgw?=
 =?utf-8?B?QWZWelorYVo0Q2lvMU1Cb3grNGFuUjJJVnE3YU1Fc3BWbFFhbG5pRFlOSVp1?=
 =?utf-8?B?VUlPbE9NVHpjcWx0T2NXek9aNm0rTXZFOGhMWnhDOWM2UEdKVmdWWU02ZWd3?=
 =?utf-8?B?ZHNZL2Y4SkZJek9MTXJ4OW94eVZsQUVZK2xKYzIvOHdMTkFkL2JmQi8yM0pX?=
 =?utf-8?B?K3E3enRCY2Mwczk1d0dJVDJGZVRNVU4rSXBnaGU2Q1lqaFlYN3RwNDJnM0ZV?=
 =?utf-8?B?RjFjdFR5THVIazF2MG9UeVN5OUdvckM4cWplcmVMRWJtak9oR1hDYVovd29V?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 175a4123-a8c3-49f3-c374-08dbc4566b84
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:19:25.4371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GC/MqRVDE3rM0CbLMx3tKw/YBVu94l3fSjcLCk43kOz1m7R/xAhibfSZjE46N0xXDX/V/iOENgfKcc8pFKh74CtNh+neJ4uqytsYlGf/wJE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:19:52 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> resctrl enables three static keys depending on the features it has enabled.
> Another architecture's context switch code may look different, any
> static keys that control it should be buried behind helpers.
> 
> Move the alloc/mon logic into arch-specific helpers as a preparatory step
> for making the rdt_enable_key's status something the arch code decides.
> 
> This means other architectures don't have to mirror the static keys.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette