Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <f29a69fb-eb5b-3947-7022-4b68129901ed@intel.com>
Date:   Tue, 3 Oct 2023 14:19:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 18/24] x86/resctrl: Make rdt_enable_key the arch's
 decision to switch
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-19-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-19-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVgxY1ZxQ0ZqZmFoekNrNk4xb3V2Q0ZNbFg2TkpNVlZBdzlubGJsb0NsaHJD?=
 =?utf-8?B?ZnRUb01aa3prTmhCcmhKZFFCNXNSaHJrN1pMQ1hpYUtJeGJrbDlaN2VHWG15?=
 =?utf-8?B?bG1ubmY1VUF4UjdUUEVkSnFsTmNCaFFKd0dBSzd6ZzkvSWlaNGlXaUt5RkM5?=
 =?utf-8?B?OUNaZms2Vi9pdi9mUGJqRFkrRGx1T1lxUmwyakFpb0QyNFVZRmVnUEpCUWlZ?=
 =?utf-8?B?cjBsTlFnUmxaa05tdGJNVS8vUzNiQjNUQ0d3R1RWQlNLT2JWQWdaSHY5MXYw?=
 =?utf-8?B?NTV2azFsRlZ2citIdHBsSi92Ull3QndCRGk5R1d4ZTJSem9qL0l1YXl3QVll?=
 =?utf-8?B?UW9tZFJoWjhXZ2JhaGNlQ3Nzd3FtSnhVcFJWQUc0WWI5ZDMxYzM5OEdsaytG?=
 =?utf-8?B?UE1mUkd6cXdnOFhna1JXRXpsdHk0QUxvMS9NSVpCaGRlbG5kN0ZCSWNZRTdn?=
 =?utf-8?B?V1MxMnc2S1p4SXVQL0syUXE3Mm5hTWhDWVkwNFluSFhSN2NsT0ZQQk5wbUEr?=
 =?utf-8?B?aHkxNEVrck5KZ2pGZHkyYmZVQzJza2lnRXhMM25NTTE2MU9Wb0UwL1Q5Z0R3?=
 =?utf-8?B?VFp0OFpzaU5mSWtQK0xqbUpzMU10S0JBMkF6SENwQXBEMUtrdGtMcU5QVy9T?=
 =?utf-8?B?Z2VPcVJieHJ5eWh3RFlGTFRVYncyd0tKdEExOVJoYkd3a1VVU2lhYmt0empp?=
 =?utf-8?B?Qzl0RkdnU1EzNVZvdGpsYmUwWjBndnBNaDNEVWZ5S3Z4YUp3WG82aFQ2WkdM?=
 =?utf-8?B?c3VaSzFtbGVlaHFWMzNtQ005VkVGZDNnSFdlVWNlWTNmRElnVXpWd050UzBh?=
 =?utf-8?B?NjBIY2R3My9OT3dOaEhJNU43MW5ob3ZncXN4QmhQVXk2ZnIxcU5oNlhjVkY4?=
 =?utf-8?B?Y3BtZlVJejZQNUdFeHovN2txQ1VKWjFEaTVwaC9ZRmhaYnN4a0lQRTNrNWJL?=
 =?utf-8?B?TUp1czBoQWUrUVVkVFh4ay84blhkbytqeHZGYnpOTlNmUmp6aFpLR3JHdmdp?=
 =?utf-8?B?K2dJK3VTV0p2a2dneDN2eDlEeGhmdno2UTc0V044dHZVbGZyQlJqQ1BBNWkw?=
 =?utf-8?B?cGdJc2hUZm4xN0dQTjFhL3lObjNBM3dBWWx5UCtRS2dIeTM0K1k1RVM3dFhZ?=
 =?utf-8?B?YnVWazJTTXAvcjljZThyK2dTWm50YkFsTXVaMWdPTjF0L0tSZ2Y5YU8zK2hy?=
 =?utf-8?B?OU92OFpGTDNjaXMyaG5CK01XREo4UUNNa1BrVnUxYW5JU2pCT3VxT09RaGR0?=
 =?utf-8?B?U2RnQTA4SzNnWGVETk5EQnB2NUZRcHdyR2pOTER0Njl1OWJwUzZOamJBNCtO?=
 =?utf-8?B?RFVsYnJkd0ZkbHJQM1ROU1gyT2dZTjR2S0ZHa3JXUGxQL2pQN2hXVTNYWEIr?=
 =?utf-8?B?M1FXZXE0MDYwa0JCVGNFVXJOWE9WVFp6aVQraTBtWGJ0ZDg2YVA3U1hXUkMz?=
 =?utf-8?B?QVM4Uy9ZY240enM2LzhzVnd1SnlSeG05bUY0TGtmUGpBN0hEalRVYkpJdEVo?=
 =?utf-8?B?US9ianpzMk1jcXhmTWc1dktmR0xQQ1AyTUtoOVQzaWVPNW94RXN3REVhUm5R?=
 =?utf-8?B?cDhOemlpV0tzdDdIejZpREdRblJ2Vmg0SXRaWTdtUVlSYnNHK1diQkhIeTNx?=
 =?utf-8?B?Y01RMFAwWDA5UTNDdmJ1Vy9YT01mcUFIcU9XOWZPY001UVRMZ3V4WjBPVEZl?=
 =?utf-8?B?Q1ZzaG1xcUE3TkpHQzZ3MHp6cmoyT3o1UDYyOTFxZmIwS2Fod3JaZzcyTm1J?=
 =?utf-8?B?TXVoZlpXWnRQcVVWRzZrOFY1Ky83UllOcVk3ZER6M3cwY1RVUjdsT0NNZ0E5?=
 =?utf-8?B?eE1rWThuajZENkx1dXM0OGNKekJuRHVMa2NwNE1xckpmNUIrMmcyYVNlMDZ1?=
 =?utf-8?B?eExvRHA1Y1hndnZCQXowQmdWa1lZZFY4bU1JZmk5dHdDMmhTTmRMQ2VISkt4?=
 =?utf-8?B?czZXVW9ZeTNScDllWVpQRzB5N1g3TmI1ME5kWnUyMmFlNEc5TUx4K0lTYklm?=
 =?utf-8?B?SUZTWHlzS21lYThMR05nZTBVVVROZmJRR25zaldzWlRqR3NvUlpQa0VCZUFn?=
 =?utf-8?B?VHYzQjh4RXluOHI2UG81K3lZKzlqMlhJZ3BPVWdNdHVqclB5ekhrUUhkT2VV?=
 =?utf-8?B?SGxRQnhtWXF3WWVhbWFXSTU5V2FCL2VsZ296VHZ2V3JzRmJGKzlRZ0RuN0Iy?=
 =?utf-8?B?eEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 198a87da-ff11-40a2-dbf1-08dbc456735b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:19:38.6201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bha86WcDSeC6/NFJhhJUOStbPKDC2spXDeP/n7co3nDHNr2ys2kO64upJ7bQkt80ryJJqAsT/gQBq8zwwM92ez6ECVJ9nVzlGb35Akb95ww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:19:58 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> rdt_enable_key is switched when resctrl is mounted. It was also previously
> used to prevent a second mount of the filesystem.
> 
> Any other architecture that wants to support resctrl has to provide
> identical static keys.
> 
> Now that there are helpers for enabling and disabling the alloc/mon keys,
> resctrl doesn't need to switch this extra key, it can be done by the arch
> code. Use the static-key increment and decrement helpers, and change
> resctrl to ensure the calls are balanced.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette