Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <13b1ecb3-39fb-3762-9ef6-2d70d39a90ed@intel.com>
Date:   Tue, 3 Oct 2023 14:20:11 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 20/24] x86/resctrl: Add CPU online callback for resctrl
 work
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-21-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-21-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zmh5dTBKMkM2Y1pUbTc0MVI4MEZQQ2QyS0poWWNPazdVdHdRZnM4aWx3Vjk1?=
 =?utf-8?B?ejNsaEpWRUZZV1ZLaTJ1WW5RWERpdzBCd01HLzdOenhwSXVCZlhrOEc2WWJk?=
 =?utf-8?B?enF2ZW95eWVsNDhxeVpIVzJXY2ZMekVmdVBxWTNBcnF1cFpEZEg3aCs5WjUv?=
 =?utf-8?B?bHAwdFYxVXpaUW50TkJSYlpjdHBDVDhyaG5iYy9nc2lLUC9uRTVZaHZTSXY4?=
 =?utf-8?B?NW4zczVtUm1uMC9nWnpvb0FnaXZCUHJYSk9VNXFoZHVVeFdGWFM5L2hpWnln?=
 =?utf-8?B?cWgrbWc0MXJ2enA3amxkT2d5OWJtTEtzRXFQZUZwU2RURDN6VzI3Z09xUVNR?=
 =?utf-8?B?akx3L0szUEpQalFqUGZvOWtYMGUrbHZRODRFREJYQXpEeWhXbUd4V3hORXJK?=
 =?utf-8?B?K2xJQ3lrcHBwK3NiZDBFMDhzR0xVUndOOEZidjZvNDNtQnhmOHhUc2J3eEt3?=
 =?utf-8?B?dEFiYnI1cVdOaFI4WEtHd2krcSsvSG55QXdLM0t3Qzk4d0hmejhtdVl3WVRT?=
 =?utf-8?B?TTcwaUI2TTFMVXRmWk1ma3EzWDhZVFA1OHNnWTRZc2gvaTJZWWMvQnZBRTRm?=
 =?utf-8?B?YjRQYWc4bzVBdnBRMCtQWUhyYzM1Tlc3aVBBaFRoQjFFcndwTjFCMlhHVUJN?=
 =?utf-8?B?NFFpejhqWERsOHgxMzVGN1ZYYWRDRHFxL09LK3p6bk05Y1Z2cUU3WUovV0FI?=
 =?utf-8?B?c3JNSWZiWk92QU1TNlpLRnMvM3NtNjBzMmd3bVNJYzZmeHkzVkwzSktiTkRO?=
 =?utf-8?B?TDhtYktiUnNYVXFTa0VFS1dJS3o3amE2dnppTTFHMFJGUW9rSmlZYy9uckRz?=
 =?utf-8?B?Nlk2Nk1CQ0NvUnFqRWFJblYzRzNmVWdRbXAxNUY4OThpQml0VnhrVUdKNDNR?=
 =?utf-8?B?c3JJNHQxZk5EMWE1aFlCOG1kRmh4b3JDckE4L0JVZTBZOHBJa0YzRi9aeDR6?=
 =?utf-8?B?TEhNdGxvQzRzNDhsYXhQNGdyUHlQQ1VnZzl5c3RQTXdHUExLWDhGaEkyYXAx?=
 =?utf-8?B?WURZdVJzWnh1NDBKTGNhODNOYkxSRTNlR3dqdmtjN1Rjb1AvaFhSKzFwdGw5?=
 =?utf-8?B?RUZKcWh6bjVaSmM2SllTRHIvUWVaTGhBTVl0UjhvSFZ1SHFkMTZYb0lvYm15?=
 =?utf-8?B?VjFkdmFuWUJUb1VpTEZxUFk0RVRvZ3ZabjAzUUErUkl3UUg5eVhPOEFrNDg0?=
 =?utf-8?B?dGhIbXlkSDlnUFUwQ0RmYWwyTE1tMDRaTHk4K25FdGVvQVppTnYvcThGSTJL?=
 =?utf-8?B?YW1rUm5QejQ3cGlnS2xRQ05nVEdQRE1wbDZKOGEzaXZFaHhHMThuU3AyaVl3?=
 =?utf-8?B?dENmU2VjUG5BamtqNmRHREUvellrN1E2aGJYeWJSUDhMdEk2RngvRzJidDdY?=
 =?utf-8?B?anRCMkpHQittWG9QV24vclkraTdObFQzc0Ryb3p1QTUyS3dRUFZnOGgrOXRZ?=
 =?utf-8?B?elBsdDBsRFExK2tQblhSc3AxVHpkaEJuQ2FYVDN1Z0NsM3JGcFJ4eDQzY0NP?=
 =?utf-8?B?OHh1KzJoWDlnT2F0MXhxSHYxMUE1TVZ0MEFncEJNeHNWUzlCRW9ZVWVxdFU5?=
 =?utf-8?B?cXZUVFlkUklGeE1qZU5vall5dXdvREJMOVoyMFY1Rm1tVy9BSFJuelZnbndR?=
 =?utf-8?B?WHovcTdxRS9WWi81a00zZ3dzanJrcjl4SDQ0N0FMQ21FVk53SlBXeVdOS1FZ?=
 =?utf-8?B?NXI5Rkpwck8vb09KQzVNSmUzSzAzZ0tOZTBKUjkxOW1MRXpmWWNESkVYaEJa?=
 =?utf-8?B?RGxpQ0FVVTcxWkYzckY4ZjYrUk9jNUsya1BJWkNZaEZJMmdIRmwzRC90TXVN?=
 =?utf-8?B?NmJ3VjJvelAwTmhVdzN3WDNmZXBsT0IxL2RSM1RpY3pPRm13TjJmazFpSVh6?=
 =?utf-8?B?YWFtMjFoZFhVd1g1bHJpOExyMFJ3ZnR4TWh5NWcyUGNNVFdQUFFzTk5jVGs4?=
 =?utf-8?B?ZURUZzAzSWpEU0cxNWJIZ0NQS3FTMXpSYnRnNlU5c2NvNjB2WGNJMjNIQUpJ?=
 =?utf-8?B?Q3B4YmthYzdDUEZYZlNmT0YvQnppY2ZxZE9wZGlwejc3SXRrTkp5dmpQZWIr?=
 =?utf-8?B?RDhXRWJDdFVPbGx2d2tXdGRvTnNFdGY1Szk5aUtNQ3pBQ2JnUEI1Q0lhMXlx?=
 =?utf-8?B?L0g4YWpsd1Z4anUvWW1BL3hEWTQ2bStlWms0UzNNeHZQcklZOGhPUjBwMUJF?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb8bb49-85e1-4849-900c-08dbc456881f
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:20:13.4245
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QU+7NsLUagECZdSkXtqf9wRlSswR6GRz4LnR4osLJszDK3EEvU6gCU1ZqxviyF93rFSz3PLkkldKRrRMVlYrvbgmoq6ZnNWhywtXBJGABLw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7603
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:20:30 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> The resctrl architecture specific code may need to create a domain when
> a CPU comes online, it also needs to reset the CPUs PQR_ASSOC register.
> The resctrl filesystem code needs to update the rdtgroup_default CPU
> mask when CPUs are brought online.
> 
> Currently this is all done in one function, resctrl_online_cpu().
> This will need to be split into architecture and filesystem parts
> before resctrl can be moved to /fs/.
> 
> Pull the rdtgroup_default update work out as a filesystem specific
> cpu_online helper. resctrl_online_cpu() is the obvious name for this,
> which means the version in core.c needs renaming.
> 
> resctrl_online_cpu() is called by the arch code once it has done the
> work to add the new CPU to any domains.
> 
> In future patches, resctrl_online_cpu() will take the rdtgroup_mutex
> itself.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette