Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <dbfce9dd-5195-50da-c752-ab0292217019@intel.com>
Date:   Tue, 3 Oct 2023 14:19:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 19/24] x86/resctrl: Add helpers for system wide
 mon/alloc capable
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-20-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-20-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THRvb1BkL0lIYUtycG9mVTk2VXAwRmhZbjN5ZWk5azZmOWpFaG02S1B3M2x3?=
 =?utf-8?B?ZUwvd3ZZK1RIWU9kMkhGZUsxV01TZ1BGUTFGTjE4T0NDbW9vOHBxZ2dDYmNn?=
 =?utf-8?B?eGNGMUZnZHY0MlZyTmV6cGhLWDc1RlVkRTBGNkxIKzZKOEgyai90dVY4eFgy?=
 =?utf-8?B?U1B5L2JJZHU1elV3TTVhOFA2d01xbjhuUFg2U0JWZEVuUWtCYWFybCtSQmVQ?=
 =?utf-8?B?RlE5S292K1dMRjlKSGdZQUtVTWd4STB3UkErMHhWYUN1cEw3UUNIaGRXcmJp?=
 =?utf-8?B?RDVOeEk2Y2VNc3hOREx2bDZDYTcwMUUvN2JFMnN4VWZIMlNuQ3Z0ZUYzWEtU?=
 =?utf-8?B?Z0U3eFJNY0xvVVJIN3pXMEJQcld4d25wWGZyakoxNnJ3OHJxM0FkTDU3SUxW?=
 =?utf-8?B?ZXBUY1FNSkxNQ21jVzVxQUJ4MUhlWVo3RmMwcXZhUzVRUStKQU9nZWhab1BX?=
 =?utf-8?B?SllMTTd6MUxNTU9xREtFZDZUanhyNFI0TWxKOGVseHhEUmFQUENONnYzRnpH?=
 =?utf-8?B?Qk5NK3pkOVZGd1lvVC8yTXdvTVRrdERmakNtVXpxUHh4QjlleEJPMisxRGNX?=
 =?utf-8?B?T3FqblAxSEpmY2pwR2w0cTAvZktxdkJHNFVNV3dhWkRla1VLMjVXV2RRVXo0?=
 =?utf-8?B?Nld3ay9GRjJSVmprdUJINHRMME01OE9ZSWIrYzhhYlVEY2ZIV2xJSFhhZVdq?=
 =?utf-8?B?anVEWXJRREtYbG1ucTRMUldwSEl6cU1UTU1uK3Jkc25QZWVRV0Zza2RlcVNv?=
 =?utf-8?B?N2pycFlLdTZvWHovZThkWW40L2pZQjVhQ3RRa0tSc1dDZnZxLzA5WWdqdzZv?=
 =?utf-8?B?cWVyaWlzRkFFa25QYUY1YlgzMWdrUWVwUWpEYklITmRFNXdSR2VGcnYyYTFs?=
 =?utf-8?B?ZUhROENjL2w4c1RWbVdJYVFldzliWXkwbDNabFdwaXJkTmMyck1kRkdVaDRB?=
 =?utf-8?B?TENlY0N0N1d3L3ZvbzdiaGhEVVhkd3Z5allVbVg1NmVzSG1mSzYxcG1rR1Vq?=
 =?utf-8?B?Rkt6MEdrNkhDbUVaWXJtcWVTcndGdDVsTWR6dXZ3cStUaE8xY0pPU2JObFJj?=
 =?utf-8?B?bW1PaUJhRFVxUzZvS3F3d2lyUVMwamZJdnNpQlViTEhYd0dnZE9iVnhiNnho?=
 =?utf-8?B?b1A1MDlXa2oreXJwalNGSW1hR0hBZzMvRHM1MFhXdnlhZVVMQjBwVytOajlr?=
 =?utf-8?B?cTRyVVBxQzU5TkM1dkJnZWVtWVZtaFg0cEZIVjlEQ0ZKeitsVzZSVnFyWVpB?=
 =?utf-8?B?MFUvV01lK1hRNXpIWHQrMTdsT3BjSGJ1Z3c2RmhTNGlkMkhkNTRyZ042S01x?=
 =?utf-8?B?OW1zVGRScHc5aU41NnBRWURZanJoY3k3Wk0zcWViUzVjVnBUWkgxcU9DZ3Fs?=
 =?utf-8?B?WWhFYWw2S3B2M1JvdW9JV2c4USsyWXhiWDQxY3JLMzd6Q3BZVnY3RVJuZHVK?=
 =?utf-8?B?L3h4Rkh5MkJleUxobDRCZmc0UFI4Z0FUTXd4bzlFU3lDcE1vMzIxN1lTT1VO?=
 =?utf-8?B?RnRWUm1UVi8xQ01LUFpFcGFhb0tNWXVjZlFzU2dCM1Z4Zm1jOFlJcFdjUEFM?=
 =?utf-8?B?L1JQcHY2MktNMStoNVFUMXdvbHJLWnVBTm42MitxQmJBUHlUZ2hwdDhzVW15?=
 =?utf-8?B?UDUyNWpLdlVibFQ5UEpuYTlrMW9XcUVUd2tScm9uR3lCNkF4WkdIM2VmblpZ?=
 =?utf-8?B?RHM0K0VCMGtLMlJoSjExYVpoMEI4N1QyVVk5aitLRDNWdktyVXpuTFExeis2?=
 =?utf-8?B?TDVBdytwNjZWVEgrcm00Mjl3bWJ3YytDRHdrYWtFUyswWmQ1akhFVG8xOHlI?=
 =?utf-8?B?dGZGaU04Uzg0UWhqQ3R0T21tN1JUVDV6T1dTKzVOK2FhQzBtU2FCbDRaMFlv?=
 =?utf-8?B?RlhZYUw2UHdaSkdyZi9ieDRZUXd1UlNyYmtPcXZRUDBNNkZqaWRocDVsUzhV?=
 =?utf-8?B?S1RyR256YytsdDNhM2pOTnAwcnc5Q0VRNDRoNjlVQ1pjOGdBQUJCVVQzMHhB?=
 =?utf-8?B?QVNYbHZwN0RsaXlIeGZQREtzYjZNcGpOWlVwUUhXWnI1alBPU2gzT3BHRWx6?=
 =?utf-8?B?bmxTSCt0akpqLytlWHVUZU95YnNhV0FtNzNkQ0tBRGJGdTZnNlJGYXdnazZa?=
 =?utf-8?B?TlFqdWk4NDRJcnlwU1REazYyc1RkdHBjSzEySDhXQk9wR09OT3lCNnFkeFg3?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec79c0b9-34c1-48ce-df9b-08dbc4567b3e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:19:51.8263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBdB76miopOfoC6a3zE6VyLiUUBmpA4C3KlhK4ZLMrec3rh0YKttp4yqVPANf5HLIj8NDhv+VE/cGG1tU0SBO2AzIJ6IekREGKVz9modKvY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:21:01 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> resctrl reads rdt_alloc_capable or rdt_mon_capable to determine
> whether any of the resources support the corresponding features.
> resctrl also uses the static-keys that affect the architecture's
> context-switch code to determine the same thing.
> 
> This forces another architecture to have the same static-keys.
> 
> As the static-key is enabled based on the capable flag, and none of
> the filesystem uses of these are in the scheduler path, move the
> capable flags behind helpers, and use these in the filesystem
> code instead of the static-key.
> 
> After this change, only the architecture code manages and uses
> the static-keys to ensure __resctrl_sched_in() does not need
> runtime checks.
> 
> This avoids multiple architectures having to define the same
> static-keys.
> 
> Cases where the static-key implicitly tested if the resctrl
> filesystem was mounted all have an explicit check added by a
> previous patch.
> 
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> 
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette