Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <a7b99b15-5c26-3a73-b41d-c64b59126f8e@intel.com>
Date:   Tue, 3 Oct 2023 14:22:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 21/24] x86/resctrl: Allow overflow/limbo handlers to be
 scheduled on any-but cpu
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-22-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-22-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnNta0U0VWdjUHl4V3o0Kys4UjFPUHBVNUhrZmdFVGliUHRoQ21wU1hIVUpY?=
 =?utf-8?B?bWJIRTZrYzllWTVnalg2ek11TXRHbndXM1N2VFk5b3JCZkdmcVMvQlZaYVdq?=
 =?utf-8?B?dGd1QVQ4TGRiVGRhYlRZT0xJR2pmaktBMnlZUlI0bEdVYjZvc2U2elhnNXYy?=
 =?utf-8?B?WjA4d0dxQUZNbjhCYXBKMGRoS0tIaC9ta0R0T28wNm5ab3l0ZlREaHh0WndJ?=
 =?utf-8?B?QkxpZ2pGSVl4TTJ4a1VWM3AwREdlb0tncnNRMWo0eWp0bW80ZGcvR2RmaFhL?=
 =?utf-8?B?RndKR0J2bWRNL3BOaEIxL2QxRmpxUlEybEF1YnZBRDQzZFBQYUlJTTFZeE8r?=
 =?utf-8?B?QU4yV09wd0ZuTlp2OVRvaysxaFpiSzBDcTVjWld0dWRwZjBYNGlUUzNCYlhz?=
 =?utf-8?B?SGJlUWVLdXoydkRTcjJ4WHQzcDVEZmI4bHBtbmRQcStDd0wyWG9lSllxOUxj?=
 =?utf-8?B?bzFtRFNxQnN5TTl3S0pBbzBjYWJrS2NocVNNR084QkJMUjRFNjg1NU9SU3Qw?=
 =?utf-8?B?NlhTbHJsZklXeHFNVmVoTlBkcGM2LzFFQU1rU0IzaWx2QktyQ1hFd3dCYXcx?=
 =?utf-8?B?VDNjNEVsdUE4OSs4Si80NmdROVQydFVyUDFHMEZpNlZ5OXBsOVdyMzFMV1A5?=
 =?utf-8?B?MWlCZ2diem9IbjUxbmhEbGU0UHZmYjR5RlYvRXlCbmYwVGN5VlYzWk14S1ZY?=
 =?utf-8?B?UkZmeWgxM3dnOTZOcTRwSDJYN2QyZkM3bCtwNy9GVVFkRDRJcGtWcDJONUl3?=
 =?utf-8?B?bnZ0d1ZLS0ZBQTkwaHl5d0psNjhVbG5xZ0VNUVVhZW5RRXlhWkRUM0JWVGp5?=
 =?utf-8?B?ajJhc3Z1ZjI1SGFrZDNrVlpzS1c4NnhGZWlRT1dYWGxEaDZ0cFY5TnZuQW9E?=
 =?utf-8?B?eDhMSEpuWlF4dlV3Ym9PYmRFeWVNWHU5Z1BUM0ZEK3dGbG95NkpaMDFsQnJX?=
 =?utf-8?B?c0lYK1FMWVhZNCtaYWRuWTVYRkl6d1ZjMzVaSVZzZ2RJek5BajU5NnNvL1BQ?=
 =?utf-8?B?cWZZS1Rrblc1R1ppUVRjOXVBSVR3ZndXczdGaCt5R1NWa0FsZzY3NUpDbnpq?=
 =?utf-8?B?a0JXZ0xLNjJVNGdGOFBtbDczZmpDZlpiVnFIaWNyZzVVZGxmMWZ4UHUzdzZG?=
 =?utf-8?B?TUNRd3V0MFRZTmZSUUVsTW5kS0dVRU0wTmV0dmlWNUF6Qk9pNWYyN1IrTUdu?=
 =?utf-8?B?NjVyeXYwb3B3SHVPQ010TkNlR3oxYThFbnFnendCNGFXV2ltRk1mQWwrdExH?=
 =?utf-8?B?V2hNL29tME1tYUhQbzh5RUZTN055NHhZTHY4RUV4eVR4L2d4dVlXVzdZSWo0?=
 =?utf-8?B?YXhsYXpFS3ZLdTVCRHZIVGpRejJvM1Nleml3SE55dU82YjV0OVNFTmk0allq?=
 =?utf-8?B?TVdSRkxVbEtXbnJCMS82VUxIdzBSa0xrS1E0KzZMNGZSZlZLcFZFRHJjM1BZ?=
 =?utf-8?B?bE56MTZBTlZlaWNkWnZ1eENSeHplYy9IWVluSm9WbVJqREZuR1Zhd0NrUkk2?=
 =?utf-8?B?eXFQRloxaEcwRURQWGI3UnplbVhuZmFjM1BRZHVsb3NCRDNNVDcvQkpuWkhM?=
 =?utf-8?B?dHRRSmFhWlI2dWJSQU9WTEhwQUxMUnJ5SXdBdlB6WUxaUzB4QUN2bFJCTTd1?=
 =?utf-8?B?c0N2THFQYms4SFdidjRGbTZBS25PZEhtZVRIaGE1bmtFRm4wdCtkcFRQbERk?=
 =?utf-8?B?U1U2TjdkQTl2N29BVSt0T2dsU2VuTlB4WEFhcytBUUlSbTQyMEFDV243V0Zv?=
 =?utf-8?B?MC9GZys2T0FPbC9FMjIxenpJY1BqNnNlVjJaNUNKOVF1YzluTEUzbFFqYjlS?=
 =?utf-8?B?U0xNMDdleDZOOTMySFJHTXJLb2dZTHUyV2xCZXZoa05oOTRwNTU1bHFlbWhz?=
 =?utf-8?B?REtLSnJvOU5FbzVGVGhrM21ZLzMza2U1cm5rZ2lKUnpiQ2NQNmlrbTFRaDV4?=
 =?utf-8?B?YXdxZmZOaWpFZGFqRkVYbTRubWdjOEdQN3lHV3U0eitWRHFrWlE2d2VwR0Nv?=
 =?utf-8?B?RWRSeG1jTWxUOUMrRWpFWEt5Vjkzci9naURYWmNYZ3hGSVVvUGp2enFNbWMz?=
 =?utf-8?B?Snc2R2E4L2pxazlHTGw1amtnVTJyL3VycmZVaWxCK3k0Y0ZZam9vVzB5RWlR?=
 =?utf-8?B?UEhEYmZyMFY3Tlllam5RSXNpOUp6UGNVMUJrN2tyb2N1QlQyR01vcmlXMU1a?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70c3a2bc-be51-4708-cec3-08dbc456e431
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:22:47.8964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KjokSAnQN5F2X5BPYfIb62Bsv6IfgR3YH23AjpRMwUvfo/GTlu/IY5x/+yiUia1HoL5gE6OYHG+tXMF34dhP1TeKuke8EP1AoHD4mBOn0m0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7603
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:23:09 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index c54fa86e4ef9..bd7f60bf49fe 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -60,11 +60,15 @@
>   * cpumask_any_housekeeping() - Choose any CPU in @mask, preferring those that
>   *			        aren't marked nohz_full
>   * @mask:	The mask to pick a CPU from.
> + * @exclude_cpu:The CPU to avoid picking.
>   *
> - * Returns a CPU in @mask. If there are housekeeping CPUs that don't use
> - * nohz_full, these are preferred.
> + * Returns a CPU from @mask, but not @exclude_cpu. If there are housekeeping
> + * CPUs that don't use nohz_full, these are preferred. Pass
> + * RESCTRL_PICK_ANY_CPU to avoid excluding any CPUs.
> + * Returns >= nr_cpu_ids if no CPUs are available.

It may be helpful to add that the function can only fail if exclude_cpu is
*not* RESCTRL_PICK_ANY_CPU. That helps to understand the sparse error checking.

>   */
> -static inline unsigned int cpumask_any_housekeeping(const struct cpumask *mask)
> +static inline unsigned int
> +cpumask_any_housekeeping(const struct cpumask *mask, int exclude_cpu)
>  {
>  	unsigned int cpu, hk_cpu;
>  
> @@ -73,6 +77,9 @@ static inline unsigned int cpumask_any_housekeeping(const struct cpumask *mask)
>  		return cpu;
>  

It is not obvious from this hunk but I cannot see how this would work
on a system without any nohz_full CPUs.

At this point the function looks like:

	cpu = cpumask_any(mask);
	if (!tick_nohz_full_cpu(cpu))
		return cpu;

I expected exclude_cpu to be taken into account. If I understand correctly
exclude_cpu can be picked by cpumask_any() and as long as it is not
a nohz_full CPU it would be returned.


>  	hk_cpu = cpumask_nth_andnot(0, mask, tick_nohz_full_mask);
> +	if (hk_cpu == exclude_cpu)
> +		hk_cpu = cpumask_nth_andnot(1, mask, tick_nohz_full_mask);
> +
>  	if (hk_cpu < nr_cpu_ids)
>  		cpu = hk_cpu;
>  
> @@ -565,11 +572,13 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,
>  		    struct rdt_domain *d, struct rdtgroup *rdtgrp,
>  		    int evtid, int first);
>  void mbm_setup_overflow_handler(struct rdt_domain *dom,
> -				unsigned long delay_ms);
> +				unsigned long delay_ms,
> +				int exclude_cpu);
>  void mbm_handle_overflow(struct work_struct *work);
>  void __init intel_rdt_mbm_apply_quirk(void);
>  bool is_mba_sc(struct rdt_resource *r);
> -void cqm_setup_limbo_handler(struct rdt_domain *dom, unsigned long delay_ms);
> +void cqm_setup_limbo_handler(struct rdt_domain *dom, unsigned long delay_ms,
> +			     int exclude_cpu);
>  void cqm_handle_limbo(struct work_struct *work);
>  bool has_busy_rmid(struct rdt_domain *d);
>  void __check_limbo(struct rdt_domain *d, bool force_free);
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 9c6d4b0970e2..208e46ba7368 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -480,7 +480,8 @@ static void add_rmid_to_limbo(struct rmid_entry *entry)
>  		 * setup up the limbo worker.
>  		 */
>  		if (!has_busy_rmid(d))
> -			cqm_setup_limbo_handler(d, CQM_LIMBOCHECK_INTERVAL);
> +			cqm_setup_limbo_handler(d, CQM_LIMBOCHECK_INTERVAL,
> +						RESCTRL_PICK_ANY_CPU);
>  		set_bit(idx, d->rmid_busy_llc);
>  		entry->busy++;
>  	}
> @@ -807,22 +808,31 @@ void cqm_handle_limbo(struct work_struct *work)
>  	__check_limbo(d, false);
>  
>  	if (has_busy_rmid(d)) {
> -		cpu = cpumask_any_housekeeping(&d->cpu_mask);
> +		cpu = cpumask_any_housekeeping(&d->cpu_mask, RESCTRL_PICK_ANY_CPU);
>  		schedule_delayed_work_on(cpu, &d->cqm_limbo, delay);
>  	}
>  
>  	mutex_unlock(&rdtgroup_mutex);
>  }
>  
> -void cqm_setup_limbo_handler(struct rdt_domain *dom, unsigned long delay_ms)
> +/**
> + * cqm_setup_limbo_handler() - Schedule the limbo handler to run for this
> + *                             domain.
> + * @delay_ms:      How far in the future the handler should run.
> + * @exclude_cpu:   Which CPU the handler should not run on,
> + *		   RESCTRL_PICK_ANY_CPU to pick any CPU.
> + */

arch/x86/kernel/cpu/resctrl/monitor.c:824: info: Scanning doc for function cqm_setup_limbo_handler
arch/x86/kernel/cpu/resctrl/monitor.c:832: warning: Function parameter or member 'dom' not described in 'cqm_setup_limbo_handler'


> +void cqm_setup_limbo_handler(struct rdt_domain *dom, unsigned long delay_ms,
> +			     int exclude_cpu)
>  {
>  	unsigned long delay = msecs_to_jiffies(delay_ms);
>  	int cpu;
>  
> -	cpu = cpumask_any_housekeeping(&dom->cpu_mask);
> +	cpu = cpumask_any_housekeeping(&dom->cpu_mask, exclude_cpu);
>  	dom->cqm_work_cpu = cpu;
>  
> -	schedule_delayed_work_on(cpu, &dom->cqm_limbo, delay);
> +	if (cpu < nr_cpu_ids)
> +		schedule_delayed_work_on(cpu, &dom->cqm_limbo, delay);
>  }
>  
>  void mbm_handle_overflow(struct work_struct *work)
> @@ -861,14 +871,22 @@ void mbm_handle_overflow(struct work_struct *work)
>  	 * Re-check for housekeeping CPUs. This allows the overflow handler to
>  	 * move off a nohz_full CPU quickly.
>  	 */
> -	cpu = cpumask_any_housekeeping(&d->cpu_mask);
> +	cpu = cpumask_any_housekeeping(&d->cpu_mask, RESCTRL_PICK_ANY_CPU);
>  	schedule_delayed_work_on(cpu, &d->mbm_over, delay);
>  
>  out_unlock:
>  	mutex_unlock(&rdtgroup_mutex);
>  }
>  
> -void mbm_setup_overflow_handler(struct rdt_domain *dom, unsigned long delay_ms)
> +/**
> + * mbm_setup_overflow_handler() - Schedule the overflow handler to run for this
> + *                                domain.
> + * @delay_ms:      How far in the future the handler should run.
> + * @exclude_cpu:   Which CPU the handler should not run on,
> + *		   RESCTRL_PICK_ANY_CPU to pick any CPU.
> + */

arch/x86/kernel/cpu/resctrl/monitor.c:887: info: Scanning doc for function mbm_setup_overflow_handler
arch/x86/kernel/cpu/resctrl/monitor.c:895: warning: Function parameter or member 'dom' not described in 'mbm_setup_overflow_handler'


> +void mbm_setup_overflow_handler(struct rdt_domain *dom, unsigned long delay_ms,
> +				int exclude_cpu)
>  {
>  	unsigned long delay = msecs_to_jiffies(delay_ms);
>  	int cpu;
> @@ -879,9 +897,11 @@ void mbm_setup_overflow_handler(struct rdt_domain *dom, unsigned long delay_ms)
>  	 */
>  	if (!resctrl_mounted || !resctrl_arch_mon_capable())
>  		return;
> -	cpu = cpumask_any_housekeeping(&dom->cpu_mask);
> +	cpu = cpumask_any_housekeeping(&dom->cpu_mask, exclude_cpu);
>  	dom->mbm_work_cpu = cpu;
> -	schedule_delayed_work_on(cpu, &dom->mbm_over, delay);
> +
> +	if (cpu < nr_cpu_ids)
> +		schedule_delayed_work_on(cpu, &dom->mbm_over, delay);
>  }
>  
>  static int dom_data_init(struct rdt_resource *r)
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 0c609cdfe7e5..49f100c73838 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -2552,7 +2552,8 @@ static int rdt_get_tree(struct fs_context *fc)
>  	if (is_mbm_enabled()) {
>  		r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>  		list_for_each_entry(dom, &r->domains, list)
> -			mbm_setup_overflow_handler(dom, MBM_OVERFLOW_INTERVAL);
> +			mbm_setup_overflow_handler(dom, MBM_OVERFLOW_INTERVAL,
> +						   RESCTRL_PICK_ANY_CPU);
>  	}
>  
>  	goto out;
> @@ -3850,7 +3851,8 @@ int resctrl_online_domain(struct rdt_resource *r, struct rdt_domain *d)
>  
>  	if (is_mbm_enabled()) {
>  		INIT_DELAYED_WORK(&d->mbm_over, mbm_handle_overflow);
> -		mbm_setup_overflow_handler(d, MBM_OVERFLOW_INTERVAL);
> +		mbm_setup_overflow_handler(d, MBM_OVERFLOW_INTERVAL,
> +					   RESCTRL_PICK_ANY_CPU);
>  	}
>  
>  	if (is_llc_occupancy_enabled())
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 9d5f75a4e192..0888d1975161 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -10,6 +10,8 @@
>  #define RESCTRL_RESERVED_CLOSID		0
>  #define RESCTRL_RESERVED_RMID		0
>  
> +#define RESCTRL_PICK_ANY_CPU		-1
> +
>  #ifdef CONFIG_PROC_CPU_RESCTRL
>  
>  int proc_resctrl_show(struct seq_file *m,

Reinette