Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <f6d476e1-ce8a-e680-b9ec-d5c2d78bc387@intel.com>
Date:   Tue, 3 Oct 2023 14:23:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 23/24] x86/resctrl: Move domain helper migration into
 resctrl_offline_cpu()
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-24-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-24-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE4rSThrdmsvYjQ2aStRdU1DdTR3bWtXdWJoVU1WUjR1djl4U2I3QW9EYWJO?=
 =?utf-8?B?R2tQa2FmdDFJdlp6QVlZcEVVMU5XN0hremRKNWQ5cmRQSzYxbXpKR1JCTXZm?=
 =?utf-8?B?RllsZUJkVm9FTUYxZlBLZm1NRXU1dXl1MlpISDhEa2NjL29VZnlHaklNYyts?=
 =?utf-8?B?QmJPTDZ3VWFqd3RMd0NodEQyMVFBSWRqTWVmWDdycWdxci9GUTRiTmJjQzcx?=
 =?utf-8?B?bFRmcmwvcEF6Mks2U0Y1NlBlMnMzYXVTVm9OV3RYWE0velJrSi8xTHczd2dT?=
 =?utf-8?B?dGJFdWxBL0kwaVZkUDdnOElRaGZTNW8wMDBMTzdMTkFuUmhFYkVkZXNnV2dN?=
 =?utf-8?B?ZXo2KzR3R1R6b2dTSFhvR0VIQ0U0QjRpd25OcGdPTVhCenN5YVphK09yUXpD?=
 =?utf-8?B?Qm8vSXRoZnJINGIrTk9uTDJBRXVadWMvWEFubGtqNUQvZnJ0MVZhZ3JlMUZt?=
 =?utf-8?B?SEU1ZWl2TzQ3bFk5VlNEZjBLMWd1d2lzRVh0ZlVUSEUrSFRSR3U0M3pFQTlN?=
 =?utf-8?B?aER4RWxZUUpyelBHZG9xV29wNXYyRlhNRnRaM0pDcGNYTnJYUnFULzZqdGFX?=
 =?utf-8?B?Y1dnUE9DZ0sveU0wa0NKa0ZDM053bmlqazdDSTh5eUc1R09tbk9Rb3QwN1pF?=
 =?utf-8?B?VzAyK3BjYll4ZDBFQm1ZTk5FOUlUenBhOGVRdGh3b3ZDeU1QOUhNY2lDU3Fi?=
 =?utf-8?B?Nk9STFZjR0xMVFhzOUVjaTU4MERKTTVhckwvbXE1ejU4NFZyODNOUDVQM3Nk?=
 =?utf-8?B?VzFKdms0VVJDV1BxeGtnZW8wdWRvaDMxR3JScVIvZUJiMXhlN3lKUWFKOTV6?=
 =?utf-8?B?WXVSOW0vWjQzaGxDWkozS25mZVRUdnZuYThMRzZsZEZaSVZ4OU9iWGZOeldB?=
 =?utf-8?B?STNoRGJ3Uk4wV29COUJMdzlGUkUyTzBHR2Q5d1E5ek1ZVldRSU5JTmRFWHFa?=
 =?utf-8?B?bEpBcGlMSXJQYTBDMWpUamgzc3VxUTVqc3Q2SXphdkFlQ3RNWUdTV2lzVDRD?=
 =?utf-8?B?TzhJOWV2dG1zQTEydFZSK0VNSk5RaUI4byttUzkwenM0Y3Nub0VBRjJNbXNo?=
 =?utf-8?B?NVpVSXFrY3d0czZPN2NGT0l3TUw3bTQ1M0JTa0tZSnAwS2VNbkx1U2VVQnhl?=
 =?utf-8?B?d0o3bnN4OVBjdmd6YStqeDErSHNNTS94bHFzZFBtZ2IvK2dHVVYzZTZCYmxP?=
 =?utf-8?B?REIvSjJKcHp3TURwNVdlSkJiazlUdlBEc2U2U2VHazJDODZ3RnNldnFDbmh1?=
 =?utf-8?B?NFNYYTlNem1WQTEyZXpQc3EydlIwdzJBZGFQRjk2aXhjSXBVTXhhdzFWbmxB?=
 =?utf-8?B?R3ExaHJZNHJFOHB3OCtuUDBad3pGQ2pzWXVMMUpJMU1OV1dKejM0NWZVZktN?=
 =?utf-8?B?bXAvRGlXWXVaaFJPRU5NRk0reW1YL1UxQkFMUlE2dUQ4bHNaNUp1V1ViNWZL?=
 =?utf-8?B?Z091aHIwb0NmbUdJSEFGR1ptSUVJTmk5MDJDZExkUEdLMVpzclRreVBOQ0ND?=
 =?utf-8?B?dWJTYjN3WnFxd3Rkc2JRa2hYTllBQzl4U0s0cUpRMys2aHAxLzhSQ2JhK3dn?=
 =?utf-8?B?dVVpSEltSlpvTjZUdFdsd0ZXaDlOZW93ak44cU5PUkcyUjFGcVpzRVc2ckVD?=
 =?utf-8?B?M0wvZWpMWlV2NURtUWsxYlBJUnpPR3Rtejljamp2SDJyRWVNRWdCUDdub0Vy?=
 =?utf-8?B?bklYSEowT0xDazljK0JGRlBiUklucmFURldiN215SDl4L01RaEI4cXVLZXdq?=
 =?utf-8?B?eEorcXNUbTRXaXdkVEZNV0F6enU1dEpJV0pVZ0FEay8xa3ZUL1RUdWRidUhL?=
 =?utf-8?B?cGVVNFNHZ1paNzB3M3RXbEUxb1Q2bm1OaWM3SWJMTEd5bGdIWlhrNEYxR3Q3?=
 =?utf-8?B?Q2swc2tNbldWRGtuVE12RCs0TjlLczRUQ0xCb2V5WVZIT0RadzhPMi9TRHQx?=
 =?utf-8?B?QmhobUlDNXJzcWtwL0NsZkxkSnF5YmdDN213ZG51ek52SVBwZDY2VFNKbWFI?=
 =?utf-8?B?T1hRYVlNSFpxRUdHVmJ4TldxeHliZmlyNFlWVEpiVzhsSHFERWxxWGpyMGUv?=
 =?utf-8?B?NWFiSUJXVEt1Y1o2aGVEcnR5NlZRMERIZ2pGWjVzYkJONjZ0S2IweXEzbGtV?=
 =?utf-8?B?RTNmSFRZYzVJeGFtM3VRNXFXUXVKNElodWt3WUFIajByUDU0b0xBTE5WRkJr?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 107347aa-32e7-420f-12d6-08dbc457022b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:23:38.1781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rIDwfIqcAP0PQdC8GgrSTxmXdllIC6tMvEyLQJ9VRkAshP/OB7Yk5lsiqcn1hPkE6tXAS+vl47wr1Y1p4tZ/5uwBqEB/OD7Kr0t0bMyH79A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5175
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:23:56 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> When a CPU is taken offline the resctrl filesystem code needs to check
> if it was the CPU nominated to perform the periodic overflow and limbo
> work. If so, another CPU needs to be chosen to do this work.
> 
> This is currently done in core.c, mixed in with the code that removes
> the CPU from the domain's mask, and potentially free()s the domain.
> 
> Move the migration of the overflow and limbo helpers into the filesystem
> code, into resctrl_offline_cpu(). As resctrl_offline_cpu() runs before
> the architecture code has removed the CPU from the domain mask, the
> callers need to be told which CPU is being removed, to avoid picking
> it as the new CPU. This uses the exclude_cpu feature previously
> added.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette