Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 03 Oct 2023 14:56:09 -0700
From:   "H. Peter Anvin" <hpa@zytor.com>
To:     linux-kernel@vger.kernel.org,
        tip-bot2 for Yuntao Wang <tip-bot2@linutronix.de>,
        linux-tip-commits@vger.kernel.org
CC:     Yuntao Wang <ytcoode@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        x86@kernel.org
Subject: Re: [tip: x86/boot] x86/boot: Fix incorrect startup_gdt_descr.size
User-Agent: K-9 Mail for Android
In-Reply-To: <169632239730.3135.5499875554711156270.tip-bot2@tip-bot2>
References: <20230807084547.217390-1-ytcoode@gmail.com> <169632239730.3135.5499875554711156270.tip-bot2@tip-bot2>
Message-ID: <CBF7285B-C6F9-4539-ADA2-A626EAE1A73F@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On October 3, 2023 1:39:57 AM PDT, tip-bot2 for Yuntao Wang <tip-bot2@linut=
ronix=2Ede> wrote:
>The following commit has been merged into the x86/boot branch of tip:
>
>Commit-ID:     001470fed5959d01faecbd57fcf2f60294da0de1
>Gitweb:        https://git=2Ekernel=2Eorg/tip/001470fed5959d01faecbd57fcf=
2f60294da0de1
>Author:        Yuntao Wang <ytcoode@gmail=2Ecom>
>AuthorDate:    Mon, 07 Aug 2023 16:45:47 +08:00
>Committer:     Ingo Molnar <mingo@kernel=2Eorg>
>CommitterDate: Tue, 03 Oct 2023 10:28:29 +02:00
>
>x86/boot: Fix incorrect startup_gdt_descr=2Esize
>
>Since the size value is added to the base address to yield the last valid
>byte address of the GDT, the current size value of startup_gdt_descr is
>incorrect (too large by one), fix it=2E
>
>[ mingo: This probably never mattered, because startup_gdt[] is only used
>         in a very controlled fashion - but make it consistent neverthele=
ss=2E ]
>
>Fixes: 866b556efa12 ("x86/head/64: Install startup GDT")
>Signed-off-by: Yuntao Wang <ytcoode@gmail=2Ecom>
>Signed-off-by: Ingo Molnar <mingo@kernel=2Eorg>
>Cc: "H=2E Peter Anvin" <hpa@zytor=2Ecom>
>Link: https://lore=2Ekernel=2Eorg/r/20230807084547=2E217390-1-ytcoode@gma=
il=2Ecom
>---
> arch/x86/kernel/head64=2Ec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/head64=2Ec b/arch/x86/kernel/head64=2Ec
>index 49f7629=2E=2Ebbc2179 100644
>--- a/arch/x86/kernel/head64=2Ec
>+++ b/arch/x86/kernel/head64=2Ec
>@@ -80,7 +80,7 @@ static struct desc_struct startup_gdt[GDT_ENTRIES] =3D =
{
>  * while the kernel still uses a direct mapping=2E
>  */
> static struct desc_ptr startup_gdt_descr =3D {
>-	=2Esize =3D sizeof(startup_gdt),
>+	=2Esize =3D sizeof(startup_gdt)-1,
> 	=2Eaddress =3D 0,
> };
>=20

Well, it never mattered because there wasn't enough space at the end for a=
n extra entry, but it is still Technically Correct=E2=84=A2=2E