Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <727579ab-94d5-49d5-aee0-23e69b9472ad@oracle.com>
Date:   Tue, 3 Oct 2023 18:22:28 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] jfs: fix array-index-out-of-bounds in diAlloc
Content-Language: en-US
To:     Manas Ghandat <ghandatmanas@gmail.com>, shaggy@kernel.org
Cc:     jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Linux-kernel-mentees@lists.linuxfoundation.org
References: <20230926071312.14086-1-ghandatmanas@gmail.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20230926071312.14086-1-ghandatmanas@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2RkSU5sSXp5RW85dlR1cHh5ck9FR3d6TFBtMUVZMWNjOHJkZFI2bEorc1h0?=
 =?utf-8?B?alhtaEpyMmQ2UVIwRHN2SGw2Mk11VTRPbXZjcTdsMGJHbWdqV0lhYjcva0RG?=
 =?utf-8?B?c0xkNmdZdzBwRjRQS3lxYitQKzBhZWRpcXFWemZ1RmwyS21rcU95aDc4Wnhs?=
 =?utf-8?B?T1pXYWlFQ09JWWRwTGJ0WVJLa0RyNlRsdnJoT0tIOG92ZnlpbDBRWC9ZYTB5?=
 =?utf-8?B?L0NOdXBhdzcxaVJDWm5reWhsN0Z3L2xkZzRzT29xZ05ZZXBsaDFFbXJGdWRC?=
 =?utf-8?B?cWVqN3BVSlhLNExhQWJES2tuQ2xPZFVBRkNJVnV5VWhKUVY4MUpDQzBVd0VS?=
 =?utf-8?B?dWt3RWRRQmJxSWJuQ1d2OWJya1JKOFc0QnBwYlArRHJlTzVhQ3czUlZCYm5m?=
 =?utf-8?B?d3NRckMxREhib1k0NDBXMWZKNmxqc0tzY3NIdkNiWlBJQXRkNTVxeHhyZnY1?=
 =?utf-8?B?Y1pKSU9Pclhwd0gySzJPeXdSTm16MEhkbTVqQzhCVFcvbEdrMnhQS1NVUEZI?=
 =?utf-8?B?cVluWmxaTUZkaTNWTm5IS1lYS21nV3J0TWszZm02MWxvQ3pvTGNLcDJOcHg4?=
 =?utf-8?B?dklseWlkbENpYksrZTBRTklyWFBkRUFzZUlUdStUa3ZlcE9RN1REb2tGSFBv?=
 =?utf-8?B?TGM5cS9NNHkrRmN3SUlUOXVjdnVuMHE0SHVoUDlWRTYzUlNIbXF4a0gvRjN5?=
 =?utf-8?B?bGNYOXZmWFBCazdKbmh3ckNvVSsvT0w1T1N4bGE1Vm40dG1LeFRaMmZ2VW0w?=
 =?utf-8?B?dkpwZzhJdkRlWENNa1BlRHFBTHFwOTlqdEpTZjlnQ3RNNkFQMUQ0eHR5S1BH?=
 =?utf-8?B?VjZpbjBIRDN1ZC9mdkVSV1ZERlQwbDYyVmdoajlyN3hSKzFubjF5QS9xeXJ0?=
 =?utf-8?B?UWRLMnJsSDRiZjZFR3dCSnFNeXpQMGxORzQxbTE0Y3Y0SXBGRFBLbWgzSlZ3?=
 =?utf-8?B?TncvbEFlS25wai9obDRwVHo5aTRLQzJocjJ4L2t0UGF4LzRNZk1QUUp0UlQy?=
 =?utf-8?B?dWw5NENINXo0dkZML0VITjJ1Vjl1WUJrNUFlSFhWbC9kR2k2UjcwRHFkNWNG?=
 =?utf-8?B?Yko5MDB6YWxsV3Bnd2dNb2wyZG5LdWpna0VyRmpsZWQyNEtjS0JRN2FuODJJ?=
 =?utf-8?B?dDJjTktBdHAwZFNKeUNodlBYV1Y2MjZxVldLVk5EZE80b2UveE1URDNOV29x?=
 =?utf-8?B?OW5Sa3dHQ2piZlYxVEpKSWpVanFYc2QzbXB5OEgyYkVQSFZ6WklEUmRxMTFV?=
 =?utf-8?B?aTNsRW81UElhTmtYc1V6VnZNYitPeEludjR4emJJdmhKT2VJVGVySkNLb044?=
 =?utf-8?B?S0srUTV4UFdIblRkTnVtaVBWSGwwSXgrbFVZSUZSUEFDUkl1QXpyYkVLNmZu?=
 =?utf-8?B?aHhBKzQ1YjJPZVhISFh1V2FMVWpvS1ZFVVYwd0ZySXd2SE5ERnBYQi9wZHJq?=
 =?utf-8?B?QUNsUkkxZmdzOWhvQlA4czhsdkN0b0YvNW5Qc2lsSTNrUVhUOHZXVllRc05y?=
 =?utf-8?B?NVphbkI1SzBET1lsOFkzRzdQaWJ3R1BkUHVqWmxTdTR3MkgxKzFXTjBOdFlY?=
 =?utf-8?B?OWwwZ0ZNb0h2MzlBRjhoaXdNUmZqallUNUhYUGkzcEZ2SEJJOGx6eUJYNnNz?=
 =?utf-8?B?dThxVnpielVJb0NDV3gzMzdFaGJHd1doVHJ3djZIVVIzOEtpTWNaTUxKK2hi?=
 =?utf-8?B?cmg0WjcvM2pZZkF3UHZYU2hncXM2NzFqK3JjdVBkb2NYMDNGS1R1MWhjK3A5?=
 =?utf-8?B?ZDRWNzFXb2I2a2JmTlY5dFFlQkpWRnJwSmIyaHF4a0ZLdGZXaGVkSStQWG9t?=
 =?utf-8?B?amxma1A1WjFiWktPY2lWYWRuUldlVzVWVjQzVHhDeHdubmcyN1FVT2MzS0Jt?=
 =?utf-8?B?cFZVMVlyVDBrRG9uL1RTSWRZNjRIZVB3ZFF5TTNTUlZSbGozQ3VKeHd2VzFU?=
 =?utf-8?B?Wkd0azcwOTZBM0RrdTFPbHNmTVprTXh6TWZlYWJSTSt2eHF0eW5UZkZqZXZ2?=
 =?utf-8?B?QlRxQjNFc1NkVlRNK2djTDZmaklJbEMrWS8rcGgrNFdOMmF4ZHp5b2hGVWNP?=
 =?utf-8?B?Ym9iZnJtcFc4bURXVFhzMlIwWE5QaWVhT01LbEFVN2JoUTJRREIrMVpuanRa?=
 =?utf-8?B?WkN1SEJMZlFnMHhPSmI5RGZNYUlHRnQzWFphOWFza0doQmc1TGVtK1dzRmtO?=
 =?utf-8?B?c1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UjFWTEtPa1BRRkY0ZzVmK2ovdHMrNnh5K3NSR2hpOEd0Z0hvVUhWY0pwaW0y?=
 =?utf-8?B?QW9oUlgrU1p3cXpRTnlVMzdQbmFZUmErcjhQelRBWllJU3RIYTFERmxPa0ZE?=
 =?utf-8?B?N2tScGxhdFN2RklLNVVKOXJoa3g5QnNVOFlxSGM2OFlvTE5TTXFQZXVFTkM0?=
 =?utf-8?B?V29VMnZENG5heXJsUDZKSTV6N0hJQllFaHNVSTRidUFvWkxNWWVLbTNNOWVu?=
 =?utf-8?B?RmN6RWN5Q1dvUFVZdUhCMmpxT1AwUUxWRkZBSnlqNVJDQ3FQcVN5THJNcWs3?=
 =?utf-8?B?UlRCUVlmMmdLT1pYNEFzNnBmclZUdVdFcUpwbCtaOTZ3UWhHdHM1QnFrTmN0?=
 =?utf-8?B?WUx2ako5eERTR1cyaUZvcUNHbTZMSjlla1U2VHphRUtRSXFSUlpKRzh5aThQ?=
 =?utf-8?B?cDdKOTUwdXhQM01JcTlvUjFBWTQ2RFNKQXlZamdJdE5LempWL0tmNkpsUkNz?=
 =?utf-8?B?SnpqdlBNajJOWVQ4YVFoampsZlRySDZScUgxTWtleU5UVWFxQkcwS2p3WEx6?=
 =?utf-8?B?cG5BejBMWmVmcnVPVFZ3T3B3MkJWMkJxYUZTM2NUZTEycisvT1NYZytpWnRy?=
 =?utf-8?B?VFdhTVF1TEM0NFNKejJZSjI1a3ErN0Z6VzNOU2RDMkxwanVodDhGNmtiV2pn?=
 =?utf-8?B?V08yYVJnc05ET1JTdi9zTWpDR3pvMXBnWThGM0hwTTBPUGMwQ1puMUVYSWhM?=
 =?utf-8?B?UW93VThhT25sVERhem9QK05vNW5PWTk5ckNLQ05GVjdsYlBEK1J6OGRKNVVq?=
 =?utf-8?B?Y2Q2SGR5MTl2MW50MjY5SlV1dWxUSjRFc1NYWnlrd0dXUUpxeDM0TWtaYVZR?=
 =?utf-8?B?dHAwVjc5K2Z0T0E4SUdUaisvaklMSHdMWjladUZRbVFXYXh2QlVYREVIZkVz?=
 =?utf-8?B?UlpLbTFOZ2g0UXlwN29BaWVoejVwZWFwdUQwdG9uczN3ajlreVpmZFBWSkw1?=
 =?utf-8?B?cUxDN0svcWJpcHZvZXhCQkNBaHBYUFpBbG16VmVCYkxHbmdBSUFMSUhBd3oy?=
 =?utf-8?B?SXBrcnEwVHZUa1R4QlE2L0RRcUc0dWFPOHZNUlVsaDFtSmtIQmhhN0pEVmhC?=
 =?utf-8?B?MVJBUFF1emNhZXRlaFFhQXVWWjFqbHdFNHNXS2hyU0MzbjJwQUVwU3ZPakJ0?=
 =?utf-8?B?dTBXcGdjWHFDTlVoR0ordGxEMEpCdExGNTFZWWlNQkxxcVZ5TnFUMjcrZkNR?=
 =?utf-8?B?M2k5Z00xNWVYTTZQdW9xT3c3WmpSamV4V2pYRFlFamN4TFVCSms1SFBpOGhB?=
 =?utf-8?Q?oWlpokuZ21SHf8A?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b979484-26fb-40a2-845d-08dbc4679e18
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 23:22:31.8331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NDNSstA7xBG0hiDE+fqVPgHzG3QTR7MkdjJnysrgyeFd3Dwnzmh1TZJVG14TPMNPgcI0OK9ytV00tJCLpvKc189sSm0IH0XP2hAWTsUj4Bg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4396
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_18,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 spamscore=0
 mlxscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030177
X-Proofpoint-ORIG-GUID: 8_-6KmTYhlgGfQdpAXu8Jx4FHTptc7kf
X-Proofpoint-GUID: 8_-6KmTYhlgGfQdpAXu8Jx4FHTptc7kf
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 16:23:01 -0700 (PDT)

On 9/26/23 2:13AM, Manas Ghandat wrote:
> Currently there is not check against the agno of the iag while
> allocating new inodes to avoid fragmentation problem. Added the check
> which is required.

Does this fix an observed problem? It seems reasonable and if we add 
this we may also want to make sure that agno doesn't exceed db_numag,
(JFS_SBI(pip->i_sb)->bmap->db_numag) (yuck).

> 
> Signed-off-by: Manas Ghandat <ghandatmanas@gmail.com>
> ---
>   fs/jfs/jfs_imap.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c
> index 799d3837e7c2..ace8a1506380 100644
> --- a/fs/jfs/jfs_imap.c
> +++ b/fs/jfs/jfs_imap.c
> @@ -1355,6 +1355,8 @@ int diAlloc(struct inode *pip, bool dir, struct inode *ip)
>   
>   	/* get the ag number of this iag */
>   	agno = BLKTOAG(JFS_IP(pip)->agstart, JFS_SBI(pip->i_sb));
> +	if (agno < 0)
> +		return -EIO;
>   
>   	if (atomic_read(&JFS_SBI(pip->i_sb)->bmap->db_active[agno])) {
>   		/*