Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2283448rdb; Tue, 3 Oct 2023 16:56:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrttWr9ERM3lnQEltkjg1ClzVwvqkKDpMv7FCy+Nu06ohb2SQ4DuqihAf9vMO7j5ZxfLnG X-Received: by 2002:a25:e010:0:b0:d8f:1f07:afbf with SMTP id x16-20020a25e010000000b00d8f1f07afbfmr712088ybg.45.1696377396024; Tue, 03 Oct 2023 16:56:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696377395; cv=none; d=google.com; s=arc-20160816; b=NN2ATjFJco/5pN2ZvbgelZwOkRCD/5XmlVVSOpEqpTOoBDeEt4dQJJNQedeFUuRP5N tj+KwTFsrkPOkjAwzRUCij7nBQ9KGYY72wtVbBvJZL2kaHR6cabhWYBSrXSlLt/F23zX wr8tKNuCHAV7qMf/tFR6LdcLms6oGpQqCUiHwM56xSXOgGKXiHeAq9J3mluf6bO8/VVl EzsBlhtwqycOGWETPj2wjw0Spbqo2Cw/AVHp7YxW4yRHXvOJ3qIQythyGLY+V1JuUJBB 8JeN1qXTItSyig4DFRn6WPNPMTXMGWvmyqM07cBkbMqlCefU+gHLF+Tek32yl8owE58B /RRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2zDSZaEXmJ2Rq3hJpJCUNWtVnDT1OU4Zatqdb0xDsNA=; fh=WrfoMEz+TsK1uR7ZyCWlBS+t+ktagqyqc0KN3abBbSs=; b=B6OhT6WXxe6CvoEwpoKyGhyoTZNbphhUwRuzyf2qzzX1QrgUqdqujn+0+a28lS/rD2 fp2GxJbm2H7CS96k9fFiywswd99k3kxu4ooJl6PQbIwKr4CF/aM4Yal3fWm5jnovrv+t O7aCJ56cKnV5RfH2CWZYHo/YDf7DI24IL17j3pGMjZb2i8piivs8EF9NCd7+aeDUCZH7 HQWhcyxO76y7cVQT5zeFBtLUEFV0Uyzb9UToGh9f3mqMIC+NSUuUmpTKGFnmDPBfTmKe 35yQFFilmYWOAMxhDAfkYfGMgFuoA1/INY/TPppiPwIS47uSW+gZV1T8TljZOFTqyrT5 8MNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oCPyIjon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id v6-20020a634646000000b005852a35aff4si2584592pgk.227.2023.10.03.16.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 16:56:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oCPyIjon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 92373808E570; Tue, 3 Oct 2023 16:56:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239384AbjJCXzc (ORCPT + 99 others); Tue, 3 Oct 2023 19:55:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238655AbjJCXzK (ORCPT ); Tue, 3 Oct 2023 19:55:10 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17727E3 for ; Tue, 3 Oct 2023 16:55:06 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-690bd59322dso1154012b3a.3 for ; Tue, 03 Oct 2023 16:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696377303; x=1696982103; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2zDSZaEXmJ2Rq3hJpJCUNWtVnDT1OU4Zatqdb0xDsNA=; b=oCPyIjonwDbbQcQ/j8mCdWLmijTjql6Qk0JNCezOsz6FZLz2/fS+AojQJ8z0hdQd2R NiymEJ82Cx9XVK0SpqTxE5ABU5AcRLcIHg36D7WVYHNClfUUUx6CjQcfSVOQgMXBuXVk 73Dlhm27P8lDk4zCnOVR5qw87hHO0k/89i6b0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696377303; x=1696982103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2zDSZaEXmJ2Rq3hJpJCUNWtVnDT1OU4Zatqdb0xDsNA=; b=RvakGjruiJC97215yMq9CFbeXXyv78pb3X28WoYlWCbuON+pf38g5vLsFSy1XNO5o/ gyU6ULm3Ft347F+OJJWEmwX1xLkqQE21HbaNsTYpL4y0tNYlikF7Cxb41eA3DMzFPQhK rqLq1QbXJpuf1hP2+VtDmTfObkLV0alofdsYv4OQ2EzcxNmb/gHRe+XeH8huPoJo3PJI wtwnh6htAmT8KM9TkJ0EH2of3PqvwsNO+HWALDeVpaTq7xPzEw9I/5ascsyNwOP6F0R5 fUb56VihwOMADx7+UsuYH9yNCSrxW1U+Rv5y2XaFLBTNhuHuNjpHj9DICATbnmcKDbWk dALw== X-Gm-Message-State: AOJu0YzEwQ/NPRTH+eLYa/N836BohK3gLUn4Hu8fL09CcT3OtiHj6X+v RXFmnP6eS1ylY3AZwG9oIrgPwA== X-Received: by 2002:a05:6a00:1511:b0:68e:2cf2:1613 with SMTP id q17-20020a056a00151100b0068e2cf21613mr1144614pfu.3.1696377302885; Tue, 03 Oct 2023 16:55:02 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id gx13-20020a056a001e0d00b006934390d0c5sm2012467pfb.175.2023.10.03.16.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 16:55:02 -0700 (PDT) From: Kees Cook To: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Justin Stitt Cc: Kees Cook , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] accessibility: speakup: refactor deprecated strncpy Date: Tue, 3 Oct 2023 16:53:47 -0700 Message-Id: <169637722416.168837.4167782621423487593.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230918-strncpy-drivers-accessibility-speakup-kobjects-c-v2-1-d5b1976c5dbf@google.com> References: <20230918-strncpy-drivers-accessibility-speakup-kobjects-c-v2-1-d5b1976c5dbf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 16:56:03 -0700 (PDT) On Mon, 18 Sep 2023 05:30:15 +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > Let's refactor this function to just use synth_write(). > > Thanks for the testing! It's been 2 week without any more comments, so I'll snag this. Applied to for-next/hardening, thanks! [1/1] accessibility: speakup: refactor deprecated strncpy https://git.kernel.org/kees/c/692c013e8f37 Take care, -- Kees Cook