Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231003074911.220216-1-colin.i.king@gmail.com>
In-Reply-To: <20231003074911.220216-1-colin.i.king@gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 3 Oct 2023 18:07:00 -0700
Message-ID: <CAP-5=fXO6+Cgvo4BmC9fgL70FY+ciPjRVR5qghxYBR3VSB7WNQ@mail.gmail.com>
Subject: Re: [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
To:     Colin Ian King <colin.i.king@gmail.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, linux-perf-users@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 3, 2023 at 12:49=E2=80=AFAM Colin Ian King <colin.i.king@gmail.=
com> wrote:
>
> There are spelling mistakes in comments and a pr_debug message. Fix them.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

+ Athira Rajeev

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/parse-events.c        | 4 ++--
>  tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-eve=
nts.c
> index f78be21a5999..e52f45c7c3d1 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test=
 __maybe_unused, int subtest
>                         if (strchr(ent->d_name, '.'))
>                                 continue;
>
> -                       /* exclude parametrized ones (name contains '?') =
*/
> +                       /* exclude parameterized ones (name contains '?')=
 */
>                         n =3D snprintf(pmu_event, sizeof(pmu_event), "%s%=
s", path, ent->d_name);
>                         if (n >=3D PATH_MAX) {
>                                 pr_err("pmu event name crossed PATH_MAX(%=
d) size\n", PATH_MAX);
> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test=
 __maybe_unused, int subtest
>                         fclose(file);
>
>                         if (is_event_parameterized =3D=3D 1) {
> -                               pr_debug("skipping parametrized PMU event=
: %s which contains ?\n", pmu_event);
> +                               pr_debug("skipping parameterized PMU even=
t: %s which contains ?\n", pmu_event);
>                                 continue;
>                         }
>
> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/sh=
ell/stat_all_pmu.sh
> index c77955419173..d2a3506e0d19 100755
> --- a/tools/perf/tests/shell/stat_all_pmu.sh
> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
> @@ -4,7 +4,7 @@
>
>  set -e
>
> -# Test all PMU events; however exclude parametrized ones (name contains =
'?')
> +# Test all PMU events; however exclude parameterized ones (name contains=
 '?')
>  for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+=
[[:space:]]//g'); do
>    echo "Testing $p"
>    result=3D$(perf stat -e "$p" true 2>&1)
> --
> 2.39.2
>