Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 3 Oct 2023 19:50:28 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Sebastian Ott <sebott@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the execve tree
Message-ID: <202310031950.E698038489@keescook>
References: <20231003133522.310bda60@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231003133522.310bda60@canb.auug.org.au>
Precedence: bulk

On Tue, Oct 03, 2023 at 01:35:22PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the execve tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> fs/binfmt_elf.c: In function 'load_elf_library':
> fs/binfmt_elf.c:1323:37: error: unused variable 'len' [-Werror=unused-variable]
>  1323 |         unsigned long elf_bss, bss, len;
>       |                                     ^~~
> fs/binfmt_elf.c:1323:32: error: unused variable 'bss' [-Werror=unused-variable]
>  1323 |         unsigned long elf_bss, bss, len;
>       |                                ^~~
> fs/binfmt_elf.c:1323:23: error: unused variable 'elf_bss' [-Werror=unused-variable]
>  1323 |         unsigned long elf_bss, bss, len;
>       |                       ^~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   f2a1e5fab9ae ("binfmt_elf: Use elf_load() for library")
> 
> I have used the execve tree from next-20230929 for today.

Whoops! Fixed now. Thanks. :)

-- 
Kees Cook