Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Feedback-ID: ie8e14432:Fastmail
Date:   Wed, 4 Oct 2023 13:03:49 +0900
From:   Takashi Sakamoto <o-takashi@sakamocchi.jp>
To:     Kai Bosch <kellerassel@gmail.com>
Cc:     linux1394-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Kai Bosch <kbosch@protonmail.com>
Subject: Re: [PATCH] Firewire: IP over IEEE 1394: replaced implicit mentions
 of unsigned int
Message-ID: <20231004040349.GA53158@workstation.local>
Mail-Followup-To: Kai Bosch <kellerassel@gmail.com>,
        linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Kai Bosch <kbosch@protonmail.com>
References: <20231003211650.349521-1-kbosch@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231003211650.349521-1-kbosch@protonmail.com>
Precedence: bulk

Hi,

Thanks for your sending the patch.

On Tue, Oct 03, 2023 at 09:16:50PM +0000, Kai Bosch wrote:
> ---
>  drivers/firewire/net.c | 48 +++++++++++++++++++++---------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
 
As long as I know, the coding style of Linux kernel[1] does not forbidden
brief expression of 'unsigned int' (= just 'unsigned'). Furthermore,
in C language specification, 'unsigned' and 'unsigned int' are the
same[2]. I have no functional change over the patch.

If the intension of patch is in the point of human readability, please
note it in the commit comment. It is the most important for the kind of
change.

I'm waiting for your next post.

[1] Linux kernel coding style
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
[2] See '6.7.2 Type specifiers' in ISO/IEC 9899:1999, so called 'C99'.


Regards

Takashi Sakamoto