Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 4 Oct 2023 07:13:00 +0200
From:   Louis Peens <louis.peens@corigine.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Simon Horman <horms@kernel.org>,
        Simon Horman <simon.horman@corigine.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, oss-drivers@corigine.com,
        netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] nfp: Annotate struct nfp_reprs with __counted_by
Message-ID: <ZRz0XNOJaFUDJ8yN@LouisNoVo>
References: <20231003231843.work.811-kees@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231003231843.work.811-kees@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bfrIEYcD6jtZfd+YAhJ3m9svti2cklTBVsIxGBPuVsgvb7JeN8MUd6dqVGdL?=
 =?us-ascii?Q?M2iARxMI1pSx3YJg9r32cAYKB1MpRv4q7jfvWETQ9nl5whbRFUQwXEJE7oiQ?=
 =?us-ascii?Q?rXEM2FGLMHc1x2QVMH5UyCQFwIUtrEgzs+cf7iJIjF0mOWJDcJUAB8GvL6c1?=
 =?us-ascii?Q?ZMdzDfeQ6Xix8ZDQbSl/AWSJhYGZ4rZhdcGU0YalH9WiHNMMYxrjv/c4XhBe?=
 =?us-ascii?Q?gw8JK8ep11F19TRb8zsluPekcAZC/JpBSPO82s4gDejGpanf1OPwgK1QUXYq?=
 =?us-ascii?Q?qBPS0H2niemcNmeIBmcYMplTkcsH1igod8db+v4zoPIyir4a3lE6cJ8NXXET?=
 =?us-ascii?Q?kQYCiWty8hWw/QbkDvCilgPY1FSCb4wTI7w1yhv9FEUax+LPBp7HoiYvYvBU?=
 =?us-ascii?Q?nePDUwFhTVtpuK70g096s2JPJZw+pkr0vmVtrDPceuQ56n7wUPbAUgUvbn7F?=
 =?us-ascii?Q?DltC4nKavkifgcLXCzzjvKEfE1xts/KebEBv2DN8tGxxlW/gfTTXYoUoyTw4?=
 =?us-ascii?Q?SosLHMpIDicIywPGXy6hXcZEvcX6gwWu6uJHCSoYLdOfLg8YIVpU8Xxazlfy?=
 =?us-ascii?Q?vECejO2ZURO/EglWqfNav9vuuVwvEhY4Ost8UgnDFTjAhr1XyqrAULz/6oFZ?=
 =?us-ascii?Q?iFa4g4e5zOWU9Lk9E2HUkt5B11WVtmLYeORaK+cWGQRpQAi93lqoMHni7EID?=
 =?us-ascii?Q?zP3NE73Fbn7+1DheMH4MB0RWALvNGaKKMUTRarH5XlOuJpydBZOUNxpf9pTS?=
 =?us-ascii?Q?zqPN2xrpMghGQnv4/JN+DG895Jl27qsy9vL05cR8c2Z1ej07FcL9XWlxyrzs?=
 =?us-ascii?Q?iLvUyWss9ko2xkKQADlrIwoC6w2ZFsjrmVMExYySnI7oDK4BCDVpaJGk6nxV?=
 =?us-ascii?Q?xEKST4+Df+7YnV05M31+DzeiQTYUXNyBHaQbsIBggmjB2+rWBZlf+WXihz6H?=
 =?us-ascii?Q?OXJZTW/etLAgHS3idfUcjav2Apfqm8C+LoT1nbS2QIHjVUeGhgG8ufTycQoA?=
 =?us-ascii?Q?t5tTG2UtzZGS173FbWZxnZWQcTVAiBEzxnu4F7YbARdqf+vAWDxr1TT5p2zU?=
 =?us-ascii?Q?+WK7Njf6rZOjgUau8BlG3p8Xq4NKwuUZimPJ2Z19KOr6Cv4EAqfDr/HG99tr?=
 =?us-ascii?Q?GsWyuWujoSYgEPHI+y8yA4GwlDkjoRwpG6x91tWqLcigd486poLpFAK6F7Jl?=
 =?us-ascii?Q?BRhbVHOGZ8hYlengByoGdmz7w9hp8Tj4haTEzdqF9imIEO1Yo9bDC3+yXN6S?=
 =?us-ascii?Q?4DUGZMna7hsR3+V+QNHwabaN+765VlXQpg8THYXzhrurW8R1Vlx2jVFnVkMg?=
 =?us-ascii?Q?0R1nO7VpJWmflMykdz5eEjgA7RRJGLaVrakPbxLScJEaTcwqPnIVyByPxQOy?=
 =?us-ascii?Q?nhmDiZNMczkv9yfKU23/Rf9ODm4ghGmqYpKU7xCYaAyWMTbENucBcltDgQNF?=
 =?us-ascii?Q?rti6sKBi4D7ITq0MByGjUYwo8LwmjCZsUB5TTdfiWCG8F2BypVo6PIf16YWw?=
 =?us-ascii?Q?PdRDrHQEWc0yn06vgqn0YgJavMzT2MOHSpWa+gtTnsvjNCkjlNizbVRpTB5C?=
 =?us-ascii?Q?9fe2h69kaPcuqNJyX9uzGZVJO9REbhILPlIQfb0b1cDV27ZtbG20tGDkLFME?=
 =?us-ascii?Q?HA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1048419e-4a2a-4fd6-f913-08dbc4989f3c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4249.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 05:13:19.2546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sNYsdON2dCSmfAf6mTh1suoSslhFiETM0EtLlGXH4ZRThkcuGef2PeHG2JsiezOsJmEbZM0hDoVut6lZC0FRJnv57ErnfJUWZJDLoSI2t/I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3721
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 22:13:29 -0700 (PDT)

On Tue, Oct 03, 2023 at 04:18:43PM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct nfp_reprs.
> 
> Cc: Simon Horman <simon.horman@corigine.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: oss-drivers@corigine.com
> Cc: netdev@vger.kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook@chromium.org>
Thanks Kees

Acked-by: Louis Peens <louis.peens@corigine.com>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
> index 48a74accbbd3..77bf4198dbde 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.h
> @@ -18,7 +18,7 @@ struct nfp_port;
>   */
>  struct nfp_reprs {
>  	unsigned int num_reprs;
> -	struct net_device __rcu *reprs[];
> +	struct net_device __rcu *reprs[] __counted_by(num_reprs);
>  };
>  
>  /**
> -- 
> 2.34.1
>