Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Wed, 4 Oct 2023 07:15:58 +0200
From:   Louis Peens <louis.peens@corigine.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Simon Horman <horms@kernel.org>,
        Simon Horman <simon.horman@corigine.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Yinjun Zhang <yinjun.zhang@corigine.com>,
        Leon Romanovsky <leon@kernel.org>,
        Yu Xiao <yu.xiao@corigine.com>,
        Sixiang Chen <sixiang.chen@corigine.com>,
        oss-drivers@corigine.com, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] nfp: nsp: Annotate struct nfp_eth_table with __counted_by
Message-ID: <ZRz1DnlUCmgJdS1Z@LouisNoVo>
References: <20231003231850.work.335-kees@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231003231850.work.335-kees@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1IKIZpHXVaXuiIAc4nQPxep+gpxYyEe1sMqMAhW0lV0dHMegxa7xRas7naRn?=
 =?us-ascii?Q?HxT7Tvp0kIoz7ZgebosqmTNcrxGCs3gnzXiGSwCzgvkurGFWVXTmMgxkPwEN?=
 =?us-ascii?Q?B8UgY9t4uUOsVBAuHd/44P7+KmAeRvESsmuXo8liSSs9ZcMgduLF/fjIapCf?=
 =?us-ascii?Q?r5ORi7u/rwQbxV0ypfvj57FtnQZE3QYM3hxcWp5cDjFa/Pq6ebowScTOv2W6?=
 =?us-ascii?Q?vKYPyBplAq8aipg/KTBqDf+VXPXnirGnuxJn68Nnp2IrJMhqZvAUqkSuYU5W?=
 =?us-ascii?Q?Fx45qp/zORiWK1FNtqRuyvwiND0PAtPt+/IMtxjYOr4SSonf9YEfQk+tOExX?=
 =?us-ascii?Q?Oa6zd2NIPozKhK8pY77frhnReKqGUM6359jEiMMU4FV6xBtOxdd8jpGRzHCh?=
 =?us-ascii?Q?TwM+jlu0XwgK6crK1Vlh8FOe0ssCSEyeaMpnxJy4XSIB2U7IfnyvTC+a1kRa?=
 =?us-ascii?Q?R+H65BPL4vmPGSzm6octKX6ESk+8GouDUqq+HuIZz6zyDi80BMwlQKsUwqqJ?=
 =?us-ascii?Q?4hbh3reZA2hyx8+z3Q5DeMOAlNpmK3VzKpMpGKYRHKAeQThbJTAQcffZmiAm?=
 =?us-ascii?Q?lDUSL3vtAKX80P+P3vqov3J5AUfTq+8nDqQvK9tuljoNVWm2m9DUvv1ygio4?=
 =?us-ascii?Q?mJxzCtBlO99gpeYR4Ul9DpfS3KHK+UQaO7rXMFzF2Um8by9dNsR/Z5R0EQlf?=
 =?us-ascii?Q?d7psDfmrK2nEWYstKFM5QDdkhqRoNVrGY2w52tF34NeQJZ8uYbqMT3qXklv1?=
 =?us-ascii?Q?PsduApr7yE5bx6hwgHK0I4tSVbM4FOzydXX36hiUm7GodMCWvlIqH84QM4fi?=
 =?us-ascii?Q?IaL7N2qwVnuti95viBS5k0xHcLILvOmxa3mW4JCdpM6olFW2srLPr2l2H6DA?=
 =?us-ascii?Q?W2SkGh9E2OP6pkvRStJgMRqzMCRSSHmCTFcYk6yYXkJQPhDZ1j+ngP0iJb8t?=
 =?us-ascii?Q?SaCamIyhFPj11q4q8cFNQggYgkEOhQGJOY6pjp9yQ3YW0qVpb53OOZLuh8UV?=
 =?us-ascii?Q?bUF1M/1r6McmZw1s0z4B56liHpUlLEvP6gljUu/wo1mPeCn9zTZNxnRB3N9v?=
 =?us-ascii?Q?ekU7OVM2RIEoZUyp1cjLkypV5hV8vDan3BjGAiJ8p3+wtRcNmDXy0K4rAxGg?=
 =?us-ascii?Q?tEp2tA7jJA1m1rAfTzTGN0ifm0dg0N7ZZSRC2EWEniLGO+R85iuq1y8CH2ez?=
 =?us-ascii?Q?TEF8pRoQ55j8Cw8VNKewvICPIcUTDxSGYOXbs9+mBQkQoPdmd0K0XT9yb8xd?=
 =?us-ascii?Q?f0tvS10HE6wW3TkaCoEVqON9F3ZhUQ0NO5XCRrTGUei/xQAgArOD6y+61pu+?=
 =?us-ascii?Q?eyf99lGk50Whndtb7QDhoZ0+v4G3NPL4rRDGogS1StyX9v+etX7H2tE+yfq1?=
 =?us-ascii?Q?kAT2A2/I6snZ1OQWHF2ngu4XLs7WhR29Iu/PzPmapF0MAQIH0So5GJ3vvPkW?=
 =?us-ascii?Q?RD75rmd0x5ghZnr5ZFbrjQnh0NWivE3mEcFJWXZZ4htEaqPT4+XOXxHGGab2?=
 =?us-ascii?Q?4+QnkU2Pi3idQ5RCmaeh62BxDHp/9aPr+yojO00y3YswHzv/CmI5BoPl/a8X?=
 =?us-ascii?Q?w03nt4DGtg5dYY14hls8seQujclidKqFFRhiEkSub1Iieb7dyJLm8E3T4IBG?=
 =?us-ascii?Q?3Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11640dc4-2504-4e5b-955c-08dbc4990983
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4249.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 05:16:17.3703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 07djJDmyD4HXjdpolIAuMw9iHv0/cO9KNRDFK0Rj2Riv4Gqvw347ZoSGPw+kJzvt+EBhgiYVE/X6jTh4c6yi3kVAyN2gqy8ush7uWjY++n4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3721
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 22:16:34 -0700 (PDT)

On Tue, Oct 03, 2023 at 04:18:51PM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct nfp_eth_table.
> 
> Cc: Simon Horman <simon.horman@corigine.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Yinjun Zhang <yinjun.zhang@corigine.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Yu Xiao <yu.xiao@corigine.com>
> Cc: Sixiang Chen <sixiang.chen@corigine.com>
> Cc: oss-drivers@corigine.com
> Cc: netdev@vger.kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook@chromium.org>
Likewise here, thanks for updating

Acked-by: Louis Peens <louis.peens@corigine.com>
> ---
>  drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> index 6e044ac04917..00264af13b49 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> @@ -241,7 +241,7 @@ struct nfp_eth_table {
>  
>  		u64 link_modes_supp[2];
>  		u64 link_modes_ad[2];
> -	} ports[];
> +	} ports[] __counted_by(count);
>  };
>  
>  struct nfp_eth_table *nfp_eth_read_ports(struct nfp_cpp *cpp);
> -- 
> 2.34.1
>