Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2423442rdb; Wed, 4 Oct 2023 00:01:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyPBhVlWPAV53CLCgvAa0bC2mdUwaHG8OddfzBjT+10kQO0bEuwFiwkV0gWnI5+8CYDWZN X-Received: by 2002:a05:6358:1ca:b0:145:6433:8224 with SMTP id e10-20020a05635801ca00b0014564338224mr1550276rwa.18.1696402892380; Wed, 04 Oct 2023 00:01:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696402892; cv=none; d=google.com; s=arc-20160816; b=fnH753VBwRvI7CtZ4lHsT7ULhfmInteX0WCq1B0hvi269CwgbRif2I5QBREgy3rbCH VfwBUC8tFeWjkBCWK1jpnzQq4A9gLEk4blBIt6c5LDda8tPRnYDSfi9vVYUsBcpUyj7u twsxgbC9mxvdp7Qp3+a5HWl+/KhfaWD0rH71ow+c5bwuzN31rmUWyKP5K0XICDWok47d 9z98ULwLN4aoB5+bwikVmtz1ULvC6xxPdnUQLtJM15+afnskWpxQsAZJ66J5tmLxNrK/ 0Cd18z2i3XenzTJZV16R/o8KP+DfnqLeglNDBkvrojYo0zpLiauAo6SOH2539p4wC1yu y9fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bsHdMgmkYQMK2TFiy3Hx4BW+BGLq8oQTxKGgK6wIGjE=; fh=vsd6sStqdbIZ6mvF6cIzA7e3R1ObbkJ6hyiZgLpl1H0=; b=l5Nj8MQh7+n1mpysVojqZu/WEqzhmeLGPxRAENthIa5OK3ceBVJzGkriUHFIr5/Sye UWgS58eOZFIqWgUdatatxOqnrsK2D7zynNzyGOWZz6pM7VaQw/xpfNZd4WjV5GE3ryft MnY2nqddibpIkIAjKmzETrk+EFrkBbRhFytszeGBFQnrqG8FDceq4nzkgniCG/ohxe1f E9AzsPSOnbFhil+DBUd/EaiRcOMZ9SuqOPyXswp2UtEUeU0ld6/3ZonQXiVC5tOj9rEg mzU17Kq8fzQCyMXbi8PLpTSihTWFwHKR25UYoDVXtIW5LeNHsEE8YtrUvwQAcppqcEX+ YFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b="YNnDMW/s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id mh11-20020a17090b4acb00b002766bd6d3f3si1016371pjb.10.2023.10.04.00.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 00:01:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b="YNnDMW/s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 89B0881CE115; Wed, 4 Oct 2023 00:01:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241468AbjJDHBX (ORCPT + 99 others); Wed, 4 Oct 2023 03:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232647AbjJDHBW (ORCPT ); Wed, 4 Oct 2023 03:01:22 -0400 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6240AB for ; Wed, 4 Oct 2023 00:01:18 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 051C840E01AE; Wed, 4 Oct 2023 07:01:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RIDc3lHE68r0; Wed, 4 Oct 2023 07:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1696402874; bh=bsHdMgmkYQMK2TFiy3Hx4BW+BGLq8oQTxKGgK6wIGjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YNnDMW/syvY4FQeiBdoAYjYaoTBSzrb6Qeveo3rQF+rMz3YPLtLI3+9IjoeQFVqjK l4H/MUltLUruTaYYwM9ysD+JgX++w/T01987eavgSDPuRmnQ4p4z6AkGfIHakU+wvP XXd5qZQ1QeK92vcDlItj0EvAhsWu4C0c6GF+Kz1OOut/B2mejimGUriL45JZmy1mpl DplQZu71YJygfLoym6xagZCqd6un7fOqwY1uTm0fWOoJaRUaTGXYrECjaqKsSSUK2T wkD72NGzG/WsSL5ZKCjprg0sNxgtLiGyHVdMgTDKFmEniOb22XqxUTojcu3cjG3XvT x8hLcbbdKUQiDM0cVW1RqYfyJa2WDilSp/NBkDLp9RsyxOUR1qzq69mDe9CwgVpfrZ Sfo7lmqA0xT5ui7JSCmYY+hrJmj6WAgVDJkW6LJ8+16ZLeRNkTZnGI5s7dSVjyHRjU L4bfOGDpmtGm9FoAfg0L2my9UiuhNlB8jjXTFEDqAsnsYTvdnSfFEz2dc8Jhzr5O4M /Oj+uqTY2efr0zXcdOUevgkNxnfkHXiW1MjAgs0y7qWV/sl7cptiIrbmRqbKgE5fPC xm+BR5LT5TO/U38m2z94eBEfbs4U04ZJG3Dqlga2VfoV5XcUpmp1i99jgUPzHFD0JW c0dpHugDDiajnhCgyo/VAUIE= Received: from zn.tnic (pd953036a.dip0.t-ipconnect.de [217.83.3.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7E6F840E0176; Wed, 4 Oct 2023 07:01:06 +0000 (UTC) Date: Wed, 4 Oct 2023 09:01:00 +0200 From: Borislav Petkov To: "Nikunj A. Dadhania" Cc: thomas.lendacky@amd.com, x86@kernel.org, dionnaglaze@google.com, pgonda@google.com, seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/14] Add Secure TSC support for SNP guests Message-ID: <20231004070100.GAZR0NrFSIDKPSQIjA@fat_crate.local> References: <20230814055222.1056404-1-nikunj@amd.com> <9a6af215-e696-5091-69fa-1cbebe772471@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9a6af215-e696-5091-69fa-1cbebe772471@amd.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 00:01:29 -0700 (PDT) On Wed, Oct 04, 2023 at 11:05:14AM +0530, Nikunj A. Dadhania wrote: > On 8/28/2023 9:17 AM, Nikunj A. Dadhania wrote: > > On 8/14/2023 11:22 AM, Nikunj A Dadhania wrote: > >> Secure TSC allows guests to securely use RDTSC/RDTSCP instructions as the > >> parameters being used cannot be changed by hypervisor once the guest is > >> launched. More details in the AMD64 APM Vol 2, Section "Secure TSC". > >> > ... > >> > >> Changelog: > >> ---------- > >> v4: > >> * Drop handle_guest_request() and handle_guest_request_ext() > >> * Drop NULL check for key > >> * Corrected commit subject > >> * Added Reviewed-by from Tom > > > > A gentle reminder. > > > Ping ? Pong. How about you find other SEV patches on LKML which are waiting for review and review them, while waiting for yours? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette