Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2435445rdb; Wed, 4 Oct 2023 00:31:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFm+EL0zgo91KlBorOvxwzaYYoZnNnTf1Zcahj4szpIDWpwlLgayE0XomRXoQT/rOkJynS/ X-Received: by 2002:a17:903:2282:b0:1c5:a49e:7aa with SMTP id b2-20020a170903228200b001c5a49e07aamr2266492plh.27.1696404685343; Wed, 04 Oct 2023 00:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696404685; cv=none; d=google.com; s=arc-20160816; b=pIap3exduw2gBb3cweGsHhxeHsni1qtKGYmoERy24Nszm1BBrg4qV3DJML7JH8Zw+3 hPgl7lg1gzaDkQrScIOAVOZLt6pbvGNeLPo3UUEpKqjByp55/uACcwNgMwlutnYsc56e T8B/0huzsE3/M/QY2W9tmusQIl+5k6Pi/ZUPdVM4DDN79QCeHdyPJYoEFYnXIMNAhnFH CswBdyQTb8gcPgRGevBnkTOhk92Ts2wGjUH3ikLzOqT1BzNl2A2E9h9Psa4sCIgPUxyU yLMv3qTYX/COrEch4+GlmYISkkIDYF9ZxFpzsHUYh3OUUIvztdzmxghJ+ndbLuaTIeFn GBtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=hrloh7mgnpoZ6lCmtXs4CFbCkFbJiXWP0omxMPn2I+w=; fh=vTdgYNTHYN9PGIAsbF6JzSvnycsnk3Ht7eDXk4LrLiI=; b=rpiJrRY+o71sqpxcs1oHR5uWVxgBoS6vwqbTlYZOJc8IUssZvjPXgMguZ75BYeBeMg AaVRJ9mllD0PhXHuV7DwGy+/6MvpHqQdHzRb97wayP5mX0sxu2D7nYXsCFI0Vnz4rhrz 7Wfv64WBte8dkwxE30GbeONqT76Hj4/yZJnynYdfREP6as/RPtWiJNgU+pL11yV5iwEH G/RDiMMZctf99lU7xKHJxZfgqXZGmCwgBqN+9Hb6fckcy4gmXMPdhw4HU1llVkczOIzJ iPOte69PDRPeIrqZsAv//6ZA6bm+MhmQ7Qh7zuesn5kMzH5Z9WMxV5fvnXh9X6PUNEnD 86/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qLrfTSxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id r21-20020a170902e3d500b001c3c94d212fsi3103227ple.97.2023.10.04.00.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 00:31:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qLrfTSxx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E048E80981A2; Wed, 4 Oct 2023 00:30:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241525AbjJDHa3 (ORCPT + 99 others); Wed, 4 Oct 2023 03:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241479AbjJDHa1 (ORCPT ); Wed, 4 Oct 2023 03:30:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E556AA7; Wed, 4 Oct 2023 00:30:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id 8D900C433C8; Wed, 4 Oct 2023 07:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696404624; bh=p4yLinEjIJBrFuw8sXLaLQnAZFkhWiUPbGiv8DnPTD0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qLrfTSxxcorg5t4dgwYQ9KAYYXZ1iL19zW+mWGa9Y6BVy2W0gsBct/LFcyWaD/XuC SbTdMVqE9Gcs8b8dbJ5TCuf4bBDkhmNZ8l6ShyFnf/9utRnuo/GPUdzJoVTTT7QsNg p60f6U/92iIBJeL3iVcB/iUjjFYfi5gs5QlSd/PLiBiKPQ4F4nF+GHGk6FnGfFDSJv +/6bFrGSieIFs8rlp+hFIcGCQAjD4YItalzzDLPaFfS1XR1Uzhf3eQerpdRRjv71hY 3E6/hp2BgX59AL0LJ7uoXGPEd4Ovw3M9gIwXR1lC8gqpaUf4B8ECh5BeDFDOhi8/i+ UJCtjNVUiGbEQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 6CCFCC595D0; Wed, 4 Oct 2023 07:30:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] vringh: don't use vringh_kiov_advance() in vringh_iov_xfer() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169640462443.26245.17654721515803300599.git-patchwork-notify@kernel.org> Date: Wed, 04 Oct 2023 07:30:24 +0000 References: <20230925103057.104541-1-sgarzare@redhat.com> In-Reply-To: <20230925103057.104541-1-sgarzare@redhat.com> To: Stefano Garzarella Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 00:30:37 -0700 (PDT) Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Mon, 25 Sep 2023 12:30:57 +0200 you wrote: > In the while loop of vringh_iov_xfer(), `partlen` could be 0 if one of > the `iov` has 0 lenght. > In this case, we should skip the iov and go to the next one. > But calling vringh_kiov_advance() with 0 lenght does not cause the > advancement, since it returns immediately if asked to advance by 0 bytes. > > Let's restore the code that was there before commit b8c06ad4d67d > ("vringh: implement vringh_kiov_advance()"), avoiding using > vringh_kiov_advance(). > > [...] Here is the summary with links: - vringh: don't use vringh_kiov_advance() in vringh_iov_xfer() https://git.kernel.org/netdev/net/c/7aed44babc7f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html