Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <a714593b-32a3-d552-e435-76e4a5dbb951@intel.com>
Date:   Wed, 4 Oct 2023 10:50:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] idpf: fix building without IPv4
Content-Language: en-US
To:     Tony Nguyen <anthony.l.nguyen@intel.com>
CC:     Arnd Bergmann <arnd@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alan Brady <alan.brady@intel.com>,
        Sridhar Samudrala <sridhar.samudrala@intel.com>,
        Willem de Bruijn <willemb@google.com>,
        Phani Burra <phani.r.burra@intel.com>,
        Joshua Hay <joshua.a.hay@intel.com>,
        Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
        Madhu Chittim <madhu.chittim@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230925155858.651425-1-arnd@kernel.org>
 <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHdkaG1SK0I4N3p5RGZTenhVQ2pHY3dvSGZiYTBVZlJ4cVJHQzdsL3M0RlhC?=
 =?utf-8?B?bGtDbHhybnVGOVVWenQra2lrSXJuM1prSWRDOEhkOVlnTDVPbWhxTWx2ckYx?=
 =?utf-8?B?QXFtQUR4WGVKMW90VzJ0VVBvVXZnSkI4VzhQNUw5bFRBVUtaOUl5dklrY29X?=
 =?utf-8?B?eWc3K0xSMzhQVlVqWGpQMzVkaXVwWGllRUtSYVpHT3BseFJ5UjNjakR1b2FJ?=
 =?utf-8?B?YXpvdWw5ZDMwTUFROUVzWVRua2g2QXRFMXY3ZUswdVJ3dVUvQjJ3NFU3clp5?=
 =?utf-8?B?TnFOWXVKZEI0SGh6djU2TmtLMGZYL1E4Ly92Nm12dmx5TG94NGxDcGZhVGty?=
 =?utf-8?B?N0cxbXUwdC8xQ3hycEx3eHRyQWcvNktKaHE3eUVJcVR0T1Exb2NhQlRLWExq?=
 =?utf-8?B?bFp3OVBwNGdaL2FoRnFBOVI2YVRWdGdxNTlRQmtoMld4Y1FXWWtySWVXQWVC?=
 =?utf-8?B?cHVpSEdZeDluOVEySXJ2L1VrbmJtU1lJNi9QZEViVWIxK3FnUU9zTWFReE53?=
 =?utf-8?B?YzF5SlcrQzJ5KzdyWmRkS3crU2JFNjVKUmVKU0hmN3MzS0wrTVZzWVpoUUF3?=
 =?utf-8?B?cFZtMFRwODZBTnNBS1NrR3U3UUZ0a25IVExqbDh5TXN4ZkUxOTFFd3BJL2lx?=
 =?utf-8?B?c1BSWllXK3JaSW5Qc2tZdkZxcW9kZDFPTkZiTmNCVUNwV2svdnR5eWs2bmU3?=
 =?utf-8?B?NHVDR1BubWRRQnUwdnpKNlNNVXZiRFk2QWNtdENEN2dxUDQ3SDAvUHJlMDg3?=
 =?utf-8?B?V3hNZ1lDSGZlK1lvK2hJUGNuV3VwM0tBWHB1d2thUW80Y0JiUXRwM3pIQVlw?=
 =?utf-8?B?bUcxSVBjVjJSU2F6MG5Pa1ExQ2RacVV1Uk1ZNnFuNXVteGFMenlmcmt6Wmhq?=
 =?utf-8?B?NlNWS0VQQThLem02a1ZkNzA3L1FoUkhYdXp3SCtyODhxdFZYZlpyc1doVVhE?=
 =?utf-8?B?OU9JMzBSYWtCZ05LTFpvRGlCWFNndlZ1b1RIb3Bwa2dxNS9uR2FPM1BMYmhZ?=
 =?utf-8?B?OFFGa1VmdmJnM3Z0dCtHUHpBVE9rSjlBNjRmSTlkT3ZBTGxsRFBjd2FKS2U4?=
 =?utf-8?B?Mks0a1dPTHZaMFRIeFRSUzZLTnh4NHpmU0xlRnl6aHhmYzdYczVtSlFjK0Z3?=
 =?utf-8?B?eWdYUjhrNDJTQTh4eWlVZEI0Q1RucCt5OHdJNkR6ZExGT1I4MGRJa1NGVjBS?=
 =?utf-8?B?M2ZTdXNDbGtzb1RtVXUzY20wU1RzV3BYRk5GRUFMOEFacHdVdU5kcVRtY2JJ?=
 =?utf-8?B?dUR4dFBGOG95by8xcE5zRlp0b0R5bjZZZGV2aVhvVUE1dkY0a0pYMzAxVHZz?=
 =?utf-8?B?Y3BvSnkyZWF4V1d5bVdDbCtMSGdOYmRFVGlxWStxckVyYUtJSGxPSUUxMzFu?=
 =?utf-8?B?d0VseHloM0k5bDhpNDNRaGpSOGxxckgxY2xCSXlzNU9tMkIwcWdhMlFSRm41?=
 =?utf-8?B?dlM1Z3J0Zk8vb21DcUVTT1BoYmYxc2tJc1EwQ3RDbWwvb2JZSTJTbUtORE1u?=
 =?utf-8?B?ZnRqekMrMWEyREpqQmVxMXVTaG5MUTR0RGFDYXU1eVVGeWVURDkxamlyYkZZ?=
 =?utf-8?B?Y2VEM3VWMVVXNndKOFpyUTlzVzgwRGRZVU9DOUthbmN6RTdrWkZHWGsxQ3Rt?=
 =?utf-8?B?UUpFRmVQNTdRTk1TYjFzcng0RU5PeVMxL0JnNWpFYWdrVG9veHNOV3c2Y1F6?=
 =?utf-8?B?d1VpeUpaSEZxTG9rZ0srZDQ1Ym10aHA5Wk1mdUszdU5jbDRjc0dvQVBWaC93?=
 =?utf-8?B?bnNMWk02UWM5M0ZoOE0yM2ZkMWlNQ0k3Y3VPS1VTU0RrNUFjK0lLLzI2ejRt?=
 =?utf-8?B?RWVCSWhkNzl1MXdxbU9tZGlIaDFKTTZGRTJUR2NPVVlsUzgrcGwrVSttcDJQ?=
 =?utf-8?B?ZWR4eGE5dXBRd05BQ3FyZU9ma2VzNGJudHB3RStaWFhiUzhIZHB1dVpaK1RU?=
 =?utf-8?B?VkxxVFk4RVlVUzlzYk5ST2FsRHdYeUhVTXVxRDR3NEhPRlhKL1liUlM1dXBk?=
 =?utf-8?B?WU82RStOR2xueXhFWC9rSzJsWXJLWGc4NjJlbzM0cHExNFd1MjgvVUR2c0V4?=
 =?utf-8?B?aTZLaUVtbm03QzV5dUtHbUpVZUVCeFN4SDVwVU56WEZuVWhqWGVYMllGanRj?=
 =?utf-8?B?VHRyYkUyRHFUUGp0QTlxL2NubzFlcWpXelJyYlA0TGRoMnNaUkJwVXZLTGdo?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f9458dd-00e9-4260-abbf-08dbc4b72f9c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 08:52:06.7025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZQDZQA8qTGJcjMPYqoZXfkOEmGrRG78/ALjFfnQozoMlMpe3/TGw4jyP7GT/xn84PL6nhJSzZwiP7frOHxndKyZR9RaAyo/sEY1P5BUgT0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8479
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 01:52:49 -0700 (PDT)

From: Tony Nguyen <anthony.l.nguyen@intel.com>
Date: Mon, 25 Sep 2023 10:05:03 -0700

> 
> On 9/25/2023 8:58 AM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly added offload code fails to link when IPv4 networking is
>> disabled:
>>
>> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in
>> function `idpf_vport_splitq_napi_poll':
>> idpf_txrx.c:(.text+0x7a20): undefined reference to `tcp_gro_complete'
>>
>> Add complile-time checks for both CONFIG_INET (ipv4) and CONFIG_IPV6
>> in order to drop the corresponding code when the features are
>> unavailable.
>> This should also help produce slightly better output for IPv4-only
>> kernel builds, if anyone still uses those.
> 
> Hi Arnd,
> 
> Also, a pending patch for this [1], however, this does look a bit more

I agree Arnd's version is more efficient, the other question is why my
patch has been hanging in your tree for 2 weeks, although I asked to
take it directly to fix automated builds ASAP xD

> efficient. Adding Olek as he's author on the other patch.
> 
> netdev maintainers,
> 
> If this is the version that does get picked up, did you want to take it
> directly to close out the compile issues?

[...]

Thanks,
Olek