Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <06c2a26e-fa22-382c-0572-eab0d0124fb2@bytedance.com>
Date:   Wed, 4 Oct 2023 17:09:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
From:   Peng Zhang <zhangpeng.00@bytedance.com>
Subject: Re: [PATCH v3 5/9] maple_tree: Update the documentation of maple tree
To:     "Liam R. Howlett" <Liam.Howlett@Oracle.com>
Cc:     Peng Zhang <zhangpeng.00@bytedance.com>, corbet@lwn.net,
        akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org,
        surenb@google.com, michael.christie@oracle.com, mjguzik@gmail.com,
        mathieu.desnoyers@efficios.com, npiggin@gmail.com,
        peterz@infradead.org, oliver.sang@intel.com,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20230925035617.84767-1-zhangpeng.00@bytedance.com>
 <20230925035617.84767-6-zhangpeng.00@bytedance.com>
 <20231003184625.lqnfmgc35o7pgeff@revolver>
In-Reply-To: <20231003184625.lqnfmgc35o7pgeff@revolver>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/10/4 02:46, Liam R. Howlett 写道:
> * Peng Zhang <zhangpeng.00@bytedance.com> [230924 23:58]:
>> Introduce the new interface mtree_dup() in the documentation.
>>
>> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
>> ---
>>   Documentation/core-api/maple_tree.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/core-api/maple_tree.rst b/Documentation/core-api/maple_tree.rst
>> index 45defcf15da7..3d8a1edf6d04 100644
>> --- a/Documentation/core-api/maple_tree.rst
>> +++ b/Documentation/core-api/maple_tree.rst
>> @@ -81,6 +81,9 @@ section.
>>   Sometimes it is necessary to ensure the next call to store to a maple tree does
>>   not allocate memory, please see :ref:`maple-tree-advanced-api` for this use case.
>>   
>> +You can use mtree_dup() to duplicate an identical tree. It is a more efficient
> 
> "You can use mtree_dup() to create an identical tree."  duplicate an
> identical tree seems redundant.
Okay, I will modify this sentence. Thank you.
> 
>> +way than inserting all elements one by one into a new tree.
>> +
>>   Finally, you can remove all entries from a maple tree by calling
>>   mtree_destroy().  If the maple tree entries are pointers, you may wish to free
>>   the entries first.
>> @@ -112,6 +115,7 @@ Takes ma_lock internally:
>>    * mtree_insert()
>>    * mtree_insert_range()
>>    * mtree_erase()
>> + * mtree_dup()
>>    * mtree_destroy()
>>    * mt_set_in_rcu()
>>    * mt_clear_in_rcu()
>> -- 
>> 2.20.1
>>
>