Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <5d31facd-8942-d159-a1f1-cd7cae6c09a5@quicinc.com>
Date:   Wed, 4 Oct 2023 14:53:45 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH V13 3/4] dt-bindings: mfd: qcom,tcsr: Add simple-mfd
 support for IPQ6018
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <lee@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <thierry.reding@gmail.com>, <ndesaulniers@google.com>,
        <trix@redhat.com>, <baruch@tkos.co.il>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
References: <20231004090449.256229-1-quic_devipriy@quicinc.com>
 <20231004090449.256229-4-quic_devipriy@quicinc.com>
 <60da3633-61f6-49c1-b656-2804c35d3e82@linaro.org>
From:   Devi Priya <quic_devipriy@quicinc.com>
In-Reply-To: <60da3633-61f6-49c1-b656-2804c35d3e82@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/4/2023 2:50 PM, Krzysztof Kozlowski wrote:
> On 04/10/2023 11:04, Devi Priya wrote:
>> Update the binding to include pwm as the child node to TCSR block and
>> add simple-mfd support for IPQ6018.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>> ---
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
>>     reg:
>>       maxItems: 1
>>   
>> +  ranges: true
>> +
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 1
>> +
>> +patternProperties:
>> +  "pwm@[a-f0-9]+$":
> 
> type: object
Okay
> 
>> +    $ref: ../pwm/qcom,ipq6018-pwm.yaml
> 
> This should be full patch, so:
> $ref: /schemas/pwm/qcom.......
okay
> 
> 
>> +
>>   required:
>>     - compatible
>>     - reg
> 
> After required (but before additionalProperties), please add:
> 
> allOf:if:then: for other compatible (so use keyword "not:") which will
> disallow pwm for them. Disallowing is via:
> 
>      patternProperties:
>        "pwm@[a-f0-9]+$": false
> 
> See   Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
> around line 240. We need something similar.
Sure, will add!
> 
> 
>> @@ -57,8 +74,29 @@ required:
>>   additionalProperties: false
>>   
>>   examples:
>> +  # Example 1 - Syscon node found on MSM8960
>>     - |
>>       syscon@1a400000 {
>>           compatible = "qcom,tcsr-msm8960", "syscon";
>>           reg = <0x1a400000 0x100>;
>>       };
>> +  # Example 2 - Syscon node found on IPQ6018
>> +  - |
>> +    #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
>> +
>> +    syscon@1937000 {
>> +        compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>> +        reg = <0x01937000 0x21000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges = <0 0x1937000 0x21000>;
> 
> Please put ranges just after reg.
Sure,okay

Thanks,
Devi Priya
> 
>> +
>> +        pwm: pwm@a010 {
>> +            compatible = "qcom,ipq6018-pwm";
>> +            reg = <0xa010 0x20>;
> 
> Best regards,
> Krzysztof
>