Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2487629rdb; Wed, 4 Oct 2023 02:46:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlWfRbV698CRUucPeD3Dj9XNBc/w30TGnNG0Og3Pby3AnzfXIYaMTj2CJSepVTtuipt6JJ X-Received: by 2002:a05:6a00:1acb:b0:68f:d554:a299 with SMTP id f11-20020a056a001acb00b0068fd554a299mr2007996pfv.10.1696412806496; Wed, 04 Oct 2023 02:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696412806; cv=none; d=google.com; s=arc-20160816; b=nKz5O7iyZrCmfbub1CVWT0ebVi0++Fq7aRWkgdqRvchi6b+CvOqA350fo7TzJ0A2Sp DuAXudm1smqquhgBO1sBJyaKW4ndy3sA4N3UhiZT8EiyHcMiGrnIUxkHyfJkD2RBBNia cDnuRv06nRcUf/s+Jf1Lham9gKs0eC+EbkN2DEeZ4pQrVv2h0tnxrSTUbRCZlV+gRYTT PnuWlcGnXvUJkmp1PxhYPb+4zlFQqP6nIcqxGM4225nDbzelck4ZxlW+6OGSRfPOTmbB bOG4UBoBUVvPqbhEFkCxz0eIAt26Fq9KBPlqx2S3u/87PuuYUa6OlE/1zISr6P9YcnCJ G9Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=Sl8iYN0t1lulbY2SJQrh/y+Ci1QKo3Vf0tBZD83VA5I=; fh=UnIFRW4uhbPvNWUnIZIoY0piOCkZH2tI4eOCYyI4XYQ=; b=tbPIeoXYO2Ds9f3L/ueHzWl8FknDWuxQCKc6Dv/AR3dzUYhE7vDcLrvcsSZ2VYGg1q GLNUvIAS1uiYhp+84bI8kcr2O3TDAtBrIo62t6tBPM/yQNwLF6BXlUp5bsS2GKBACLXe 6NRy8+cC9q4qSI304oq+6aGfAvNE68hVFEXWvRkpsoyjUh6fk11QRblP70/mzF/lQt9F D2xuGab1CfOehaQSKCCX8CI9ZO0FGf9lDyTin8C6W4xO26AP/QzuUWTVcYLvlyu6rcV7 1ZDWS3c6PtHldgiBnkbH8NOT8S4A4UhN3/xDJxDPF75RUzQHt7AI0gAnXCfj2Wf74A+W ybMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HJgRF9ft; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id ch3-20020a056a00288300b006933caa6f03si887299pfb.165.2023.10.04.02.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 02:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=HJgRF9ft; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A102780B8DF9; Wed, 4 Oct 2023 02:46:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242072AbjJDJqJ (ORCPT + 99 others); Wed, 4 Oct 2023 05:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232904AbjJDJqH (ORCPT ); Wed, 4 Oct 2023 05:46:07 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A288CAF; Wed, 4 Oct 2023 02:46:01 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3947m4A7003310; Wed, 4 Oct 2023 09:45:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Sl8iYN0t1lulbY2SJQrh/y+Ci1QKo3Vf0tBZD83VA5I=; b=HJgRF9ft8COG7dIf14efTpYQT3xQFmIvJGcE7UHBMcoVViUZ9effD73PtXgEnASOSA5K 9aktT9HORYBn2FPKyCO8nSy9JbSZo+/0sArHg72RuMQOULY0zkhWpIcD5LUYiF/YbrON 0BCmWY0yHwjX8FRuStkhayHD55HaBKl8v4HrPmnZS1BztLAyl0oW883qjmpLDBPxn9By 3Kav91FS/Kb0lGhNclFWRCL9Vo7rGSR/BxBLNrucVxZ3JrcrW89REbqOgxO/wpDJSMZ1 DX4YoofQaWfgKllDxB/uH3jzJLr39MXJt7vDk5sbmQ0MeF3Nv2mlKBLqGhoNkw4fidCl Lw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3th1cy0gb1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Oct 2023 09:45:48 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3949jP1N023626 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Oct 2023 09:45:25 GMT Received: from [10.216.40.132] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Wed, 4 Oct 2023 02:45:19 -0700 Message-ID: Date: Wed, 4 Oct 2023 15:15:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH V13 4/4] arm64: dts: ipq6018: add pwm node Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , References: <20231004090449.256229-1-quic_devipriy@quicinc.com> <20231004090449.256229-5-quic_devipriy@quicinc.com> From: Devi Priya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: DZiJwyAXB4MmJvS0cIUJRL6BY088r7TT X-Proofpoint-GUID: DZiJwyAXB4MmJvS0cIUJRL6BY088r7TT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-04_01,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310040070 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 04 Oct 2023 02:46:20 -0700 (PDT) On 10/4/2023 3:13 PM, Krzysztof Kozlowski wrote: > On 04/10/2023 11:04, Devi Priya wrote: >> Describe the PWM block on IPQ6018. >> >> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add >> &pwm as child of &tcsr. >> > > ... > >> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) >> >> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> index e59b9df96c7e..429ad7cb681c 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@1905000 { >> }; >> >> tcsr: syscon@1937000 { >> - compatible = "qcom,tcsr-ipq6018", "syscon"; >> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd"; >> reg = <0x0 0x01937000 0x0 0x21000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x01937000 0x21000>; > > Please put ranges just after reg. Sure, okay > > With that: > > Reviewed-by: Krzysztof Kozlowski Thank you! Regards, Devi Priya > > Best regards, > Krzysztof >