Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] wifi: wfx: add placeholders for remain_on_channel feature
Date:   Wed, 04 Oct 2023 12:40:13 +0200
Message-ID: <16472781.hlxOUv9cDv@pc-42>
Organization: Silicon Labs
In-Reply-To: <87pm1uhejh.fsf@kernel.org>
References: <20230927163257.568496-1-jerome.pouiller@silabs.com>
 <20230927163257.568496-6-jerome.pouiller@silabs.com>
 <87pm1uhejh.fsf@kernel.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?QVMfNlql/zbthAORldPy3fS3eyy3WNyk4SpJUnIs3Kyzz/q3MMtMziIrGd?=
 =?iso-8859-1?Q?O9xS9B/z+eFw9EbyVVNmYzF+ulJRMcXAUnK+gyRgYTkdVA5Xn47tmB1k3Y?=
 =?iso-8859-1?Q?tCOn7U4Nm1K0dG8tGpu4wUURaFMnvSmFc5eGeW0dXEuJ9i2CNYH5t7wMXh?=
 =?iso-8859-1?Q?IefIjz7W1iBQZO9+e+of+A0ll87yk7xRmtpqfQpKlJ+9sVPK3WxWsfrmy/?=
 =?iso-8859-1?Q?IsFjfy8EB/1o9jO0LrtAbaIM0d5j9w+B1NYWZhEtlZJ681N7bPzGqT3QpR?=
 =?iso-8859-1?Q?TfadXi64LRted5YofChmXfay2K69wjqm5kd9ruEpWPYjZFzQ/p0INmlZtg?=
 =?iso-8859-1?Q?nptn4rE6NkR65o1FHZjxsmXNlv0829Y/oi8pxEKcumLJlicGDn4ci5Oaf2?=
 =?iso-8859-1?Q?d16oO/zyyaYZoEjA1mCt9HloVNrngi3qPPLwUtiyqV/Fi94n3qjbs5ALj4?=
 =?iso-8859-1?Q?mhl4Z8fmseOaCvTAIEibMV8qgzJVNVsAeXql08K0Vx+USMqqIA2AwTeedz?=
 =?iso-8859-1?Q?kA1W6dgAJgvYR4MmiKHRRLUT1H9Juxcersev960mJY5RwipOgS6soZVCbV?=
 =?iso-8859-1?Q?llQz8IVnKgxHzdVypHNdd1i1f6LdX1h0OeBowQWU4lOwIoU2S4saljui91?=
 =?iso-8859-1?Q?kRKX1RCTnLVCSjQnjsF8dfP4r1GWHA8MbwKl57Lmapeq0PVPkQ9e7qO2sd?=
 =?iso-8859-1?Q?uJxWlotWWj23Q0mF9egK1WJcYKRMLKgURHYSnlajGfYbW772/iOuy4HXZO?=
 =?iso-8859-1?Q?y1WrHzY64NH93u0YTHrcGh2svH5nDlSuwpSKDxCjsJGekOS6NywlhzbPYB?=
 =?iso-8859-1?Q?3dRTcxVSHUyDWbALDCv8lvlDlKAZEuUvZr8d/ASwaURGEiPVFSJIjemnGn?=
 =?iso-8859-1?Q?LnFCCXwbQGZCO5/iZUE05XaXw8uWQQW7dAjJIO07sqwrGlnCNmAt44zbSB?=
 =?iso-8859-1?Q?Y32ZG1jGG5vbKkBfU3Opi+xpWLyOOPEt5TlfWCiaJKfz0wC6tlKeNKb8Di?=
 =?iso-8859-1?Q?SgQi/gsvX9NWw5cpLuvutIRmTt3Xcw8NeQFabVnPF3SGzUN2w44KI3o3bI?=
 =?iso-8859-1?Q?6WOQEy2E8IJ+dUgWx/0FFUgYvir+T6CJ0iCqnyMUb5H3baC0NRuE++ALyU?=
 =?iso-8859-1?Q?nGKvYMIRBRJ4JdF73e9bhSAgI7dfORqk7naxYxzEpDorXaFUlWmPPtlTpG?=
 =?iso-8859-1?Q?7lhDJzmXlSPQ3ki41WrK6NwAbRNChihGqJRrYyW1t9SKHwqrhQ0RIg/+jf?=
 =?iso-8859-1?Q?/YXWNNmlMZc1K6/+CpjsXIEYAs4LRhngSLBpcrPK1dJR1UMYmk0yhAjyoe?=
 =?iso-8859-1?Q?VR7LdEFkOyYRyAm85SQtGLMCC3Ua3N0GmRI3hQUG1KGqn0ugs7DrewGVCn?=
 =?iso-8859-1?Q?Pxi81X5aqgaDeonXMQBZAHirr7v2nvE9J2PDyd6VYB8dgs9hmLsF2AO+lN?=
 =?iso-8859-1?Q?lsUFJjhdjYnYxjSJlWSfh4cfkE4gXrZK1OgGO7xC0hKOHfso6tVi/0vz6y?=
 =?iso-8859-1?Q?zdwdoCEujeKjx1DcJfJbB684W6muPYdTyJT7HAZknfzPV5gC4aUmwrfQ8C?=
 =?iso-8859-1?Q?4hmV3gdonAaPDExFoYtmW5K7VJWtiCYyuf8smm/BT+Ms62DBkAuQVXK0LA?=
 =?iso-8859-1?Q?924ti3tVqcmg+l8eDpyvOQoCzYmebUHk7nXChtLicyhmT7+1acTpUMU1sj?=
 =?iso-8859-1?Q?W/RnzZqFYuVYxm5rbEl1MD1yqC693AhV47I1n2vG?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d63158d9-cc8f-416e-6a07-08dbc4c64ccc
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 10:40:17.5318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pnBNUWYiM24gSh0Yztl9MT9sArHOCYR079ljt1jbRHsXbxu8dWfS/CoSggDgoDkkZo2gbUu9RerQBfrOmhWmNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8248
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 04 Oct 2023 03:40:43 -0700 (PDT)

On Wednesday 4 October 2023 12:23:30 CEST Kalle Valo wrote:
> J=E9r=F4me Pouiller <jerome.pouiller@silabs.com> writes:
>=20
> > First step to implement remain_on_channel.
> >
> > Signed-off-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> > ---
> >  drivers/net/wireless/silabs/wfx/main.c |  3 +++
> >  drivers/net/wireless/silabs/wfx/scan.c | 12 ++++++++++++
> >  drivers/net/wireless/silabs/wfx/scan.h |  5 +++++
> >  3 files changed, 20 insertions(+)
> >
> > diff --git a/drivers/net/wireless/silabs/wfx/main.c b/drivers/net/wirel=
ess/silabs/wfx/main.c
> > index ede822d771aaf..31f6e0d3dc089 100644
> > --- a/drivers/net/wireless/silabs/wfx/main.c
> > +++ b/drivers/net/wireless/silabs/wfx/main.c
> > @@ -151,6 +151,8 @@ static const struct ieee80211_ops wfx_ops =3D {
> >       .change_chanctx          =3D wfx_change_chanctx,
> >       .assign_vif_chanctx      =3D wfx_assign_vif_chanctx,
> >       .unassign_vif_chanctx    =3D wfx_unassign_vif_chanctx,
> > +     .remain_on_channel       =3D wfx_remain_on_channel,
> > +     .cancel_remain_on_channel =3D wfx_cancel_remain_on_channel,
> >  };
> >
> >  bool wfx_api_older_than(struct wfx_dev *wdev, int major, int minor)
> > @@ -288,6 +290,7 @@ struct wfx_dev *wfx_init_common(struct device *dev,=
 const struct wfx_platform_da
> >       hw->wiphy->features |=3D NL80211_FEATURE_AP_SCAN;
> >       hw->wiphy->flags |=3D WIPHY_FLAG_AP_PROBE_RESP_OFFLOAD;
> >       hw->wiphy->flags |=3D WIPHY_FLAG_AP_UAPSD;
> > +     hw->wiphy->max_remain_on_channel_duration =3D 5000;
> >       hw->wiphy->max_ap_assoc_sta =3D HIF_LINK_ID_MAX;
> >       hw->wiphy->max_scan_ssids =3D 2;
> >       hw->wiphy->max_scan_ie_len =3D IEEE80211_MAX_DATA_LEN;
> > diff --git a/drivers/net/wireless/silabs/wfx/scan.c b/drivers/net/wirel=
ess/silabs/wfx/scan.c
> > index 16f619ed22e00..51338fd43ae4f 100644
> > --- a/drivers/net/wireless/silabs/wfx/scan.c
> > +++ b/drivers/net/wireless/silabs/wfx/scan.c
> > @@ -145,3 +145,15 @@ void wfx_scan_complete(struct wfx_vif *wvif, int n=
b_chan_done)
> >       wvif->scan_nb_chan_done =3D nb_chan_done;
> >       complete(&wvif->scan_complete);
> >  }
> > +
> > +int wfx_remain_on_channel(struct ieee80211_hw *hw, struct ieee80211_vi=
f *vif,
> > +                       struct ieee80211_channel *chan, int duration,
> > +                       enum ieee80211_roc_type type)
> > +{
> > +     return 0;
> > +}
> > +
> > +int wfx_cancel_remain_on_channel(struct ieee80211_hw *hw, struct ieee8=
0211_vif *vif)
> > +{
> > +     return 0;
> > +}
> > diff --git a/drivers/net/wireless/silabs/wfx/scan.h b/drivers/net/wirel=
ess/silabs/wfx/scan.h
> > index 78e3b984f375c..2f8361769303e 100644
> > --- a/drivers/net/wireless/silabs/wfx/scan.h
> > +++ b/drivers/net/wireless/silabs/wfx/scan.h
> > @@ -19,4 +19,9 @@ int wfx_hw_scan(struct ieee80211_hw *hw, struct ieee8=
0211_vif *vif,
> >  void wfx_cancel_hw_scan(struct ieee80211_hw *hw, struct ieee80211_vif =
*vif);
> >  void wfx_scan_complete(struct wfx_vif *wvif, int nb_chan_done);
> >
> > +int wfx_remain_on_channel(struct ieee80211_hw *hw, struct ieee80211_vi=
f *vif,
> > +                       struct ieee80211_channel *chan, int duration,
> > +                       enum ieee80211_roc_type type);
> > +int wfx_cancel_remain_on_channel(struct ieee80211_hw *hw, struct ieee8=
0211_vif *vif);
> > +
> >  #endif
>=20
> I'm not really seeing the point of this patch. I would expect that once
> .remain_on_channel is assign the feature will work without issues, for
> example otherwise git bisect will not work correctly.
>=20
> What about folding patches 5 and 6 into one patch? And then moving that
> patch as the last to make sure that the feature is enabled on the driver
> only after it works correctly?

Ok.

I think I will have to reword a bit the commit logs but the reordering shou=
ld
not be difficult.


--=20
J=E9r=F4me Pouiller