Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org, linux-phy@lists.infradead.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net 1/3] phy: lynx-28g: cancel the CDR check work item on the remove path
Date:   Wed,  4 Oct 2023 14:17:06 +0300
Message-Id: <20231004111708.3598832-2-vladimir.oltean@nxp.com>
In-Reply-To: <20231004111708.3598832-1-vladimir.oltean@nxp.com>
References: <20231004111708.3598832-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iRWMAiaLYadNca8S5A/VqBGrsHLHCBy8h/JeF9sF/iL2sJBwcWpzSHzs03OR?=
 =?us-ascii?Q?4Rw9qix2JIkWdxGuA6kl764KyBPlr9ljS6Ojg0X7W8n0ZVVEZXmk9MNGqCrV?=
 =?us-ascii?Q?UnXy4KRO55lbkqbrSRUTWtsHdeiQuzgh5c5by32PfaJ8GmasKon69u4wSZaJ?=
 =?us-ascii?Q?cASjgYU1uEiurMwiK+uLSTsSVU5/W4kWG/l+DZuoKCZin8oKmG421PNLRLi3?=
 =?us-ascii?Q?qhDwjZy+Wt03MYn4PYPvWont17ZcFoOT7+kA/0ydMA/Z3A4pF/InIsISst0x?=
 =?us-ascii?Q?0H+32TnsQYnplJvDUJJgmXdjh62ZE+EjXzthYUz9BH8a59CmrWNKA6Rs5r/P?=
 =?us-ascii?Q?TNvpe69ZCwKX9cv3bTrB8lNG40jFNq3+dbJTmIct5UAx+w7LsA91gkq6yOJh?=
 =?us-ascii?Q?D74PocVYRahV96S7uCQjTOg/d5fOh9tv0xmGc1D45FnO6OgSEb/wRxao6Rue?=
 =?us-ascii?Q?Qx6sMeKFXmxJMqW+HjFH3X2IqZLpodOZXeoHwugZi8G2G7IS8GBi1VnRcsmX?=
 =?us-ascii?Q?v5vj/LchbvhLMUJ7WVmc1x0oq1/1tSWGADYNINi+5Ktf9TnLFEt5l5SNmkX1?=
 =?us-ascii?Q?pHEiWksem6PZeTdJmG7ZD4uy/CiM5awGl4jyw8qlS4u5vCPrPL+061yppl0d?=
 =?us-ascii?Q?ydxTulxTjK9yfD6ZPheOaO+JRvwQ1pkuq8dFmyrMG2VYwlcv17GHqoPVGmJF?=
 =?us-ascii?Q?VXP+Coim8NY+Rgc/sLLoa/meVo94Dd8hwPB2/amThcjtUJwd0rD7Ip3NujiB?=
 =?us-ascii?Q?gcTEpD3UpJKNPL1WpFyFMAddxWJQrhbfsEwMPe7fNfR8bAKxvvFFT5+rx/KS?=
 =?us-ascii?Q?2jY93ueDCbxEJ2G6kuwrJLJkcK+yfhYqQ+5NohH06SI/0coqeKtx1ovdT43Z?=
 =?us-ascii?Q?lReR4wZFvXqm5/NOxZegJkv6eVhIc3cxfjsIYGRg+HX4Q/9JBRPKnGjPlv0n?=
 =?us-ascii?Q?6fRe/0YThlPIu1LbcupaPJZBPwET7ZxtBIuUoV9OZ+sAl+VFrXRgyXru/D5Q?=
 =?us-ascii?Q?4Rj55TP3vTqvO5vRfd6CR/Apzp33SLCFomgYpLlXEtbaNNd4NjuaHmKFlF83?=
 =?us-ascii?Q?M+0RaomIhWV9Bq3RNbesucgFfGqiYTQl1RnTIZFWWxYmqFsrXOnWw3IuOwtv?=
 =?us-ascii?Q?oOpc32WJ2CuhX5OMF1MKxDt0mPjK23nVXOlf3Vdr+nM0aW0AvbWa5E5p0nTA?=
 =?us-ascii?Q?JjZ24Zx0hB82giThhLBcPx4Feepu3W7jRyaUWJgQNUf8KQ+ABGZrTvWYu4XX?=
 =?us-ascii?Q?hpNZXexsg1dQgad2EM8WblCARHtK6awQE33dKeRrVD7Zcg5BW+5c6Oj0el1Z?=
 =?us-ascii?Q?tA4+0z+QDLWXdAmfKeTZ6mhtFSIohOp0KrexpKH/r7+N8POL6LP3pL7hlD3V?=
 =?us-ascii?Q?tYekV+GImTQvOd+aa1XdAStOlgfUrj2RDwomsh8mjooe6/lEcdfdNU2oHTBQ?=
 =?us-ascii?Q?HPTbqWZXMxbsFJyJHc+5pglv7ozY/5B7VQAI84X7WRA7qF+0SyAVM4exDrm3?=
 =?us-ascii?Q?Z62I8pQun8CF1kZWFKXlEVBn9SQad3/EPkn+ZPQ576nAvsKQeFKPOLmEnvMo?=
 =?us-ascii?Q?4zkr2jcxS2Eookc5aScO/ZXiKJ3XushEeDj2LpGfF71hatj9yjGO17QfXMgH?=
 =?us-ascii?Q?5A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cbe6c47-8158-4e8e-b311-08dbc4cb7b3e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 11:17:22.9544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5qPGDykns/ZwvDUzJ/t6RQLDe3pM4sBfSQ8vuHMuyoZfrvJmDaHyCqe/tYvEkhzO0SoVUVPJC0ZaXIGlYEDDPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9911
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 04:17:50 -0700 (PDT)

From: Ioana Ciornei <ioana.ciornei@nxp.com>

The blamed commit added the CDR check work item but didn't cancel it on
the remove path. Fix this by adding a remove function which takes care
of it.

Fixes: 8f73b37cf3fb ("phy: add support for the Layerscape SerDes 28G")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/phy/freescale/phy-fsl-lynx-28g.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/phy/freescale/phy-fsl-lynx-28g.c b/drivers/phy/freescale/phy-fsl-lynx-28g.c
index 4f036c77284e..c6323669f119 100644
--- a/drivers/phy/freescale/phy-fsl-lynx-28g.c
+++ b/drivers/phy/freescale/phy-fsl-lynx-28g.c
@@ -604,6 +604,14 @@ static int lynx_28g_probe(struct platform_device *pdev)
 	return PTR_ERR_OR_ZERO(provider);
 }
 
+static void lynx_28g_remove(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct lynx_28g_priv *priv = dev_get_drvdata(dev);
+
+	cancel_delayed_work_sync(&priv->cdr_check);
+}
+
 static const struct of_device_id lynx_28g_of_match_table[] = {
 	{ .compatible = "fsl,lynx-28g" },
 	{ },
@@ -612,6 +620,7 @@ MODULE_DEVICE_TABLE(of, lynx_28g_of_match_table);
 
 static struct platform_driver lynx_28g_driver = {
 	.probe	= lynx_28g_probe,
+	.remove_new = lynx_28g_remove,
 	.driver	= {
 		.name = "lynx-28g",
 		.of_match_table = lynx_28g_of_match_table,
-- 
2.34.1