Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Kalle Valo <kvalo@kernel.org>
To:     =?utf-8?B?SsOpcsO0bWU=?= Pouiller <jerome.pouiller@silabs.com>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] wifi: wfx: fix power_save setting when AP is
 stopped
References: <20230927163257.568496-1-jerome.pouiller@silabs.com>
        <20230927163257.568496-2-jerome.pouiller@silabs.com>
        <87ttr6heoz.fsf@kernel.org> <14139521.lVVuGzaMjS@pc-42>
Date:   Wed, 04 Oct 2023 14:30:45 +0300
In-Reply-To: <14139521.lVVuGzaMjS@pc-42> (=?utf-8?B?IkrDqXLDtG1l?=
 Pouiller"'s message of "Wed,
        04 Oct 2023 12:37:02 +0200")
Message-ID: <877co27hga.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com> writes:

> Hi Kalle,
>
> On Wednesday 4 October 2023 12:20:12 CEST Kalle Valo wrote:
>>=20
>> J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com> writes:
>>=20
>> > The WF200 allow to start two network interfaces (one AP, one station) =
on
>> > two different channels. Since magic does not exist, it only works if t=
he
>> > station interface enables power save.
>> >
>> > Thus, the driver detects this case and enforce power save as necessary.
>> >
>> > This patch fixes the case where the AP interface is stopped and it is =
no
>> > more necessary to enforce power saving on the station interface.
>> >
>> > Signed-off-by: J=C3=A9r=C3=B4me Pouiller <jerome.pouiller@silabs.com>
>> > ---
>> >  drivers/net/wireless/silabs/wfx/sta.c | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/drivers/net/wireless/silabs/wfx/sta.c b/drivers/net/wirel=
ess/silabs/wfx/sta.c
>> > index 626dfb4b7a55d..9c0a11c277e97 100644
>> > --- a/drivers/net/wireless/silabs/wfx/sta.c
>> > +++ b/drivers/net/wireless/silabs/wfx/sta.c
>> > @@ -402,7 +402,12 @@ void wfx_stop_ap(struct ieee80211_hw *hw, struct =
ieee80211_vif *vif,
>> >                struct ieee80211_bss_conf *link_conf)
>> >  {
>> >       struct wfx_vif *wvif =3D (struct wfx_vif *)vif->drv_priv;
>> > +     struct wfx_dev *wdev =3D wvif->wdev;
>> >
>> > +     wvif =3D  NULL;
>> > +     while ((wvif =3D wvif_iterate(wdev, wvif)) !=3D NULL)
>> > +             wfx_update_pm(wvif);
>>=20
>> Isn't the assignment of wvif to NULL unnecessary as in the next line we
>> assign it to again?
>
> wvif is also passed as argument to wvif_iterate(). wvif_iterate() uses th=
is
> parameter to know where the iteration has stopped on previous call.

Ah, I missed that.

> However, the assignation during the declaration of wvif is useless.

Indeed, missed that as well.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes