Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Wed, 4 Oct 2023 13:32:25 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     "Rabara, Niravkumar L" <niravkumar.l.rabara@intel.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: mtd: cadence: convert
 cadence-nand-controller.txt to yaml
Message-ID: <20231004133225.4a770789@xps-13>
In-Reply-To: <BL3PR11MB6532AC02EA46C2D861438A29A2CBA@BL3PR11MB6532.namprd11.prod.outlook.com>
References: <20231004061214.17176-1-niravkumar.l.rabara@intel.com>
        <20231004094455.1a6a19e1@xps-13>
        <BL3PR11MB6532AC02EA46C2D861438A29A2CBA@BL3PR11MB6532.namprd11.prod.outlook.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

> > > -Child nodes represent the available NAND chips. =20
> >=20
> > This is not fully pictured in the current schema, by referencing nand-
> > controller.yaml I believe you allow all kind of direct partitioning (wh=
ich is legacy,
> > and not supposed to be supported here).
> > Can you try to define a partition directly within the controller node i=
n the example
> > and see whether it still passes the checks?
> >=20
> > Thanks,
> > Miqu=C3=A8l =20
>=20
> Hi Miquel,
>=20
> I tried below in the controller node in example,
>=20
>        ...
>         clocks =3D <&nf_clk>;
>         cdns,board-delay-ps =3D <4830>;
>=20
>         partition@0 {
>           label =3D "boot";
>           reg =3D <0 0x00200000>;
>          };
>=20
>         nand@0 {
>             reg =3D <0>;
>         };
>=20
> It shows  'partition@0' was unexpected.
>=20
> DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb
> Documentation/devicetree/bindings/mtd/cadence,nand.example.dts:35.23-38.1=
4: Warning (unique_unit_address_if_enabled): /example-0/nand-controller@10b=
80000/partition@0: duplicate unit-address (also used in node /example-0/nan=
d-controller@10b80000/nand@0)
> /mnt/newvolume/users/nrabara/kernel.org/3oct23/Documentation/devicetree/b=
indings/mtd/cadence,nand.example.dtb: nand-controller@10b80000: Unevaluated=
 properties are not allowed ('partition@0' was unexpected)
>         From schema: /mnt/newvolume/users/nrabara/kernel.org/3oct23/Docum=
entation/devicetree/bindings/mtd/cadence,nand.yaml
>=20
> However using partition in nand node is OK.
>         nand@0 {
>             reg =3D <0>;
>            =20
>             #address-cells =3D <1>;
>             #size-cells =3D <1>;
>=20
>             partition@0 {
>               label =3D "boot";
>               reg =3D <0 0x00200000>;
>             };
>=20
>             partition@200000 {
>               label =3D "env";
>               reg =3D <0x00200000 0x00400000>;
>             };
>         };
>=20
> "make dt_binding_check DT_SCHEMA_FILES=3Dmtd/cadence,nand.yaml"  is OK wi=
thout any warnings.=20
>=20
> DTEX    Documentation/devicetree/bindings/mtd/cadence,nand.example.dts
> DTC_CHK Documentation/devicetree/bindings/mtd/cadence,nand.example.dtb
>=20
> Any additional changes required for this patch?

No, should be fine then.

Thanks,
Miqu=C3=A8l