Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 4 Oct 2023 07:06:57 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     Nitin Yadav <n-yadav@ti.com>, <vigneshr@ti.com>,
        <kristo@kernel.org>, <robh+dt@kernel.org>, <conor+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] arm64: defconfig: Enable GPMC NAND support
Message-ID: <20231004120657.hdmo5r6lzyohiodq@gauging>
References: <20231004111238.3968984-1-n-yadav@ti.com>
 <20231004111238.3968984-4-n-yadav@ti.com>
 <6ad28b45-815c-723a-117e-84782753a361@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6ad28b45-815c-723a-117e-84782753a361@ti.com>
Precedence: bulk

On 14:26-20231004, Roger Quadros wrote:
> 
> 
> On 4.10.2023 14.12, Nitin Yadav wrote:
> > Enable config required to support GPMC NAND on
> > AM62x LP SK and AM64x SKEVM.
> > 
> > Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> > ---
> >   arch/arm64/configs/defconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 66bfbef73324..a2758ac73f87 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -270,6 +270,8 @@ CONFIG_MTD_DATAFLASH=y
> >   CONFIG_MTD_SST25L=y
> >   CONFIG_MTD_RAW_NAND=y
> >   CONFIG_MTD_NAND_DENALI_DT=y
> > +CONFIG_MTD_NAND_OMAP2=m
> 
> If rootfs is required on NAND, it is better to be built-in.
> 
> > +CONFIG_MTD_NAND_OMAP_BCH=y
> >   CONFIG_MTD_NAND_MARVELL=y
> >   CONFIG_MTD_NAND_BRCMNAND=m
> >   CONFIG_MTD_NAND_FSL_IFC=y
> > @@ -1357,6 +1359,7 @@ CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
> >   CONFIG_EXTCON_PTN5150=m
> >   CONFIG_EXTCON_USB_GPIO=y
> >   CONFIG_EXTCON_USBC_CROS_EC=y
> > +CONFIG_OMAP_GPMC=m
> 
> This is a memory controller so better to be built-in.
> 
> >   CONFIG_RENESAS_RPCIF=m
> >   CONFIG_IIO=y
> >   CONFIG_EXYNOS_ADC=y

For the boards mentioned, NAND is optional and not a primary rootfs
storage media - I'd rather leave it as "m" and not impact the size of
generic Image file.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D