Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2601789rdb; Wed, 4 Oct 2023 06:22:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXUdvPrY3FOlRY9dfJ4KH1voa7VF3uDAzHpFuH6SjqfLHyl+9vuownKfDa8DzhCNbHRNbj X-Received: by 2002:a17:903:2451:b0:1c8:7364:a3ab with SMTP id l17-20020a170903245100b001c87364a3abmr2409880pls.17.1696425725179; Wed, 04 Oct 2023 06:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696425725; cv=none; d=google.com; s=arc-20160816; b=brc0+R6dIslAO4dbW8FxmkfHG1hvWuwSy0SQQsHXbVviMTuhAOQY7BYRxf3s5e9fAW Tf1LqaAyKBDqE2I2CYoIvi0RSNZSHcFpfO+cR9jEpXTUElbPauGNhVjkIIFKY6s2h1hw eujjvkj5+NbXicInll+vOTqiZBaFCvCNssuQl42dfU1UNK2QznRlM7DlY7W0nYu6Yj2F IqQccWLHF/v7Lxz+WjLjTx6dfKJ6bGGG4SN5Ffn7cae7n7piX2mZIUJ8pszEXctUfnrw anxh97CA9n30V+NMjnLhhvPktbLUXZCL0Bct+2j+XQ5YaeX7og1i0xfyQQcmsuZ9+z9z +bGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=6kG6h4FVIeOWgbkXYeRekgWXws8wRQ4WylJS0+hDXZc=; fh=AqceqxiqkPn/PPkD+sfuEpQz27A1f0SpyvBu+MTryns=; b=orD9WRMD4cHx7mJlzqoSUgoAnxl6qcPTjCRkH4id5r7Lzq/Vm4sZVuGBw7+1zlAPzy hfRavj8WVNJr97yz3weAIRrgMkNDBz5thcIOeIMlld78/JgH7ABLBhBxS85j+R6E1X6M E3VEz3LCpjlRBLU2qFqZ/QJCkCAnmfnx5Qvk4RCeyrcsICSz7qeB1bPO9g4s+PBwj/SZ vJVYu8Azp8cMg0g3HXqRkiCWWXo3nyI07M0cml/4NE5q2UPwLS4MfAPZiTRwlwEb65NS B8V+kahwTinyEviao0WSF5/EtmB8d42h/EFSccxIpYXGekSlTM8eL4lwe4XEkoscAe/k Nmsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sMRvkTLz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id kq15-20020a170903284f00b001b82a4d3ea7si3565965plb.249.2023.10.04.06.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 06:22:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sMRvkTLz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 790EC819705A; Wed, 4 Oct 2023 06:21:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242614AbjJDNUM (ORCPT + 99 others); Wed, 4 Oct 2023 09:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242619AbjJDNUL (ORCPT ); Wed, 4 Oct 2023 09:20:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA9DC6; Wed, 4 Oct 2023 06:20:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AB9EC433C8; Wed, 4 Oct 2023 13:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696425607; bh=Uc3NOTcxp+jJ5AbMaMdMtkI/XmkjuT7JikGjiL50+KY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sMRvkTLzaMOKie1V5CI3w1UUGAMZRWddWMA8oivj3Rvy+CAjwgeoQZIZs6ma68SsA NIVc02N8b+CKTFfintSqdwApeLdsRPPYZdbPNe7WTaHGPJAY5RFOXBzDKHBMv3UOw5 oNmOnC16HF2BfG8hxcSTPdkw/5h3hxjjplQ7GCUl3bhaWgwqDnJtpp6vP5+wxXjUA4 q80MdhnBAKpRATVVWfWEuokXHu3523qqyWw6xSVAilYqsDHfm8jN+xvbgzAUIqodoj uWbQTsp3tJRb2BbEl26HimZC5FinU3y9t6OgaiMVauv6/TXpE30ROmnanQasZesWl6 sXnM5l1QzKViA== Message-ID: Date: Wed, 4 Oct 2023 15:20:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the absence of ACPI enumeration Content-Language: en-US To: Andy Shevchenko Cc: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Linus Walleij , Takashi Iwai References: <20230926190818.931951-1-andriy.shevchenko@linux.intel.com> <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 04 Oct 2023 06:21:52 -0700 (PDT) On 04/10/2023 15:09, Andy Shevchenko wrote: > On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote: >> On 26/09/2023 21:08, Andy Shevchenko wrote: > > ... > >>> +MODULE_ALIAS("platform:denverton-pinctrl"); >> >> Why do you need the alias? It's the same as ID table. You most likely >> miss MODULE_DEVICE_TABLE() or your table is just wrong. > > This is cargo cult from pinctrl-broxton.c. If we want to fix, we need > to fix both. > Care to send patches? I don't understand how some other file affects this. Why do you exactly need module alias here? Which use-case does not work without it (after adding proper MODULE_DEVICE_TABLE())? Best regards, Krzysztof