Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Vinod Koul <vkoul@kernel.org>
To:     sean.wang@mediatek.com, Duoming Zhou <duoming@zju.edu.cn>
Cc:     matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
In-Reply-To: <20230806032511.45263-1-duoming@zju.edu.cn>
References: <20230806032511.45263-1-duoming@zju.edu.cn>
Subject: Re: [PATCH] dmaengine: mediatek: Fix deadlock caused by
 synchronize_irq()
Message-Id: <169642908358.429977.8140374757545835839.b4-ty@kernel.org>
Date:   Wed, 04 Oct 2023 19:48:03 +0530
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Sun, 06 Aug 2023 11:25:11 +0800, Duoming Zhou wrote:
> The synchronize_irq(c->irq) will not return until the IRQ handler
> mtk_uart_apdma_irq_handler() is completed. If the synchronize_irq()
> holds a spin_lock and waits the IRQ handler to complete, but the
> IRQ handler also needs the same spin_lock. The deadlock will happen.
> The process is shown below:
> 
>           cpu0                        cpu1
> mtk_uart_apdma_device_pause() | mtk_uart_apdma_irq_handler()
>   spin_lock_irqsave()         |
>                               |   spin_lock_irqsave()
>   //hold the lock to wait     |
>   synchronize_irq()           |
> 
> [...]

Applied, thanks!

[1/1] dmaengine: mediatek: Fix deadlock caused by synchronize_irq()
      commit: 01f1ae2733e2bb4de92fefcea5fda847d92aede1

Best regards,
-- 
~Vinod