Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 4 Oct 2023 10:23:51 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Minghuan Lian <minghuan.Lian@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linuxppc-dev@lists.ozlabs.org>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-pci@vger.kernel.org>,
        "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     imx@lists.linux.dev
Subject: Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a
Message-ID: <ZR10SVVBYvfMJPv1@lizhi-Precision-Tower-5810>
References: <20230915184306.2374670-1-Frank.Li@nxp.com>
 <20230915184306.2374670-2-Frank.Li@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230915184306.2374670-2-Frank.Li@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rNvXiN6wplQsfWqS1E02Hd8gLapLEBrfzkN3S+u2bZJ+amKrP81bn+mc0LKB?=
 =?us-ascii?Q?fZnzrZbSuYVBsfLnMmNPVpyG435yaXV9ttaeJLIgMfyQ8tweJ/zpmwXk5MDv?=
 =?us-ascii?Q?cOt8lL5hUTvdq58gKGQiOHAvr4/t86+kubgWAdDqd0VtgKVEIiGMECDcDj30?=
 =?us-ascii?Q?9NYGjO3Xo1VVDM07DK56PePA4p5tiHqp3WZH9gnIbSH6UUuJJPX1bYopv9fa?=
 =?us-ascii?Q?Cc0w6d/yACLgclLSLmYSyykoFcii8SyO3Nh4QyJiYm6MrzTL21yBrnFEHnTL?=
 =?us-ascii?Q?2HE0c4WdMAca74xebjrnTbImBmbaLH7smGISO5g/0LJAXkp0tkbEIAruKI+j?=
 =?us-ascii?Q?co+IuDHMaL1aM/5faO6kLrNUOTkKTWZt/SFh1r3arccszAFDMS2zTba8tsNH?=
 =?us-ascii?Q?80mxbDlGN1pPVhe4ulTM7hzQu2qqdpNmF3116v0/qqzZHfAwv0nCpo8GMZSe?=
 =?us-ascii?Q?8XilVoPdxZpYhXs77oVolohYlcMYPZvVGJ45H6lroseMPapneYl9Gq1VW4SQ?=
 =?us-ascii?Q?Mhx9g+qp6C+kqxYJn7YuET8WfivGp0bkOLrQGUKFHQER1n2aC9eZhl1Ix1ym?=
 =?us-ascii?Q?J5TBs1saa5FCdlr+gKsfyZyJzZpnhR7AI1v4oxTCY+dGrkm0HPrI7VwNO6pj?=
 =?us-ascii?Q?12pAanlQA8UI36O8oD0iO8SNcr1naEfGeH3/QJWgIqYlnBx4M8amaH3e7stT?=
 =?us-ascii?Q?EGV7ZXUn/N1EKjg2GDLx4AXhvxqxcSTCS9s0AmVwesn5acgfdE7F22x6jz/0?=
 =?us-ascii?Q?qIyCZtpVzYKlkw39u3NIH5p5i6m2z606iBy5cdmEIF1cOQ9M5ubZ5OBNH19x?=
 =?us-ascii?Q?z9wxSgPZRKDoQQxS8YmbcRtuNe2E8vXAhXFhCUz621y/xApbsx56WtSK+0oc?=
 =?us-ascii?Q?IUIfnDnV4hZVSNnap1P3o9StvFb3JG898ox+jDWaM3O5gZNCbUMV3VibSZ6N?=
 =?us-ascii?Q?lmyCwVecrYKURBly3RbttubDoJR1huvdwq70vIAjQCt1FzKhWPEXdlqD3yDi?=
 =?us-ascii?Q?KfffMIa5PHcD9h2hVkVkrXUu52hhjLWUpHgZcoARJLsLdIyMiZlSweXzWfq8?=
 =?us-ascii?Q?SeMUkB15zpA0rAac31hmJaOOsC6qjpixCooVURkGKCcwSoGlnLasUDuiX3Ae?=
 =?us-ascii?Q?eY3x+ckvOXP3GXoOFVupwZx59SX9Wa4jmpBrNi3o0E82sqnQyjiAdAC6EAko?=
 =?us-ascii?Q?xJZ7t3Zh7p0kyY76dQtxszOcJdRqSG9FTrm2y+ysrrSuFd8vu6liAivBN1aE?=
 =?us-ascii?Q?slumjkq9tjnI5FF4WPIAshdPaBHNKQPtDDtp9op5AYIooc6taN48HgBz6H4/?=
 =?us-ascii?Q?J2WYOEwd2+BjY70rrJJGLqyYSfMQ9jspT1Mmh2djHYvDmfQS2q4Sj80Vb3nh?=
 =?us-ascii?Q?bs0q9yuewqPrEeabQEvPFGlc/No+g8TYC3RAp7IOYStCViYyLvxIRBkhleVj?=
 =?us-ascii?Q?mUJN8fwWbwX4auEh9dbt35tQ/Gf2XP3So3WjXLQzIpx6A4ZNmuiMHwoWPgvd?=
 =?us-ascii?Q?pXLfa5nSD73fi+FKjiJX6xZMSFUTxA9FRWACdeWQts1yj1hfAo49vpifHtjI?=
 =?us-ascii?Q?YDcT9M9lUYH4Ymxp8/GBtDphT5ZmHigujIM09BiA?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52641c2f-17eb-458e-f17d-08dbc4e58f09
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4839.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 14:24:03.7995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D1w8ekDqpzt0/MveuGgwH6oOd40ghieNZHnhEvcdSDuKLpNZjVy+ZXZu5fAXhe6EVIL3MwuTZ33Wn7ex6RdoDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7483
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 07:24:14 -0700 (PDT)

On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote:
> ls1021a add suspend/resume support.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

ping

Frank

>  drivers/pci/controller/dwc/pci-layerscape.c | 88 ++++++++++++++++++++-
>  1 file changed, 87 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 20c48c06e2248..bc5a8ff1a26ce 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -35,6 +35,12 @@
>  #define PF_MCR_PTOMR		BIT(0)
>  #define PF_MCR_EXL2S		BIT(1)
>  
> +/* LS1021A PEXn PM Write Control Register */
> +#define SCFG_PEXPMWRCR(idx)	(0x5c + (idx) * 0x64)
> +#define PMXMTTURNOFF		BIT(31)
> +#define SCFG_PEXSFTRSTCR	0x190
> +#define PEXSR(idx)		BIT(idx)
> +
>  #define PCIE_IATU_NUM		6
>  
>  struct ls_pcie_drvdata {
> @@ -48,6 +54,8 @@ struct ls_pcie {
>  	struct dw_pcie *pci;
>  	const struct ls_pcie_drvdata *drvdata;
>  	void __iomem *pf_base;
> +	struct regmap *scfg;
> +	int index;
>  	bool big_endian;
>  };
>  
> @@ -170,13 +178,91 @@ static int ls_pcie_host_init(struct dw_pcie_rp *pp)
>  	return 0;
>  }
>  
> +static void ls1021a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp)
> +{
> +	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> +	struct ls_pcie *pcie = to_ls_pcie(pci);
> +	u32 val;
> +
> +	if (!pcie->scfg) {
> +		dev_dbg(pcie->pci->dev, "SYSCFG is NULL\n");
> +		return;
> +	}
> +
> +	/* Send Turn_off message */
> +	regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val);
> +	val |= PMXMTTURNOFF;
> +	regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val);
> +
> +	/* There are not register to check ACK, so wait PCIE_PME_TO_L2_TIMEOUT_US */
> +	mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000);
> +
> +	/* Clear Turn_off message */
> +	regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val);
> +	val &= ~PMXMTTURNOFF;
> +	regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val);
> +}
> +
> +static void ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp)
> +{
> +	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> +	struct ls_pcie *pcie = to_ls_pcie(pci);
> +	u32 val;
> +
> +	regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val);
> +	val |= PEXSR(pcie->index);
> +	regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val);
> +
> +	regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val);
> +	val &= ~PEXSR(pcie->index);
> +	regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val);
> +}
> +
> +static int ls1021a_pcie_host_init(struct dw_pcie_rp *pp)
> +{
> +	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> +	struct ls_pcie *pcie = to_ls_pcie(pci);
> +	struct device *dev = pcie->pci->dev;
> +	u32 index[2];
> +	int ret;
> +
> +	ret = ls_pcie_host_init(pp);
> +	if (ret)
> +		return ret;
> +
> +	pcie->scfg = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,pcie-scfg");
> +	if (IS_ERR(pcie->scfg)) {
> +		ret = PTR_ERR(pcie->scfg);
> +		dev_err(dev, "No syscfg phandle specified\n");
> +		pcie->scfg = NULL;
> +		return ret;
> +	}
> +
> +	ret = of_property_read_u32_array(dev->of_node, "fsl,pcie-scfg", index, 2);
> +	if (ret) {
> +		pcie->scfg = NULL;
> +		return ret;
> +	}
> +
> +	pcie->index = index[1];
> +
> +	return ret;
> +}
> +
>  static const struct dw_pcie_host_ops ls_pcie_host_ops = {
>  	.host_init = ls_pcie_host_init,
>  	.pme_turn_off = ls_pcie_send_turnoff_msg,
>  };
>  
> +static const struct dw_pcie_host_ops ls1021a_pcie_host_ops = {
> +	.host_init = ls1021a_pcie_host_init,
> +	.pme_turn_off = ls1021a_pcie_send_turnoff_msg,
> +};
> +
>  static const struct ls_pcie_drvdata ls1021a_drvdata = {
> -	.pm_support = false,
> +	.pm_support = true,
> +	.ops = &ls1021a_pcie_host_ops,
> +	.exit_from_l2 = ls1021a_pcie_exit_from_l2,
>  };
>  
>  static const struct ls_pcie_drvdata layerscape_drvdata = {
> -- 
> 2.34.1
>