Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Feedback-ID: ib7794740:Fastmail
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 04 Oct 2023 17:56:09 +0300
Message-Id: <CVZQQCDA444R.KWA6OPEZRIBG@ftml.net>
From:   "Konstantin Shelekhin" <k.shelekhin@ftml.net>
Subject: Re: [PATCH v4 7/7] rust: workqueue: add examples
Cc:     "Alice Ryhl" <aliceryhl@google.com>, <alex.gaynor@gmail.com>,
        <benno.lossin@proton.me>, <bjorn3_gh@protonmail.com>,
        <gary@garyguo.net>, <jiangshanlai@gmail.com>,
        <linux-kernel@vger.kernel.org>, <nmi@metaspace.dk>,
        <ojeda@kernel.org>, <patches@lists.linux.dev>,
        <rust-for-linux@vger.kernel.org>, <tj@kernel.org>,
        <wedsonaf@gmail.com>, <yakoyoku@gmail.com>
To:     "Boqun Feng" <boqun.feng@gmail.com>
References: <CVZ2KU4KK5YH.2HVL1F6X93YLL@pogg>
 <20231003222947.374039-1-aliceryhl@google.com>
 <CVZLU74VWMKA.GQXYH7WUNPS4@pogg> <ZR144pugIJQRAFjj@boqun-archlinux>
In-Reply-To: <ZR144pugIJQRAFjj@boqun-archlinux>
Precedence: bulk

> This is not a problem until nvmet actually uses/switches to Rust, right?
> ;-) We can certainly improve the API when a real user needs something.
> Or you know someone is already working on this?

Nope, not at this moment. I have an itch to experiment with Rust and
iSCSI, but that's my personal toy without any plans to at least propose
it to the subsystem maintainers yet.

> All of your suggestions make senses to me, but because we don't have
> many users right now, it's actually hard to determine a "best" API. I
> like what we have right now because it's explicit: people won't need to
> learn much about procedure macros to understand how it works, and it
> also provides better opportunities for people who's yet not familiar
> with Rust to give some reviews. So starting with something relatively
> simple and verbose may not be a bad idea ;-)
>
> Again, I like your idea, we need to explore that direction, but one
> dragon at a time ;-)

Oh yeah, completely understand :)