Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2763339rdb; Wed, 4 Oct 2023 10:37:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyQXYKyj9VKpQBnD8LB8kBfm1QCocPGl3lV6qXwn2sTINtuurejophYDKjCH1iQ9+alAJt X-Received: by 2002:a05:6a00:1687:b0:68a:5395:7aa5 with SMTP id k7-20020a056a00168700b0068a53957aa5mr3150019pfc.17.1696441038139; Wed, 04 Oct 2023 10:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696441038; cv=none; d=google.com; s=arc-20160816; b=J326bC/ad/+DzGZ+PeSwa7WMxdDMy9j/0INxaAZOhlGnOTNIqNhBHiU15px2EyXV3t i16X9mDREhPMlWu4eSrUUeMMwF0kTWzM371sKRACNOQ7dXidp3KaTgjP++PPe7fgtTFh 9k2eeGwW9/snvnS2VNd3dEb1qiUGw4gBbxAdmrKuxVlsgZ9ZjJwxQKOFvWV3BYoEWXPe mOV8ZpFNi5LKnd/sNXQfZhUKc1UQMnfzZAlBEALtdC/8NraIZjkOoL43SndDbild35QG F4PZqyjcQAxjiJw1V8xOHj79B20GpaXoLguJ2IEK/isn+M/Wp9uohNEp2dMjjJ5n2iOA N6pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=g29tpi2UnIBTW31PgclWidtbuPMj8CfZn07mYSfvtsM=; fh=cW16Y1m0OBLjHOwebEd29YbfkxhEtOD/YEo3DMHtKw8=; b=AX+NEkGiLtFEMKRkAqhQ5QyW9k9E5eTgItUCcmq0NOxm5wSdG+au5r80zWpkMvBiMp itbRZtleMHUWU8JOyICZT6DubdP3lLawVkSoaWwhUGXnOyhY1wB1/kYfD/W5hDbxll7g ke0NAsjegaravdrgWZ0zzwJ5UTx/V/mDJXa/PSqdFb6XrDq7FznGik2f5ZvGMowfVNHt bO6ixZSLKtII/lriYl/GWaAtjV0wRFkK/OH4BWSwKejISTvFAAxwYqDDA7Appoj5C+Hu Sdi6AMB2+E2gF222q+tHVKxjbMndQfDXrC6yEUAkbrPLcTzTYJ2eHgYjzJ5tTbo9V6pU +k/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id h70-20020a638349000000b00573fb2f7537si4315757pge.586.2023.10.04.10.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 10:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4910980E9E9F; Wed, 4 Oct 2023 10:37:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233440AbjJDRhD (ORCPT + 99 others); Wed, 4 Oct 2023 13:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233502AbjJDRhC (ORCPT ); Wed, 4 Oct 2023 13:37:02 -0400 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8317A7; Wed, 4 Oct 2023 10:36:58 -0700 (PDT) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-690fe10b6a4so17504b3a.3; Wed, 04 Oct 2023 10:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696441018; x=1697045818; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g29tpi2UnIBTW31PgclWidtbuPMj8CfZn07mYSfvtsM=; b=qQP4sdMIAAtgVfLmnYyVPRvyzkMAPFL61LG/c5KoWZHO8jacy0fIZqFss4YoRsaofY 3JzSkfekjL3WQISXO1VT1ZSlYRbS2F+uCEjDIieoLLE4PA7lV16NDDLza4JOgEEf47AJ VUWO66nUXw0Mnn7ojwn+jGljiXSpIdVw1FDtxBX/V2bhj+AfMl4R6ZIh6wYzW3TouVaV r4UyuIOfF8GZI5kcUa1RX3FljLzbBwZ1g48uL1JYj/IVAT9npSUKshhS6o8uR34+PEDw vLAoaD9ozQF9+dYTjIqyIqkJp09X2hklcn+6s3ZJ/fNvlQNcfSO23fwn4RVNbktesuxd 8dJQ== X-Gm-Message-State: AOJu0YwGZJIjSipWcQFgODGPG5F+VTuZO+L1cYGXL4RQ7tcSRqseOgLw 4sdE7b2rfFhLrbG7ZkhFnRxSdiqlgaU= X-Received: by 2002:a05:6a20:7fa8:b0:159:c2d0:9fc6 with SMTP id d40-20020a056a207fa800b00159c2d09fc6mr3529835pzj.8.1696441018078; Wed, 04 Oct 2023 10:36:58 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:969d:167a:787c:a6c7? ([2620:15c:211:201:969d:167a:787c:a6c7]) by smtp.gmail.com with ESMTPSA id n18-20020a62e512000000b0068ffd56f705sm3510725pff.118.2023.10.04.10.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 10:36:57 -0700 (PDT) Message-ID: Date: Wed, 4 Oct 2023 10:36:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] readv.2: Document RWF_ATOMIC flag Content-Language: en-US To: John Garry , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Cc: martin.petersen@oracle.com, djwong@kernel.org, david@fromorbit.com, himanshu.madhani@oracle.com References: <20230929093717.2972367-1-john.g.garry@oracle.com> <20230929093717.2972367-3-john.g.garry@oracle.com> <9ba10b14-931b-42db-b7c2-e6f9aa95e477@acm.org> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 04 Oct 2023 10:37:15 -0700 (PDT) On 10/4/23 01:47, John Garry wrote: > On 03/10/2023 20:25, Bart Van Assche wrote: >> Additionally, shouldn't it be documented what value will be stored in >> errno if the atomic write has been rejected? > > So I was treating all atomic writes errors which don't follow the > "rules" as low-level I/O errors, which is -EIO. However, yes, I can > document this. Further to that, based on description of an error for > O_DIRECT, which is to return -EINVAL for misaligned, I think that > -EINVAL may be better for any atomic write rule violations. OK? That sounds good to me. Thanks, Bart.