Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 4 Oct 2023 11:00:31 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vishvambar Panth S <vishvambarpanth.s@microchip.com>
Cc:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <bryan.whitehead@microchip.com>, <unglinuxdriver@microchip.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: lan743x: improve throughput
 with rx timestamp config
Message-ID: <20231004110031.7e9c32e8@kernel.org>
In-Reply-To: <20230926155658.159184-1-vishvambarpanth.s@microchip.com>
References: <20230926155658.159184-1-vishvambarpanth.s@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> +			netif_warn(adapter, drv, adapter->netdev,
> +				   "rx timestamp = %d is not supported\n",
> +				   rx_filter);

I addition to Jake's comments please also drop this warning.

> +			return -EINVAL;

And make sure this is the correct return code.
I thought -ERANGE was more appropriate here, but I could be wrong.