Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2793604rdb; Wed, 4 Oct 2023 11:33:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW6Jt2tbNq1rXcak8IC2K6vi32nNE4QBJIOakcxgJ4RkUElcdcCqkr/Xkh8Kz+PoAdN8Lx X-Received: by 2002:a05:6e02:12c2:b0:34f:3262:a8bf with SMTP id i2-20020a056e0212c200b0034f3262a8bfmr3907004ilm.17.1696444389398; Wed, 04 Oct 2023 11:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696444389; cv=none; d=google.com; s=arc-20160816; b=yjjQbQ0y1aVgUsTj20Tnor7gS1lvKVHNY+SRF242qtyWHMQk/MNVVWWziiUd0iS5G5 ApCoaHt5zV23gqwXC4ncUg6pbLFQnerZcaqeWMDtAopIQNx8UGFd06l8ceMvN9+CkRSI mRjlF42OxdxD4MVcmA4qEcZaVG9DVuV26vVmYy5HwBcIfjG1i9zEx9vQ+PDJVaZOhb06 HreJYkqw243lHvgB6OZ2oUjp/LVOVyJMWcG1TgxYYphL4HhBjSL0kY4tXwAsKBhgZdGw +4IMW2kSdjUc8Ryii+jjOyqKUnFgjIbdy6QvO93UCbz86SEM3DRwdL14ClOCvmf+HwDr QZFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t4VXNBgch7cHxmFAAfzZ4yk5G9bBv4IijY2ezEVg1sI=; fh=96vkDQrDuCQHUmVROYgg3JgicjPqVxBrKF+j5EAggas=; b=kr7US42rN+I7XXICuOIL9k/gEZyLw9k+EQWSH57Gwxkz+snLhljTZK8f5Is2ZaPJx8 vF2x4Kns8cvE+H9pVWD/5l8i0TxraRstRCwLtyc/DzjJasp5Ti61AyqNf1jSV8k/psuJ NShb0v5pe7TF/v2IuKBLZZk8oUV5BR+p/8h12CtIDf0oSNlLYMoNxutfy1YKlxUippav xDSAxO1vAPTFgYUeoq8Jl0OF0LB1TIj8h+WARCtiieZq5v0B0DE/OzGRB9dHpLUZ4SlO TZsa08a0xE6pQQVilMCUbsErab9/nHoLZLwgODJc1IzBxqrpyjVVFgPRZ48SllBc9J7N GmEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="q/nTqZ7H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c3-20020a631c03000000b005648b1d63aasi4253611pgc.553.2023.10.04.11.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:33:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="q/nTqZ7H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3450882878BD; Wed, 4 Oct 2023 11:33:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244326AbjJDScr (ORCPT + 99 others); Wed, 4 Oct 2023 14:32:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244249AbjJDScq (ORCPT ); Wed, 4 Oct 2023 14:32:46 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50A2DA6; Wed, 4 Oct 2023 11:32:42 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E4D771F45A; Wed, 4 Oct 2023 18:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696444360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t4VXNBgch7cHxmFAAfzZ4yk5G9bBv4IijY2ezEVg1sI=; b=q/nTqZ7HNJl0vlRvhOtwEPvLtgxtFocf5ftD56dKVl0FPuULOQaHC14ugXq6VkQ/dD1SpJ XxPViUE9If05/xUd6xRLKOJ3xpJ0nNQ8JkqyhiNe9A3TuQ72DIqatVz75ZWCdVixXdLl76 ZZURgLF1RgVTYYjoT1TQZBB+/EO2tyo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B6ECD139F9; Wed, 4 Oct 2023 18:32:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UpfVK8ivHWV/dQAAMHmgww (envelope-from ); Wed, 04 Oct 2023 18:32:40 +0000 Date: Wed, 4 Oct 2023 20:32:39 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka Subject: Re: [PATCH v1 0/5] mm: improve performance of accounted kernel memory allocations Message-ID: References: <20230929180056.1122002-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xrhdawqlfcfif6oj" Content-Disposition: inline In-Reply-To: <20230929180056.1122002-1-roman.gushchin@linux.dev> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:33:02 -0700 (PDT) X-Spam-Level: ** --xrhdawqlfcfif6oj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 29, 2023 at 11:00:50AM -0700, Roman Gushchin wrote: > This patchset improves the performance of accounted kernel memory allocations > by ~30% as measured by a micro-benchmark [1]. The benchmark is very > straightforward: 1M of 64 bytes-large kmalloc() allocations. Nice. Have you tried how these +34% compose with -34% reported way back [1] when file lock accounting was added (because your benchmark and lock1 sound quite similar)? (BTW Is that your motivation (too)?) Thanks, Michal [1] https://lore.kernel.org/r/20210907150757.GE17617@xsang-OptiPlex-9020/ --xrhdawqlfcfif6oj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZR2vxQAKCRAGvrMr/1gc jrolAQCd8T26iT1xL/GtSHTC7BZH+GIQ5QrCf0gJt5shxk7K2wEAu4q5L5+nO7Hz BDRacJqGpEoX/IwT3UmgeM1mIClLHwo= =SuM6 -----END PGP SIGNATURE----- --xrhdawqlfcfif6oj--