Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2796487rdb; Wed, 4 Oct 2023 11:39:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQXoukFpvKZS153iwB5OaarmxX8fkPY6bFccJ2/637gsQ9yFyHXhZo5ydQtoTzSXJBux+U X-Received: by 2002:a05:6e02:1ca8:b0:345:3378:4251 with SMTP id x8-20020a056e021ca800b0034533784251mr3646183ill.23.1696444758004; Wed, 04 Oct 2023 11:39:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696444757; cv=none; d=google.com; s=arc-20160816; b=zR+L3pUCukUGu14xu64yzKgZPW7qYxSrsr2zRFL/Rf9XVYMZHCWn6wWW+8vi0p/fa3 2+Etm6L0lh3UBRPfC3UXdluQQZXKB+52XHXY4VTdda5lPKfFVGz0sY4xniZ7B7rU7Xbn M/s5VF7HDlXjf61sYo7XpfFj+lYAsxLEhG1F7W9SFZZCrkJWKDy3iY3HWfvYrUsZ4Br7 TNM3H2exlsmV41Uh8csVk6FwOPdzeNGU71InH8qaThn4eymJWP6eF0m5DClb0hd87DAm W/bt8zEmV+2wEymf8graMFvENDhsIZgBEH6FtAaFx4WS6fKubtHbuLWsuZ+m6F/ZGDs3 Yb5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=DpVXv4bi27kbwhcFtKiltzdEWNLjeqF8vKmHb71bbO8=; fh=5dG6x1cYcRK0pGuP76GdEvYg/iV9nfSsz/LTc+yx700=; b=z+8t2l9b+bazn3SJOMTpz/w9GW2dTOT7ODmuyY5IasDyL7Gj2Gzk8R8QR/YvAaGl01 xbMw/B4Jhuk93CoIiMAQqEPS2FViFrbZpJsbXrUbPSF6KMJl/lC+BcAIwPRF8ZbGtqZp kO/+j5KAMmhiqDWFFWdI2Bsy/3uyOGYl7nugGpmvz7d0lhIhWgcrQOdy84cTatGAFyhe bbAvYztsCFj1MoGIAo98nMv/NVEWBWbHLXdc0dZW1Ga8fJeD7F8emrNgSOtSYmENd/8z SSejJtNPNr9cP624s9j6nCProW3pyyTlTYtP6hibxksVgEj3nollcRpFqobj3Nu1W3bS gtww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LTQbCcyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id s196-20020a6377cd000000b005776089b39dsi4342367pgc.317.2023.10.04.11.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:39:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LTQbCcyv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 02BEC81E5572; Wed, 4 Oct 2023 11:38:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244471AbjJDSh7 (ORCPT + 99 others); Wed, 4 Oct 2023 14:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233552AbjJDSh5 (ORCPT ); Wed, 4 Oct 2023 14:37:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FEB6DD; Wed, 4 Oct 2023 11:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696444673; x=1727980673; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=DpVXv4bi27kbwhcFtKiltzdEWNLjeqF8vKmHb71bbO8=; b=LTQbCcyv84P+F5JBseUGtauxYe7ACRUL1641sO+cgY+taiTWED+oUd6r dlsN1pQ56Ff24MRXb5NTH0O3dGBwdpqHMAG1SHypagep0wKFI7q+0L00h lqWGzTGQIIkikQbakQpZhzSaNxbcK5WGGDusAZh3O+LdeusAxBMvelt+o fBO2PzoQOe4iPp/KvIKTYrCBiPwKQ8PJcWgUm0IpheyagQiG0oYuD7s0A 0/q6GUB5IXNvlElx1JrNVSksmNbaDH5bdVPBbUNDlv96j8HoBByTHVv66 Ksvc47LWxsh+Ih3wylVeBqT3gQMox9lUjvbFsoIZE2niFCSNUlwKsloLZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="386091281" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="386091281" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 11:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="745094397" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="745094397" Received: from spandruv-desk1.amr.corp.intel.com ([10.209.86.10]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 11:37:52 -0700 Message-ID: <798686123b656dcd0907851160ea1a26506750d1.camel@linux.intel.com> Subject: Re: [PATCH v2 1/3] platform/x86/intel/tpmi: Add defines to get version information From: srinivas pandruvada To: Andy Shevchenko Cc: hdegoede@redhat.com, markgross@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2023 11:37:45 -0700 In-Reply-To: References: <20231003184916.1860084-1-srinivas.pandruvada@linux.intel.com> <20231003184916.1860084-2-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:38:59 -0700 (PDT) X-Spam-Level: ** On Wed, 2023-10-04 at 15:59 +0300, Andy Shevchenko wrote: > On Tue, Oct 03, 2023 at 11:49:14AM -0700, Srinivas Pandruvada wrote: > > Add defines to get major and minor version from a TPMI version > > field > > value. This will avoid code duplication to convert in every feature > > driver. Also add define for invalid version field. >=20 > ... >=20 > > +#define TPMI_VERSION_INVALID=C2=A0=C2=A0=C2=A00xff >=20 > I would make it clearer with (GENMASK(7, 5) | GENMASK(4, 0)) > or even with specific masks defined and used in both cases: > #def >=20 > #define TPMI_MINVER_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0G= ENMASK(4, 0) > #define TPMI_MAJVER_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0G= ENMASK(7, 5) >=20 > #define TPMI_VERSION_INVALID=C2=A0=C2=A0=C2=A0=C2=A0(TPMI_MINVER_MASK | T= PMI_MAJVER_MASK) >=20 > #define TPMI_MINOR_VERSION(val)=C2=A0FIELD_GET(TPMI_MINVER_MASK, val) > #define TPMI_MAJOR_VERSION(val)=C2=A0FIELD_GET(TPMI_MAJVER_MASK, val) >=20 > > +#define TPMI_MINOR_VERSION(val)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0FIELD_GET(GENMASK(4, 0), > > val) > > +#define TPMI_MAJOR_VERSION(val)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0FIELD_GET(GENMASK(7, 5), > > val) OK. Will add another patch on top. Thanks, Srinivas >=20