Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2797429rdb; Wed, 4 Oct 2023 11:41:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8xjvAUmNEIMSzSMV+0qpAxZNbqQJ53n3Z0wE3Ik88XvGNro/jigZx+84A++a8WTrM/n7g X-Received: by 2002:a05:6a20:918e:b0:162:edc2:4e9f with SMTP id v14-20020a056a20918e00b00162edc24e9fmr3450677pzd.62.1696444879959; Wed, 04 Oct 2023 11:41:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696444879; cv=none; d=google.com; s=arc-20160816; b=rGVdqAevaz7uSXXsSGxLoR97AbMVspP/jkF7ehtXO8TD2tXpn8XMu2m4hz3Ffqztye gSGUoLZINu/pLbfSJqn4kSFK7vq7gy/zFnQPp7BF+JAPj+C61Rdq19SLTiL155yIhGFB jgWYD62NiU2hSf/4zSCn6/Zbe/LweQefhcW+lJnzg8XZaFmagxXlcY9c7Zj9DaHFFS4f TjFOmS18pD3ul+KEXHVlBsDeoTOLYpfw+yDV/vglewWTtAswDUCQNK04v1rgE3gC+oDi FH0pfMd+HpMfpjhUfJVaFXkWCKiRi7BIqsPoinP4ABBdmw3ghptOF/UfBR7eH4KZabjF gH9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z0b/Hy2qC+xrQUHKjE53J01KhR5PkM+fGaJhgF9dLKI=; fh=lsq0wkbTP+CRmv+pQ24G1bYYBCuvZeqbFQie/6bVG6s=; b=Y6rjRkiJ8qzLUqj0087tjZ63we/PFEfOgIn+4Mp96uglN7Agujvznaxb225KIaMdtI sh2vjZ/OSYXVmhOZLYGiLbJbMoVygkgyOvDV91DaiEY2W1a10H1RmiVMz8zY0/biTjOE ajTSl/MIAJzC0oyYT/7VgYWFX/PoOAmQrzq94b88dUxv1U+vN3KEs+2UmYhXUGkYUlgQ vox/mn1SQ+LB+d/rxFIOz0XGUYsDkwIpuoDb5T+bXb1Zjbun/OSYZJm4lGIrpvCjRmAJ jH0zBrT9ldOIvOPw8KNyWhvFhwXpN9qwE36moya2qU6tqyzsP7/oK8Hr5CTnH1M0TlvY cT4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=CIRmL5rV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id q26-20020a631f5a000000b0057745d87b53si4059496pgm.686.2023.10.04.11.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:41:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=CIRmL5rV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id ED6C481C57F9; Wed, 4 Oct 2023 11:41:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243292AbjJDSkc (ORCPT + 99 others); Wed, 4 Oct 2023 14:40:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbjJDSkb (ORCPT ); Wed, 4 Oct 2023 14:40:31 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B0B4AD; Wed, 4 Oct 2023 11:40:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A9CF1F38A; Wed, 4 Oct 2023 18:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696444824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z0b/Hy2qC+xrQUHKjE53J01KhR5PkM+fGaJhgF9dLKI=; b=CIRmL5rVXuVKNvEluhdeQYsdcFo47d2lJNpcXC6/E3RclyMV17oj8SKUu67znTPY2Jg4hM gnbTLdYsV0Q+JQf2Vm3ZisZAPHEz3W3NQDhHUhCT9wC4rdZ48Z1fjFaeKKDyNY70BLBfyG bf4WxgXBjQz7ypXE+DqP6U6KjobEt/8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 01653139F9; Wed, 4 Oct 2023 18:40:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9r4QO5exHWUBeQAAMHmgww (envelope-from ); Wed, 04 Oct 2023 18:40:23 +0000 Date: Wed, 4 Oct 2023 20:40:22 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Luiz Capitulino Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, longman@redhat.com, kamalesh.babulal@oracle.com Subject: Re: [RESEND v3] cgroup: add cgroup_favordynmods= command-line option Message-ID: References: <20230927142539.GB65411@dev-dsk-luizcap-1d-37beaf15.us-east-1.amazon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2dtbseo44kaj25fv" Content-Disposition: inline In-Reply-To: <20230927142539.GB65411@dev-dsk-luizcap-1d-37beaf15.us-east-1.amazon.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 11:41:02 -0700 (PDT) X-Spam-Level: ** --2dtbseo44kaj25fv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 27, 2023 at 02:25:40PM +0000, Luiz Capitulino wrote: > We have a need of using favordynmods with cgroup v1, which doesn't support > changing mount flags during remount. Enabling CONFIG_CGROUP_FAVOR_DYNMODS= at > build-time is not an option because we want to be able to selectively > enable it for certain systems. >=20 > This commit addresses this by introducing the cgroup_favordynmods=3D > command-line option. This option works for both cgroup v1 and v2 and also > allows for disabling favorynmods when the kernel built with > CONFIG_CGROUP_FAVOR_DYNMODS=3Dy. >=20 > Also, note that when cgroup_favordynmods=3Dtrue favordynmods is never > disabled in cgroup_destroy_root(). >=20 > Signed-off-by: Luiz Capitulino > --- > .../admin-guide/kernel-parameters.txt | 4 ++++ > kernel/cgroup/cgroup.c | 18 ++++++++++++++---- > 2 files changed, 18 insertions(+), 4 deletions(-) (resend too) Reviewed-by: Michal Koutn=FD --2dtbseo44kaj25fv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZR2xlQAKCRAGvrMr/1gc jhncAQCAY8bsHAYze4HbU9YSFMlgVGJPXFhgE5Kv4z4RBr/sOAEAt4pmDKQQM4Hk od2v6vOBMtMATE/rcm5dpRtRxTLXQAY= =E5vU -----END PGP SIGNATURE----- --2dtbseo44kaj25fv--