Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 4 Oct 2023 21:16:12 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Fabian Vogt <fabian@ritter-vogt.de>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: Add quirk to ignore the touchscreen battery on HP
 ENVY 15-eu0556ng
In-Reply-To: <4537226.LvFx2qVVIh@fabians-envy>
Message-ID: <nycvar.YFH.7.76.2310042116030.3534@cbobk.fhfr.pm>
References: <4537226.LvFx2qVVIh@fabians-envy>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 3 Oct 2023, Fabian Vogt wrote:

> Like various other devices using similar hardware, this model reports a
> perpetually empty battery (0-1%).
> 
> Join the others and apply HID_BATTERY_QUIRK_IGNORE.
> 
> Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>
> ---
>  drivers/hid/hid-ids.h   | 1 +
>  drivers/hid/hid-input.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 7e499992a793..e4d2dfd5d253 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -425,6 +425,7 @@
>  #define I2C_DEVICE_ID_HP_SPECTRE_X360_13T_AW100	0x29F5
>  #define I2C_DEVICE_ID_HP_SPECTRE_X360_14T_EA100_V1	0x2BED
>  #define I2C_DEVICE_ID_HP_SPECTRE_X360_14T_EA100_V2	0x2BEE
> +#define I2C_DEVICE_ID_HP_ENVY_X360_15_EU0556NG		0x2D02
>  
>  #define USB_VENDOR_ID_ELECOM		0x056e
>  #define USB_DEVICE_ID_ELECOM_BM084	0x0061
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 0235cc1690a1..c8b20d44b147 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -409,6 +409,8 @@ static const struct hid_device_id hid_battery_quirks[] = {
>  	  HID_BATTERY_QUIRK_IGNORE },
>  	{ HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_HP_SPECTRE_X360_14T_EA100_V2),
>  	  HID_BATTERY_QUIRK_IGNORE },
> +	{ HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_HP_ENVY_X360_15_EU0556NG),
> +	  HID_BATTERY_QUIRK_IGNORE },
>  	{}

Applied, thanks Fabian.

-- 
Jiri Kosina
SUSE Labs