Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 4 Oct 2023 21:44:23 +0200
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] kbuild: remove stale code for 'source' symlink in
 packaging scripts
Message-ID: <ZR3Al3I1wPtCrnjy@bergen.fjasle.eu>
References: <20231001140339.1707548-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20231001140339.1707548-1-masahiroy@kernel.org>
Jabber-ID: nicolas@jabber.no
UI-OutboundReport: notjunk:1;M01:P0:SoTilS0CwDU=;iMXsUyCHU6UypIwJEWNKk3NkZqI
 oYm/GGDwTVRcJX1vhY06Ol3gcsduqTQAk2jG2OERZ1/lKuczHbMzKtUtl74DVX2NJYo3oEeNA
 RJF6NzDRgZjBrK5e9M2QG/kFW+YrpRdomjVKU/GkkKdgx7AuJiSVm3p9/SE/TMeprb8NUj6XM
 SzPFa7duOlyLbTYzsadbpjkvE+Izp4xdGgtUqNWZq4WRplyoRrX15kCo40WtO/r46loBvvm2/
 KyGzUbFcXzWaSpUMvD0oTZ76e82GMFXjBwwCHKC0bOGwKDKmrNiZFlugHf63wb5xva/tAiQQI
 x3VlUdv1lxkj1a0VjBLe92G5j/S/ulw82oUUsalEX9evfspGcxdXr9nSyYeDskhYxz6Atb+q5
 /YRFOJxmJNkTAskKCl5c2CT/N+ZC8l7uXm0u0mEA+NJ0hLpC+VOnYnCTzSJbvOHjSSYd68r1T
 WsHaEhaGSOh3zrGa6Y4p06yOhETwmRl8sVOfZiylCScfCLuQWSfvQ/IuacNgVP3wdyKtxUVLR
 GEcr5k1OY8gqfHkKvKiyCbyBVsR0ep7yfqsqjGW05/tXYxfGZxqX+Z1S8L8GX7ctgwHD8TtB6
 ElpK5oDsBUzCNrIS6x0uF39GfM/buFrxsyc2AuEYdIebsXj8Y6lmTuIExjrshQ0Xzkus8XAtM
 nwCWYPJXAggBh2Nen8NsW8pBLRJzmRkbZL+G6TIvHqXQ6lHIpmEyFmMQyMQp7zF4WMUITuvfr
 UtYO9rrIMpcxN+jaK5VV2yCuOpLmK2Muir0hxFIu9iJ5ilkM4TEkGZd352r0OjxrK9aebBYXw
 XL67WTu188+KBgMmw8Bz8ckhO9JoyDPS2yHDD6T5lhxJNc6I4LSzsqnJLQbVOIA+6Fiewu37c
 ks40rsDdP6X9xtQ==
Precedence: bulk

On Sun 01 Oct 2023 23:03:39 GMT, Masahiro Yamada wrote:
> Since commit d8131c2965d5 ("kbuild: remove $(MODLIB)/source symlink"),
> modules_install does not create the 'source' symlink.
> 
> Remove the stale code from builddeb and kernel.spec.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/package/builddeb    | 1 -
>  scripts/package/kernel.spec | 3 ---
>  2 files changed, 4 deletions(-)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index bf3f8561aa68..d7dd0d04c70c 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -64,7 +64,6 @@ install_linux_image () {
>  
>  	${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH="${pdir}" modules_install
>  	rm -f "${pdir}/lib/modules/${KERNELRELEASE}/build"
> -	rm -f "${pdir}/lib/modules/${KERNELRELEASE}/source"
>  
>  	# Install the kernel
>  	if [ "${ARCH}" = um ] ; then
> diff --git a/scripts/package/kernel.spec b/scripts/package/kernel.spec
> index ac3f2ee6d7a0..3eee0143e0c5 100644
> --- a/scripts/package/kernel.spec
> +++ b/scripts/package/kernel.spec
> @@ -68,7 +68,6 @@ cp $(%{make} %{makeflags} -s image_name) %{buildroot}/boot/vmlinuz-%{KERNELRELEA
>  cp System.map %{buildroot}/boot/System.map-%{KERNELRELEASE}
>  cp .config %{buildroot}/boot/config-%{KERNELRELEASE}
>  ln -fns /usr/src/kernels/%{KERNELRELEASE} %{buildroot}/lib/modules/%{KERNELRELEASE}/build
> -ln -fns /usr/src/kernels/%{KERNELRELEASE} %{buildroot}/lib/modules/%{KERNELRELEASE}/source
>  %if %{with_devel}
>  %{make} %{makeflags} run-command KBUILD_RUN_COMMAND='${srctree}/scripts/package/install-extmod-build %{buildroot}/usr/src/kernels/%{KERNELRELEASE}'
>  %endif
> @@ -101,7 +100,6 @@ fi
>  %defattr (-, root, root)
>  /lib/modules/%{KERNELRELEASE}
>  %exclude /lib/modules/%{KERNELRELEASE}/build
> -%exclude /lib/modules/%{KERNELRELEASE}/source
>  /boot/*
>  
>  %files headers
> @@ -113,5 +111,4 @@ fi
>  %defattr (-, root, root)
>  /usr/src/kernels/%{KERNELRELEASE}
>  /lib/modules/%{KERNELRELEASE}/build
> -/lib/modules/%{KERNELRELEASE}/source
>  %endif
> -- 
> 2.39.2

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>