Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Wed, 4 Oct 2023 13:09:57 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Vishvambar Panth S <vishvambarpanth.s@microchip.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        andrew@lunn.ch
Subject: Re: [PATCH net] net: microchip: lan743x : bidirectional throughuput
 improvement
Message-ID: <20231004130957.2d633d03@kernel.org>
In-Reply-To: <b1f64c44-0d1c-480e-a272-fb017e7d8673@gmail.com>
References: <20230927111623.9966-1-vishvambarpanth.s@microchip.com>
        <20231004122016.76b403f0@kernel.org>
        <b1f64c44-0d1c-480e-a272-fb017e7d8673@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 4 Oct 2023 13:02:17 -0700 Florian Fainelli wrote:
> > Nobody complained for 5 years, and it's not a regression.
> > Let's not treat this as a fix, please repost without the Fixes tag for
> > net-next. =20
>=20
> As a driver maintainer, you may want to provide some guarantees to your=20
> end users/customers that from stable version X.Y.Z the performance=20
> issues have been fixed. Performance improvements are definitively border=
=20
> line in terms of being considered as bug fixes though.

I understand that, but too often people just "feel like a device which
advertises X Mbps / Gbps should reach line rate" while no end user
cares.

Luckily stable rules are pretty clear about this (search for
"performance"):=20
https://docs.kernel.org/process/stable-kernel-rules.html

As posted it doesn't fulfill the requirements =F0=9F=A4=B7=EF=B8=8F