Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2849833rdb; Wed, 4 Oct 2023 13:29:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtvmvzGz5xK3ICLIS4aNRz0x/ROepTy/t2l0weuPvgYDgSGHcqlsfZ6I6sD0QP5m5COdj9 X-Received: by 2002:a05:6a20:7485:b0:161:536d:a13b with SMTP id p5-20020a056a20748500b00161536da13bmr3752097pzd.18.1696451340993; Wed, 04 Oct 2023 13:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696451340; cv=none; d=google.com; s=arc-20160816; b=WaJNq1oXbDO7xyX7D6yweUyFEhKbq4GhLK5MGdM0l8EqznkWknBXiPEtXYr5d+6Y7k dYZPmxecAB61MKcEVYyvKkwpKSkki4g0dLu4eup0m/mJi4qoo7kZ9/4SyTyh99E+zP3u aLq9h7BZFBrg7j9zBBzKrXph7fk51j8chMQhdxvhChVSWjNz3mALOFD5eH1r60QV/1rh 77RlqwacPujczSYNjAQCJjCmnDhTpzUL7AbejfE04fBhk4mQi/qrS4zEdMdyeCk17GoY vN30ZgNonTjM4eUAsS75ACB4EXo/wQtUgzlxrNb5p9X1dvAP3OMu7U0Dp5SkRphVbWoV tyMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=21cBEUSjF4TZhsDOLZLhdwXsG9t3AJsN/zN+Wwuijrc=; fh=rPfpQphCuiHjvLKYexDh1b5VKCnFfFBfJ/n84sNbZ18=; b=aX8K76yQVvHnpR2PtJhkuIC70IvOaIEpSODtzuJBJHwyDeqL3C0eDCWtuyI4aeCxqt Uh8WrwvyKXHZc1kh7zEZCAUR6099VP3fQMz7TibFiOmRLrWuHMC1m/3bsmOfCvIQzmdC Rw6qlxWruVIwsvRC97n5MtD3e/TRcDRmvCLJB30Yq4N+RBWqXZQ0wqnkEwL5lfNeAmd9 OYAYCthZA3Chu92F0E2t2vc4yB4lXoIVRD7xRbQ32X8wyenJvsj9TDJ3Wj2rjzD58TpV HurP+2A+t8PAdaYuvwQoTwvj8W+okTI69PzAGP/E2VzsxHQj5Jpn+VY8czBbu6JGVYup teDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=iNQChHV5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id d10-20020a170902654a00b001c5f5153e41si4263903pln.535.2023.10.04.13.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 13:29:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=iNQChHV5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C9118809ABD7; Wed, 4 Oct 2023 13:28:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233861AbjJDU26 (ORCPT + 99 others); Wed, 4 Oct 2023 16:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbjJDU24 (ORCPT ); Wed, 4 Oct 2023 16:28:56 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 638F993 for ; Wed, 4 Oct 2023 13:28:53 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-79fb8f60374so2714739f.1 for ; Wed, 04 Oct 2023 13:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1696451333; x=1697056133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=21cBEUSjF4TZhsDOLZLhdwXsG9t3AJsN/zN+Wwuijrc=; b=iNQChHV5T/CHEshLWavEPjwVYgN7joApUKBQw5QjJXJwv2cbQiZzV7JeTrpSQLDtWr xotZRQ61F8iIVJZAiIZwQTpi1sM7fG8wPE/jG6cFrCnsyb0irH7eFrB2YyE5Zuhy8ekN zI5te5lSEW++ea7So7iMd2bALval9dd1M6SVLIWB+H9V0WKsqagFRkjEd0qGElKnBsoh Y62SOQD7DVeAvof9TYGd+hs9i9W6bK9MiWjk7C5/JVVT2nRsxV9Q7me7lPAG7WZGASDy 7sxTb5IdLovYckPnBxCDY14UE/CoGD+q6jntvXKENwDjffqXU71qhqz6rce7Qtr/d1ew 98ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696451333; x=1697056133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=21cBEUSjF4TZhsDOLZLhdwXsG9t3AJsN/zN+Wwuijrc=; b=Z97f6XnLN38Phx6ZfZQxi0g3aQckmBJCnFBlYUb2C+yddV1opbmHYxFitCDC5X3kiM dZRrmxtBFl6XK1i9iFwS9t9NQfUwzxpkUU/mN9BHqifrHoseAfty3fUhW8GYmPOsjA/O 05l8/fWWSWraybyRxDfAw2j6rcvd009OMpCT0CW1UWGTcWJujqTZqkJFy6iHeSEbUdl2 zxEZn0MgkrBBOwiLxx3gTqE5mdmZ6oXLI3Ph+5cngbFR9kwCZdU459gkJyEZktnu1ENp 8TWHCajUgc1s7dph+/ZMwtvyaayqBjAJTnHRt5KEKl5fLlD9OuhMIV4AKkHqvQB2SPOf ZqoA== X-Gm-Message-State: AOJu0YwtadbLXGyQ3uhxK3iQcvvLGNWd5B4j1bUqYAq9kT1Bpb00U/oq gXJD5uVrjCyiiShbXnJnWxiBXlzC9nXwn/JQSak= X-Received: by 2002:a05:6602:3a05:b0:792:6be4:3dcb with SMTP id by5-20020a0566023a0500b007926be43dcbmr3319534iob.2.1696451332812; Wed, 04 Oct 2023 13:28:52 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id j29-20020a02cb1d000000b00439fa6ff6a9sm13989jap.70.2023.10.04.13.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 13:28:52 -0700 (PDT) Message-ID: <43b1a228-9a60-40ef-936b-c8a062d7eb21@kernel.dk> Date: Wed, 4 Oct 2023 14:28:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: Fix regression in sed-opal for a saved key. Content-Language: en-US To: Milan Broz , linux-block@vger.kernel.org Cc: gjoyce@linux.vnet.ibm.com, jonathan.derrick@linux.dev, linux-kernel@vger.kernel.org, Ondrej Kozina References: <20231003100209.380037-1-gmazyland@gmail.com> From: Jens Axboe In-Reply-To: <20231003100209.380037-1-gmazyland@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 13:29:00 -0700 (PDT) On 10/3/23 4:02 AM, Milan Broz wrote: > The commit 3bfeb61256643281ac4be5b8a57e9d9da3db4335 > introduced the use of keyring for sed-opal. > > Unfortunately, there is also a possibility to save > the Opal key used in opal_lock_unlock(). > > This patch switches the order of operation, so the cached > key is used instead of failure for opal_get_key. > > The problem was found by the cryptsetup Opal test recently > added to the cryptsetup tree. Greg, please review this. -- Jens Axboe