Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <36b17290-c643-8d8e-e82b-49afa6b34fbb@nvidia.com>
Date:   Wed, 4 Oct 2023 13:30:48 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [RFT PATCH 14/21] hte: tegra194: don't access struct gpio_chip
Content-Language: en-US
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     Aaro Koskinen <aaro.koskinen@iki.fi>,
        Janusz Krzysztofik <jmkrzyszt@gmail.com>,
        Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-acpi@vger.kernel.org, timestamp@lists.linux.dev,
        linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
References: <20230905185309.131295-1-brgl@bgdev.pl>
 <20230905185309.131295-15-brgl@bgdev.pl>
 <CACRpkda9=VULj4Cy_sit-UpUQnVEbS-RJKAeULVCw8ZCRTq1sw@mail.gmail.com>
 <CAMRc=MdTk1B4MEh9C624Upm_EcaQgJd9OU-AGfU0G-DU1+qk6A@mail.gmail.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <CAMRc=MdTk1B4MEh9C624Upm_EcaQgJd9OU-AGfU0G-DU1+qk6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG4ybHRBMTlzeC9GZzd0eFBNZ05YNy9PSkZLSzV0alJkS2VlSTh2S2NQeWVX?=
 =?utf-8?B?VUZjamErS0VSRGMzYWJYY3pVVFhLQlVsaXVSVDJ4M0QxWXNvU1dOV3p4TG9Y?=
 =?utf-8?B?NVlqdGJjRWdOUlVBbzZEZ3dMaTZoU3B5cTBsUEVGeHJoMkR1QTc0aGRYcDFx?=
 =?utf-8?B?aUlodVRTTlpQa0lqU1gxcTYyd3NOc3BTUURGU1Z1K3pBU1NsSHpqME9uRTFo?=
 =?utf-8?B?UWhRK1REV1J2STVpZ1lUSjFLL1g5b0NRRkd3UitxMkhRYzhQV0RWdGRnVm9L?=
 =?utf-8?B?YWcvZTlOOVIvLzRQcWFSS0NvQ1FCQXE0ZGtrWFFyZVJiRlQ2U2pRcWpFeDJX?=
 =?utf-8?B?eHNhYmhPVkh3Nkx3MjFpcDdlUzRDdGlBbzhRcnczbWFqdVRzVjQ5RGpVTjcv?=
 =?utf-8?B?cWRlTXovSk82alAvdWc5ZjJXYXBXa1JPNm1TZFBjSmJZNTRCTURQWm1JZWxt?=
 =?utf-8?B?SnE4OEp1ckhyMWh4YmFEcEZZVmxjKzVKdHZjOXM4RkZscnZCUU5LVG9ORHdw?=
 =?utf-8?B?RTl0NExMWXdVaGhGQ0lIZVZVZjFJc09tU3pPT2FySjdsODJ5ayszZWl0ajIw?=
 =?utf-8?B?R0xxWDVuZWlKUkRjOW9IT0Q5a1ZGUHppaTRzbkVFUHdnd2Mxd3FVZER2d24y?=
 =?utf-8?B?RUhKZFF5dTJtS3BHbDQ2czhIaVZTRDVvaXhjcGpOcFViWTNIa2JqN3dyK2Rw?=
 =?utf-8?B?WGNYU0NFb1I5UGpudTNPWkRuNUN2dGVpZXZwKzl4Z01ZN3VJQndaNStTNU1w?=
 =?utf-8?B?eHpJY280R3BqbkRweHFyNC9McXo3ZGcwRG9Jb3hobmZ0NUY2MDRvbURsQ2Rm?=
 =?utf-8?B?alFGakJoY29HMFdQdGhuTGJpQnlmcitMWGZMemdRS1ZaYkNwaW11c2FRR3FU?=
 =?utf-8?B?M0E4NWtKQmh4Ui9aMy9RT1VRdFczRDQ2dGRrbm9XRXVYWHlTZ01CMm5mam1H?=
 =?utf-8?B?ejVLdUlvNkNBMWVxV0tGbmNNWEdmb2VLWFY5dmx2WlJJRzVvYzNEZzZDNVdp?=
 =?utf-8?B?VHF3cGVIL00xODZTbXE3ajJUMXkvc1hkUXpTRDFhbXJ0SUhLSC96bnRrSWQy?=
 =?utf-8?B?UWZ1K1B5R0pWY2tkL2VKU1YyVmVnSmF6eThGZStCTS8wRkFjd1gxLzUvdEFp?=
 =?utf-8?B?Z3M5V0lNUjlXcUo1ZU81TWcvQ0xtVEdMOWxBemwreXNYbHc3RW1aeFlSMk1W?=
 =?utf-8?B?V3BsV21HVll5OWEvZmRTZEU0RGJPSzF2ZHhPdEVuTWZ0aGhMVDhleVM5ckdj?=
 =?utf-8?B?MU9nZEF0RWUrendDL29ZTXFWc3FOMkoyVkJ4UDNtYkVRbHQ2dFVCVWQ5YVJm?=
 =?utf-8?B?Qm9KOWhMV0FETGs2aks2M3pES0tKS2JtQXdzS1Q2a2ZiSkt4VjFZbjBmMlRT?=
 =?utf-8?B?TmZJSGZkU3l1U29BQzBtN1NPVEVCekZjTWVoMlJBSms2U3p2QmdqNFJqYmcz?=
 =?utf-8?B?d2twb1BuamF6U1NabXZpU3VYb0ZVdlNiN3hGdEFsOVE0b2MyMko1UXBGUldr?=
 =?utf-8?B?Q0NWZDhJSUxxYjJGUHJHTnM4NlBlZUd0N0dZRTFybmhYMlJXUVFLUjZPaEJt?=
 =?utf-8?B?eHp0ZWV6UUtlTkVTVEgveCtpNlRqLzNUWmwxZkZsZUVKRXBwRlJXc1FLbG84?=
 =?utf-8?B?RGtEbU1TaUNLeDl4b0Q5YStENWpKTjJGY3FzM3hGMHFxMCsyRDJEdGRNeFBY?=
 =?utf-8?B?dWJ2QWVIcjcxaTVHRzhzdVFUNHVST3BOOHBveFlWa3JkZkFHV1IyeXd5Vkpw?=
 =?utf-8?B?c1BFL0xSeEI4ZjMxckxzOUlRTlJVbGpPMUh3eUNUZE9nQUtXc0VGbWQ2OE9a?=
 =?utf-8?B?OXMwamtRZHBjVENRck01VDg3Y09hWWxueXpnUFpiUFZLby9yT0dtYnFZZlVE?=
 =?utf-8?B?WjRJUWRZeW9haVBSVmhtVUJRbmJTZzA2SS9OdG9yQ2twV1E2cDdEUjZSV2Z4?=
 =?utf-8?B?bUR2M2loYzJXaEsyQkJVSUovYXFNYnNhWmNtYTF1dXVLQkZ6TXRhVGNMbzZH?=
 =?utf-8?B?STZRSjBKS3daWkwwSzJFTlB6cW0zZTZTeUhQWk9WcDVqRGo0KzY0L21JLzg4?=
 =?utf-8?B?Ymk1Wkp1MUkzNW5lTU9Wc2JXRWdGb3pTYlY1TWFpWjJKUDNlcUJPQWUrVlE0?=
 =?utf-8?Q?P2nLnVN6mlmphJXeSUrxkpfgq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5815ba-b9c7-4984-64b9-08dbc518ce7e
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 20:30:53.9010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TvbePj7s31gzlnp1tkYpNiwLVbXetg++gOBV4FlWMFQUNOD7gmhJKLqBiv2zUphxkz8B9d0QKx+1Dkg07ZOXEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7828
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 13:31:11 -0700 (PDT)

On 10/4/23 5:00 AM, Bartosz Golaszewski wrote:
> On Thu, Sep 7, 2023 at 9:28 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Using struct gpio_chip is not safe as it will disappear if the
>>> underlying driver is unbound for any reason. Switch to using reference
>>> counted struct gpio_device and its dedicated accessors.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>
>> As Andy points out add <linux/cleanup.h>, with that fixed:
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> I think this can be merged into the gpio tree after leaving some
>> slack for the HTE maintainer to look at it, things look so much
>> better after this.
>>
>> Yours,
>> Linus Walleij
> 
> Dipen,
> 
> if you could give this patch a test and possibly ack it for me to take
> it through the GPIO tree (or go the immutable tag from HTE route) then
> it would be great. This is the last user of gpiochip_find() treewide,
> so with it we could remove it entirely for v6.7.

Progress so far for the RFT...

I tried applying the patch series on 6.6-rc1 and it did not apply cleanly,
some patches I needed to manually apply and correct. With all this, it failed
compilation at some spi/spi-bcm2835 driver. I disabled that and was able to
compile. I thought I should let you know this part.

Now, I tried to test the hte and it seems to fail finding the gpio device,
roughly around this place [1]. I thought it would be your patch series so
tried to just use 6.6rc1 without your patches and it still failed at the
same place. I have to trace back now from which kernel version it broke.

> 
> Bart