Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3624e973-d09a-d211-c6d0-d0ffb8c20c4b@nvidia.com>
Date:   Wed, 4 Oct 2023 13:33:47 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [RFT PATCH 14/21] hte: tegra194: don't access struct gpio_chip
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     Aaro Koskinen <aaro.koskinen@iki.fi>,
        Janusz Krzysztofik <jmkrzyszt@gmail.com>,
        Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-acpi@vger.kernel.org, timestamp@lists.linux.dev,
        linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
References: <20230905185309.131295-1-brgl@bgdev.pl>
 <20230905185309.131295-15-brgl@bgdev.pl>
 <CACRpkda9=VULj4Cy_sit-UpUQnVEbS-RJKAeULVCw8ZCRTq1sw@mail.gmail.com>
 <CAMRc=MdTk1B4MEh9C624Upm_EcaQgJd9OU-AGfU0G-DU1+qk6A@mail.gmail.com>
 <36b17290-c643-8d8e-e82b-49afa6b34fbb@nvidia.com>
In-Reply-To: <36b17290-c643-8d8e-e82b-49afa6b34fbb@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTRiOWV2dHN5S0tjZUVhbDRxckdaVFRkNXNYM0ZtNUh4eFBYNngzMng0ZURH?=
 =?utf-8?B?Ny9XSmJOTjlTWEdRbTlIN0EvWURxeE1FaFZTVEVDcmpGZVoxZHpiZlJ1Skdr?=
 =?utf-8?B?RzNsWVp2MjFDT05Pc2d0NGdQMVBlVkZTZGFvRkx4aTN6K3FGV2JaamZQMFBT?=
 =?utf-8?B?cFNXc2dQbTlvZEZTQjF4UTViTWZpOUJrR2dJNGEraXN0dU1pck9NUFdqVy9H?=
 =?utf-8?B?Tm5sY2RJRG4yOFFScFBIODBvSmZUeHBPWitWNmQ4RUNWaC92T2t4OVUvcEFH?=
 =?utf-8?B?UTRMS1hmdFlsTEdnUEw5L2JjUnZFd0VENTNOa2I4N3RDR1dZMVo3ZWtQOXQx?=
 =?utf-8?B?SVhSUEgvUS8vR0JYRStKZWhuOURkaWNIbm8yZmkrR05TUzRjTlFleXkycnZJ?=
 =?utf-8?B?VnJKOE5UWjB4b3Q2WFVYYzlsRTlDaGtvSlV0cUZMTVVrZzAxeWZTSnVzR2ps?=
 =?utf-8?B?cjl2UmF3eUFmaHhzbU4rUTVrbTZCMFkwUSt1aFVSMkhTTm5EOWxseUpyQ1d5?=
 =?utf-8?B?MVVrSlBJL2VCeWJqbSsxTzc1Nlh6ZFVlblFQUS9BWU9vMTU4R1dla0I4cStH?=
 =?utf-8?B?UUIzTS9OMUZpR1FlZGJQTnQ2MnNYaGExQ3lTaU8yMVZWOUZRMDU3N3poTVNi?=
 =?utf-8?B?RlN2VFllcHpiQ21DZ2FKb3Y2M0tyaVByZ09HYnhjbzJSNmVCS3pUVWhsWkZZ?=
 =?utf-8?B?Und5M09zM2JjMER4cGNiTmp1LzBZbHpVK1lISCtNMVo5bWNLRTJwUFVYZ2hG?=
 =?utf-8?B?U1ZCbHRiamd1K01KSVo1VDdsWlBaZk9aUzNtOUR3YUZwM3JTVDVNOXZFRmJQ?=
 =?utf-8?B?bXQwVUVTOFpMRTJodzdSZGVRU0wwUFVDZmZuR3Eza3UwWFIzWUNjRzJ3akUx?=
 =?utf-8?B?Zk83b24vNjY2VEFKTnFEV2NOb3NwWm9oRHJCWEViL0IyZnl1cW9GRXlpbzFP?=
 =?utf-8?B?U0c5cml1UklKSG5Nc0R0WTAzUVh3QUFNbkVBSlAvMENwQ3JTRThoQU9BRnNH?=
 =?utf-8?B?S29WdmpYSytFaTIwM3V3UVAvZ3hITUh3Y1lPU3l6a1BHK2U1bjRXMW5peE12?=
 =?utf-8?B?U0V0Vk5vdGloUzZVMkw4bWlNK00vYTdkWlNPWXkyNWE4TXM5REY2UmhtMGdS?=
 =?utf-8?B?TDVqQzRMMldFUk9xSHQwdGlpa1JzaTB5dlB5MFFhR2d6d3RyNURoQXB4RlA0?=
 =?utf-8?B?K0pldUNYbTNVb283cjFBNnFVeFhpb3JTc0ZobjJISElEYmpRbEpiWjc2NW1k?=
 =?utf-8?B?UHlYYmlTWWRVdFlGRGcvZW9KeFQrWVZlMERpNFY1N1RIQmR5R1k0QzJFSnZu?=
 =?utf-8?B?M0o0RUNENFdKck50QVZpVk1CbW1jWjVlMGlObWdGeHlENWVZUVl0MFg2VXRt?=
 =?utf-8?B?R3U4T2U0dWE0VGl0YzBnYXlSdHdrc1BJcU1mMVplQ1VZK1BYbWdlY2dmNHVM?=
 =?utf-8?B?aURFOVlGZ0ZOYys1QnFuRVlITHU5UHNsN3hJY1hBbjlaNlI2SHJGRHVCMTZG?=
 =?utf-8?B?L1VMbDVvaEhoTGQ1OSt1clNqcE56QjNxZmxQWFFCa3RUbjJzem1tQjVjK3BM?=
 =?utf-8?B?Zi9IWGJVTXExZjVnbm5MbTFQNTF5TURobWd1dktIMEpiS25La1FMU3dIMGs3?=
 =?utf-8?B?aTh2NTN3ZVl1SHlsMDB3WnlPQUUzYjN0SlQ3aWFQNGw3TFVTRy9LOVRSTUg5?=
 =?utf-8?B?Yy9pOTNmTHRQV0FDcEdLOG42ZzhFMk1aM3BaMGdaeGRwa0VEYmxmcDJXRVFT?=
 =?utf-8?B?ZFJrS255M250Ni9uaVNyQlkzRHB0WFZCdVVJK3FwRGFqa1ZHT0I5dkhubE1x?=
 =?utf-8?B?NXJqY3UreXJONzNBUXN1SXpnc3VRMk5zL0FLVjB5UStncTdaOFhRMmdPWjN2?=
 =?utf-8?B?Nkx6RUZXMmJheG9CdXNGeGZ5MDYzR1BOdDduYkhGNU8xV3A4RitBRXE3REt1?=
 =?utf-8?B?cytYRGpRSDBFTHVjWVRlQkhHSU5KUlQxMU9qOE42WDgvZmdKWnJhNDVWK3Ra?=
 =?utf-8?B?ditFT1dUSmdvbFFJVnNvMnE0cWVpNVdNMHRvNXRxYUZQRWI5QnM4MEhuR016?=
 =?utf-8?B?aktLck9HQnZ4ZlFLN3RBUFVYNHMwRkF5RU1najdsODZDWHZlZDdzenMySDNC?=
 =?utf-8?Q?9vw4BLdCtqji8i4gA13gN1Vtc?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeec5d26-57e1-4b5e-a65f-08dbc51938f3
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 20:33:52.5829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FeKJTYYisiRDDGj+V0k86xFyvzy7Qgo9gKTxJkYVkGZtpyD7K5tkh+BPy6YrCk1dI7jSp73R2M5rym9mH9LBcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8997
X-Spam-Status: No, score=1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 13:34:13 -0700 (PDT)
X-Spam-Level: *

On 10/4/23 1:30 PM, Dipen Patel wrote:
> On 10/4/23 5:00 AM, Bartosz Golaszewski wrote:
>> On Thu, Sep 7, 2023 at 9:28 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>>>
>>> On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>>
>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>>
>>>> Using struct gpio_chip is not safe as it will disappear if the
>>>> underlying driver is unbound for any reason. Switch to using reference
>>>> counted struct gpio_device and its dedicated accessors.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> As Andy points out add <linux/cleanup.h>, with that fixed:
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> I think this can be merged into the gpio tree after leaving some
>>> slack for the HTE maintainer to look at it, things look so much
>>> better after this.
>>>
>>> Yours,
>>> Linus Walleij
>>
>> Dipen,
>>
>> if you could give this patch a test and possibly ack it for me to take
>> it through the GPIO tree (or go the immutable tag from HTE route) then
>> it would be great. This is the last user of gpiochip_find() treewide,
>> so with it we could remove it entirely for v6.7.
> 
> Progress so far for the RFT...
> 
> I tried applying the patch series on 6.6-rc1 and it did not apply cleanly,
> some patches I needed to manually apply and correct. With all this, it failed
> compilation at some spi/spi-bcm2835 driver. I disabled that and was able to
> compile. I thought I should let you know this part.
> 
> Now, I tried to test the hte and it seems to fail finding the gpio device,
> roughly around this place [1]. I thought it would be your patch series so
> tried to just use 6.6rc1 without your patches and it still failed at the
> same place. I have to trace back now from which kernel version it broke.

[1].
https://git.kernel.org/pub/scm/linux/kernel/git/pateldipen1984/linux.git/tree/drivers/hte/hte-tegra194.c?h=for-next#n781

of course with your patches it would fail for the gdev instead of the chip.
> 
>>
>> Bart
>