Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <b31e1fd2-31b6-4240-94e7-870bcfd51754@amd.com>
Date:   Wed, 4 Oct 2023 15:38:03 -0500
User-Agent: Mozilla Thunderbird
From:   "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v6 09/24] x86/resctrl: Use set_bit()/clear_bit() instead
 of open coding
Reply-To: babu.moger@amd.com
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        shameerali.kolothum.thodi@huawei.com,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        carl@os.amperecomputing.com, lcherian@marvell.com,
        bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
        xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
        dfustini@baylibre.com, amitsinght@marvell.com
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-10-james.morse@arm.com>
Content-Language: en-US
In-Reply-To: <20230914172138.11977-10-james.morse@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3pnWEswenBSQzJ2bXh1Z2N4QkVJd21HSGg4ZHUyaHFKcGo5UUhPUHBQbDB2?=
 =?utf-8?B?cjdXOU14ZVBySCtvSkp5T0VCdkZ0eldTZFVSclhTWmlzUnVCaVJXTlVBSWd1?=
 =?utf-8?B?ek5tOTM0QXJsWlNaQ09DaHFJZEpvZU5pa1diZDhSaDNqclVLelhpejdGOU92?=
 =?utf-8?B?bEY1SzltNjh1OUJ2MkozS3JWRks3UEE2em5rcjVJaGdwbXRQS0JBRmhWUzJn?=
 =?utf-8?B?Vmg4ejhNQlQ2d1hDdEE5YjVOaHZ5czRPaGJnalhTSFdxWVBveE5YUW5DVFhL?=
 =?utf-8?B?Zm5pN1dncTdNbUVOaC9GSmIyZDZnVjFQSDd6WG15K1hoTEJDNUxuM2ZTcmtP?=
 =?utf-8?B?Nm96STBTZ0JPV090OHl5NzgvUExxQUhkTHRDTUFKOG5EU0VJUWQ0NXpGQS9Q?=
 =?utf-8?B?b285eTRaUVpPWE0za1VzcWptbG5obWYzeXVmMGQ4T1hCWm5TMFZzaStQWGdj?=
 =?utf-8?B?UVo2T0h1NDV1c0d5STRCQzR4MmNXaHA0WWNHb3lacnRMZWpkSmJ0b3I5WVA3?=
 =?utf-8?B?em5JQ1o3Nk5DOTFJcTVzbjh6c0doWVQyZERMY1BzQWVnbVB0MUkxazZrRUdD?=
 =?utf-8?B?djNRODkzRWxPVlVJaXhSem5tR2JPUkFnbGE1STlDRndrbDRXRlNOYTBjaU9E?=
 =?utf-8?B?dWpyOVlTcU5JOFhSdFBwYi83Q0FTUFRrcG1wNnhTN0xnN2YrZENpSWpFNEUx?=
 =?utf-8?B?QmJGQUFPSjdyYVVWSGhsbXNGdHUwNHluZlVvcTlGQlI2dHJleXIweXlCMEM2?=
 =?utf-8?B?MTUveGtGQWk1TEtzY2JtQXlUekhHaUlRdHBZTWc4VDE2VHJ6bWNaUUF3dmJQ?=
 =?utf-8?B?N2I4M2V1blkxRnMrS2U2alBSV2pXNThIU1hpK1pLbVNvcTd5M01vY0h3a09S?=
 =?utf-8?B?enlXYWlzRUdUaTBLTGpTUk5uRnVuTk5IcS91V3psSU41czBtek1GVGo4d1ZC?=
 =?utf-8?B?L0lqb2dGam1mbGVGZUhSOGhlVjZkVElBYk9JOVhKQ05NakNaUzA2cmdpb0No?=
 =?utf-8?B?Z0RaV0g3cEJ5L3c5VzlHRFBQc3ZmT3plSUxtaHZzelNNdWhLRVE5amRMTTkv?=
 =?utf-8?B?QzV6c2dCOWZjWjRIcVp5SDZkRkUzWit3WEhWQ3lNU04rK3AzZFRPNCtNdVlQ?=
 =?utf-8?B?amRwdFlPOGpiVEdwUi9TendwRTNxeTA1Q0FYak5ENWQwcXZ3OUw4ZzdsL2Rl?=
 =?utf-8?B?aFI5bGNiUCtiUjZBalk4NmptL1RvdWlERStmVUo0THFoRi90bGVscEZMSDBR?=
 =?utf-8?B?YUFxSTE5WkFCRSsyamZhd3BDN0NQbnFGYlJSMnhnZWwzQWZTMEtvcXgvNWpV?=
 =?utf-8?B?YUd4M0xCZ04wRTFsWnNmMUlyWHorZ0ZQOTlyV0x5Z0lMQ2ltQVlZMkVVcE9N?=
 =?utf-8?B?NWk5Q2I5RmYwTkIydkh6TllqakpQR1Z1aGJLZ2hiUjdHUm14VzNPSzBIeWxo?=
 =?utf-8?B?ck0rODdLUko5SWtRQWE2TzFSaDdiODdtSkYySXB2SjZHM2EwMEN3Tno0WXVT?=
 =?utf-8?B?cWlWQ0diTG9HUHZQN2NkMDBjejI5R3ZXMGQzOGJOclpZQnEvR0JuUHRselBn?=
 =?utf-8?B?STlSbXhJNGNpK1VMMW83Y1hRd0VpUWYvMWROZnFvMXp5YzliSE04bXQvY2Zq?=
 =?utf-8?B?YzgzL1hXRktEV0tiUDRQZEFYMkU1Qzh1LzlxOStWcnBkNUNIVEdGcFlyNnhO?=
 =?utf-8?B?VzFEejQ5aUJWQWt2dmtrcDEwVkREUGJaVlgxSE96a0ZlV1FMdFBvN25uY2Rr?=
 =?utf-8?B?MHRyUGJEQUxYVmRCUFJpMmlqcHpzVUpWem9STGlWSmVDZ2ZTYmhOQ3JwaFpD?=
 =?utf-8?B?clZhQXVYdG9sVzVheXc2T2Qrb1BWMnZGQnprd1pUKzlyaXpQNzY1bkl4eUYz?=
 =?utf-8?B?OFhlUENKdVFLMDY3ZHV1ODZFWGpJYWowUnB6WVZWWElBc2ljL3VMUnBhZmxB?=
 =?utf-8?B?WFBRb094aXJXWlpYTXZOd1d4cHIxb1FUZ0hXNWxSaGVqVDNCbFVlNjJ4WkJo?=
 =?utf-8?B?czE2SFBYL0l0OGdQQnhydVUrUzI5VzVQMi9IYldZMW1Yb0tJK21zUzlLbGxR?=
 =?utf-8?B?SVlOYnlmTGdyL0dKWmJQMWJzQ1pmYkYycUk4dnBuZmd4VXpScUxYa2o0T3Qv?=
 =?utf-8?Q?R/sE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92e2fd09-9edf-481c-9cb5-08dbc519d0a6
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 20:38:06.9781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJ0jP4BUZad5OSiY/OkHb4Z0LlCKyPuKXdtG97e+r7vNkKoolnW0S+zt/3wsrsLv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6777
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 13:38:14 -0700 (PDT)

Hi James,

On 9/14/23 12:21, James Morse wrote:
> The resctrl CLOSID allocator uses a single 32bit word to track which
> CLOSID are free. The setting and clearing of bits is open coded.
> 
> A subsequent patch adds resctrl_closid_is_free(), which adds more open
> coded bitmaps operations. These will eventually need changing to use
> the bitops helpers so that a CLOSID bitmap of the correct size can be
> allocated dynamically.
> 
> Convert the existing open coded bit manipulations of closid_free_map
> to use set_bit() and friends.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index ac1a6437469f..fa449ee0d1a7 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -106,7 +106,7 @@ void rdt_staged_configs_clear(void)
>   * - Our choices on how to configure each resource become progressively more
>   *   limited as the number of resources grows.
>   */
> -static int closid_free_map;
> +static unsigned long closid_free_map;
>  static int closid_free_map_len;
>  
>  int closids_supported(void)
> @@ -126,7 +126,7 @@ static void closid_init(void)
>  	closid_free_map = BIT_MASK(rdt_min_closid) - 1;
>  
>  	/* CLOSID 0 is always reserved for the default group */
> -	closid_free_map &= ~1;
> +	clear_bit(0, &closid_free_map);

How about using RESCTRL_RESERVED_CLOSID instead of 0 here?

Thanks
Babu Moger