Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2855262rdb; Wed, 4 Oct 2023 13:41:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSk90Gm1IVHm+C124Xe2y6goSOTYqn8gDH64rv7wQCGIyw/lsSSA4BvyBzj/X2ua2UkMiu X-Received: by 2002:a05:6830:1e53:b0:6bd:b0c9:a89 with SMTP id e19-20020a0568301e5300b006bdb0c90a89mr3126565otj.2.1696452081594; Wed, 04 Oct 2023 13:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696452081; cv=none; d=google.com; s=arc-20160816; b=yXs07XEcCRDckAs5S2/U9P3fXiiYVF31DAkn1wQCSCAcLAw0hVZbVGg66BFBcS+oXq KItrFEnJhTq+vPp1K4n5I4GwxvioDfSNZzwjcTNWW8cn2SvpqMR3cDv85L50uaPL7SIh F1gny9Yb8EwalxT10+F2tDFcyuwx4zYR8fHBvvFAopm6+f7IeRwueu9M2BD7fEKx0yDt q5T9+BpTEQGYLqSaJKPQK7hzuAsZrfJUPvWE+3QtZ2f42JnNc811US1DONFHm96d9Xap USPQzQgK7X9iLeMk+ytvOpLOVSskb+MFU8lVvp0/BXAZkt7xlfowSFHcSmXyhQqmdl62 tpcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=I/wbZPm+OrPPmkZFyRWov1e0U4ABnjL9CoxxjI2WyQs=; fh=0K17BQz8IdqT/cHLmYMqm8L9HRwLjy6eE1dMM32/e+E=; b=nWClphzvmXKYr9xHHWUArKKrCzyAf+WkfLgmuF2qD0tW6vo4CvQOSdfRct0bqgKQ6s FBlA9YXvSo0F4793k3HiktrfUSU/GTjkomWEQM05qgTbBKrtobTTy0DsgCI0prIVD0UW lYl9asPgOZA1rr1b4QNusVKxhM6xl11tgZEcCDD/2e5vTu27lIei4i8hr5VdRqF4zPNb hwFyDcyAfLXP5cvw4gtnCRtLbQHGjOCuExYms89aTOFSjAwXbTH+orA0h/E1StU5tWLM arKb+YLqKwH4QP96oYY+Bi55N1iSc6jwFTxDKJuvCWo272Yj68XZ9Oc0ahkRuvWIEyBh L72A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atmaCxJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id b9-20020a63d809000000b0055fc5e67d56si4484084pgh.7.2023.10.04.13.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 13:41:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atmaCxJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 63E1C81F340E; Wed, 4 Oct 2023 13:41:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233557AbjJDUlM (ORCPT + 99 others); Wed, 4 Oct 2023 16:41:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233243AbjJDUlL (ORCPT ); Wed, 4 Oct 2023 16:41:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 787139B for ; Wed, 4 Oct 2023 13:41:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650C3C433C8; Wed, 4 Oct 2023 20:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696452068; bh=72lPpExPa7/l8tL0qUn7j7l+TWc7n+AL+YkQK0hH4Rs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=atmaCxJFjkuoGabbdB9Yr5oZJNjn/Bdzqi3HITjYF6aqnSMDpHMH5bfp99hp4hu9S ZLej3ZVqDIlgcOCVWEh/z1TfL0JlJy7ejY/tVkUEWh1lkzML859fY26D21NbzrJ6oS mZcJ+vs7HWLQWYMCkiilFAeuUE/i91yUMQRGVUSmATPRArfZ/68UMXOIcLCjXFgITR wVUTJ633op4v50sGt+9IYH/R3RFQhOsfrKs39O9GDD2IyBBuYeIH5PxlHeeAI3bdao DlShNOOgHT0wJGGHJbTENeMzo8Da3kPKTYi2A+7IvcTnZxvavLahGW7enZIs7mVro3 9tzhl8wqhc7fQ== Date: Wed, 4 Oct 2023 13:41:06 -0700 From: Jakub Kicinski To: Radhey Shyam Pandey Cc: , , , , , , , , , , , , , , "Sarath Babu Naidu Gaddam" Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support Message-ID: <20231004134106.7779c29c@kernel.org> In-Reply-To: <1695843151-1919509-3-git-send-email-radhey.shyam.pandey@amd.com> References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-3-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 13:41:18 -0700 (PDT) X-Spam-Level: ** On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote: > */ > -static int axienet_open(struct net_device *ndev) > + nit: spurious new line > +static inline int axienet_init_legacy_dma(struct net_device *ndev) nit: no need for the inline, it has one caller and isn't on the fast path