Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2899054rdb; Wed, 4 Oct 2023 15:25:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyT76OQNYxnH8Q4z4h6A+noDvLeqi+88JgUQl21BxXt8wlKPKB3NUQfH9FKKkJ76bDaStv X-Received: by 2002:a05:6a20:5648:b0:163:b85e:6337 with SMTP id is8-20020a056a20564800b00163b85e6337mr3497168pzc.38.1696458300028; Wed, 04 Oct 2023 15:25:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696458300; cv=none; d=google.com; s=arc-20160816; b=e7bqXRr+dculzaRqR/d87ThqHkebSA1UpPaOzE4lfVYje+vv6T5ptR92ua4YubuL6H u4/pVGyGHhwIRehHYqfxldobnZ7WWMU/VfDbqkMsLW7O50skqQO2eVhhYGhRpqOxJal8 Dx28wue9q9IjiWeWyHCaf0P8GeYrSpfqSyAoJuYtWXOOa3mpf70R0wUFVMOEi4/pZFiS CX1ZPpidy8ziXmizfJHSNsCP/s1w4VHW9d5QAgjWzxGtIS+4fh5LK1n2DXJhADqHsH72 PGpgoEQaeLmjo5Q5MtSPff1FF2TqAoCu+m5UI7U40xGH3mdbJ1XMTbJiKmn880x10VmT BBPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=rZEPDMNKYxxc1y/Lg8uXbOfwUDjfLMxGlYiDmv2DKy0=; fh=bp0x7EehBz+suFbB5RPGPPH8NfVKAE7MvL8HdzxIF20=; b=MAuwnb9drycS/iZhAouQafRSkwWH6kDGGyQV1vX1R/5X7tuSgegK6hFXYp+rrkrl/A zVJxh09RxTifeshqqcMCXlR1flqZ+1JhK837yl8Voe9Y/oL+y+xyhlYWcFjX9bqLp0DL Kginsy6Ix6Ci7nmKq3M3j5nhQANCCF7ci3DGq650OPEh3RmfUIhptHV50+a2dh8spI07 qDFw1VRGkVJKUrlsSlxMdod0fWpnhsizCvsn4EftHj3luu4XILXACymBcYH75DdTMEi/ 6OCmqnvZXef0FZPb9VVteBFozAsq/xcftL6yPPItgFcYNyrnxpg7wE979bbeTwoNBFUt oUaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=F5MZyLh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ck13-20020a056a00328d00b0069343bdd500si46170pfb.319.2023.10.04.15.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 15:25:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=F5MZyLh5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 17C5B826FABB; Wed, 4 Oct 2023 15:24:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233517AbjJDWYc (ORCPT + 99 others); Wed, 4 Oct 2023 18:24:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbjJDWYa (ORCPT ); Wed, 4 Oct 2023 18:24:30 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B45EC; Wed, 4 Oct 2023 15:24:24 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 070B720003; Wed, 4 Oct 2023 22:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696458263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZEPDMNKYxxc1y/Lg8uXbOfwUDjfLMxGlYiDmv2DKy0=; b=F5MZyLh50CqykMPgDt4SoT8jABGpLvGTQmWqAH1oKxPi9ISbpZ1bcQhF8L82NNNCZUF4td STe03+qh1fT6FcGgGLxf2XMhEmQDqksoXUidjFwK6rIxQi4DxtPI7CiFCj5nomM+yI9mK7 Lms3vpQ58rf4An1FIeFQGmagLIod3PLuEx9x1yydigKLXKrmKgOyCHjbP3Z6pF1GHFZsEI aP/o4+huX6Vm0bHF4pqKY3bp5t8kZNlpezxh56xhq7P6uwSJcH0Y+EgPmcJiZlWNFoA1eu tU4Hjbzb3QhpPvCEFP1Rs4xs4B11bepJNjp91M2sl0vY5rStDv7pZyGXMdBkGg== Date: Thu, 5 Oct 2023 00:24:20 +0200 From: Miquel Raynal To: Ralph Siemsen Cc: Geert Uytterhoeven , Linus Walleij , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX Message-ID: <20231005002420.7d03bbd8@xps-13> In-Reply-To: <20231004200008.1306798-1-ralph.siemsen@linaro.org> References: <20231004200008.1306798-1-ralph.siemsen@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 15:24:57 -0700 (PDT) X-Spam-Level: ** Hi Ralph, ralph.siemsen@linaro.org wrote on Wed, 4 Oct 2023 16:00:08 -0400: > Enable pin muxing (eg. programmable function), so that the RZN1 GPIO > pins will be configured as specified by the pinmux in the DTS. >=20 > This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS, > however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02 > since the rzn1 driver does not call any of the generic pinmux functions. >=20 > Signed-off-by: Ralph Siemsen You probably need to point at this commit with a Fixes and possibly Cc this to stable. Also you should use proper formatting for the commit (12 digits sha then the text inside ("...")). With this added: Reviewed-by: Miquel Raynal > --- > drivers/pinctrl/renesas/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/pinctrl/renesas/Kconfig b/drivers/pinctrl/renesas/Kc= onfig > index 77730dc548ed..0ad8e14ccc52 100644 > --- a/drivers/pinctrl/renesas/Kconfig > +++ b/drivers/pinctrl/renesas/Kconfig > @@ -234,6 +234,7 @@ config PINCTRL_RZN1 > bool "pin control support for RZ/N1" > depends on OF > depends on ARCH_RZN1 || COMPILE_TEST > + select PINMUX > select GENERIC_PINCONF > help > This selects pinctrl driver for Renesas RZ/N1 devices. Thanks, Miqu=C3=A8l