Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 5 Oct 2023 00:24:20 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Ralph Siemsen <ralph.siemsen@linaro.org>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX
Message-ID: <20231005002420.7d03bbd8@xps-13>
In-Reply-To: <20231004200008.1306798-1-ralph.siemsen@linaro.org>
References: <20231004200008.1306798-1-ralph.siemsen@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed,  4 Oct 2023 16:00:08 -0400:

> Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
> pins will be configured as specified by the pinmux in the DTS.
>=20
> This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
> however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
> since the rzn1 driver does not call any of the generic pinmux functions.
>=20
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>

You probably need to point at this commit with a Fixes and possibly Cc
this to stable. Also you should use proper formatting for the commit
(12 digits sha then the text inside ("...")).

With this added:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---
>  drivers/pinctrl/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/pinctrl/renesas/Kconfig b/drivers/pinctrl/renesas/Kc=
onfig
> index 77730dc548ed..0ad8e14ccc52 100644
> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -234,6 +234,7 @@ config PINCTRL_RZN1
>  	bool "pin control support for RZ/N1"
>  	depends on OF
>  	depends on ARCH_RZN1 || COMPILE_TEST
> +	select PINMUX
>  	select GENERIC_PINCONF
>  	help
>  	  This selects pinctrl driver for Renesas RZ/N1 devices.


Thanks,
Miqu=C3=A8l