Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 4 Oct 2023 16:18:02 -0700
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Shubh <shubhisroking@gmail.com>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: refactor deprecated strncpy
Message-ID: <20231004231802.GD3553829@hu-bjorande-lv.qualcomm.com>
References: <20231004044017.37027-1-shubhisroking@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231004044017.37027-1-shubhisroking@gmail.com>
Precedence: bulk

On Wed, Oct 04, 2023 at 10:10:17AM +0530, Shubh wrote:
> Prefer `strscpy_pad` to `strncpy`.
> 
> Signed-off-by: Shubh <shubhisroking@gmail.com>

Please spell out your name on future patches.

> ---
>  drivers/soc/qcom/cmd-db.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 34c40368d..dc42704d7 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -152,7 +152,7 @@ static int cmd_db_get_header(const char *id, const struct entry_header **eh,
>  	 * query string is not necessarily '\0' terminated if it bumps up
>  	 * against the max size. That's OK and expected.
>  	 */
> -	strncpy(query, id, sizeof(query));
> +	strscpy_pad(query, id, sizeof(query));

Please read the comment above, and please read fe72f9bce137 ("soc: qcom:
cmd-db: replace strscpy_pad() with strncpy()")

Thanks,
Bjorn

>  
>  	for (i = 0; i < MAX_SLV_ID; i++) {
>  		rsc_hdr = &cmd_db_header->header[i];
> -- 
> 2.42.0
>