Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2925182rdb; Wed, 4 Oct 2023 16:28:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpGeeQv8Czyd4nKLkPaoy0gYpzp0nZIbBWDYlCJWCgnyxIq9Lifp+ihNY4F4IylVv5XzX+ X-Received: by 2002:a17:902:bd47:b0:1c0:774d:9342 with SMTP id b7-20020a170902bd4700b001c0774d9342mr2937270plx.25.1696462130386; Wed, 04 Oct 2023 16:28:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696462130; cv=none; d=google.com; s=arc-20160816; b=OX44ipgx8KT/SWPdsKleqKCfM7V/PYB9zQ1zNu5FrrJbXKI0ZCIr/pc6luwwN4NVu6 KQjDZpTYdIEXcagqEbVzB6xOdirf40HNWnBBpnTbNW0p47l6I3aLkHY/GkugJYXhBjJA StBD7u7xZJAi2mRbfpSRjiYGUAO3P7Ptu4Nb6R57f8KVgeQL9S7uATiMm4mSnUgrMJD/ XdZvfIOv+oUpkMJgFl+XykT2OPkS4+N5JG8misvTE/kh4LapjlRj6FTOuWpKtOU1WZcM L4k6vtRRc3DgIubtncKPGCtSeAD2trfEr2h8bQArADx7u/1lOoDftQdhDFjBq6NgyXSq VOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1m40f163eO+xo3Lg1S7s1hOJmalpK/V1zoX+a2IGUKs=; fh=+2hWFWnRP6rSdsoP4znFykeKTs25yqF1m3Pm5n1aenQ=; b=jtXz7FeBUSU79nkdbeeiyibEoRFt2S8xJ7WYvqg4+Xv3miTYWq8w7T1pA7K3ZU766I gjTjk3ebpBrSeHKhm7Fz8TbheMF37J+x/tucBYy2hS3PjQm8ZHvLa8rKB52R5a0vDBpF KLD7jb3FvGaq68EpyYmWT8MWj2GNHrf11p+T7MZc9mnYIM7/snY8WpazeZAZa4n0ad7T pI1yux4YsId1C4l12Grjd+792oT1G7xB3p3U2s4+ikW8OxeKKTM26AoiptdvWwf7rahB fzWKRA06N22ktFemZq1EAC8INgKP20CGwPbUoF8dhqugQ/EOeGY59Jyrna2AUNp8/dwq 2TDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L8EfGQ55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id u11-20020a17090282cb00b001c60502ccd4si199777plz.642.2023.10.04.16.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 16:28:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L8EfGQ55; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C3E8681DDBC8; Wed, 4 Oct 2023 16:28:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240754AbjJDX2g (ORCPT + 99 others); Wed, 4 Oct 2023 19:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233350AbjJDX2f (ORCPT ); Wed, 4 Oct 2023 19:28:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3311C9 for ; Wed, 4 Oct 2023 16:28:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A5F1C433C7; Wed, 4 Oct 2023 23:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696462112; bh=qbZU7R3Zsw96CbqqTm9vDJi7eGwTuFjG+uwNT9ctvJY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L8EfGQ55WKi2LtRA9Xq3ybLy4Wo7O+1h42hkjCU7fXyLjgOwfulSK88we8iNeXqMg 4WNGn9C+lCAzRAU/+j7fLKqOXpcNguoZXELO17m/GIBD1XQpBLMUKAwPizMkYrLY9M 8aoFnvoq7EuL3yA+tS6n85VijY+Fq3YDH7dVhSSNkClHBSEOzqZgt42/RksJXBJoQP J4OAuBhXO9SaGtypP7nm3WuD6IkXmrkny8BcMfMHO5dyI9MhHLWVzWUmOeBIcc1n/i hptqd23VLm5iLw1D6CUkZ5fXAZ25kcnj4I8jY00293ZWz60lkhNyMA7wnrp/kdNje7 Dar0izIYT0FnQ== Date: Wed, 4 Oct 2023 16:28:31 -0700 From: Jakub Kicinski To: Robert Marko Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Marangi , Luis Chamberlain , devicetree@vger.kernel.org Subject: Re: [RFC PATCH net-next] net: phy: aquantia: add firmware load support Message-ID: <20231004162831.0cf1f6a8@kernel.org> In-Reply-To: <20230930104008.234831-1-robimarko@gmail.com> References: <20230930104008.234831-1-robimarko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 04 Oct 2023 16:28:48 -0700 (PDT) X-Spam-Level: ** On Sat, 30 Sep 2023 12:39:44 +0200 Robert Marko wrote: > + ret = of_property_read_string(dev->of_node, "firmware-name", > + &fw_name); Perhaps a well established weirdness of the embedded world but why read the fw name from OF?! You can identify what PHY it is and decide the file name based on that. And also put that fw name in MODULE_FIRMWARE() so that initramfs can be built with appropriate file in place :S > + ret = request_firmware(&fw, fw_name, dev);