Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 5 Oct 2023 07:13:18 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     "KaiLong Wang" <wangkailong@jari.cn>, arnd@arndb.de
Cc:     linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmlinux.lds.h: Clean up errors in vmlinux.lds.h
Message-ID: <ZR3_nt646ijkV3UJ@debian.me>
References: <72e80688.8a8.18ad9bba905.Coremail.wangkailong@jari.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bEqKWIA1685n+LKp"
Content-Disposition: inline
In-Reply-To: <72e80688.8a8.18ad9bba905.Coremail.wangkailong@jari.cn>
Precedence: bulk


--bEqKWIA1685n+LKp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 28, 2023 at 11:01:08AM +0800, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
>=20
> ERROR: spaces required around that ':' (ctx:WxV)
> ERROR: space required after that ',' (ctx:VxO)
> ERROR: need consistent spacing around '*' (ctx:VxW)
>=20
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
>  include/asm-generic/vmlinux.lds.h | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>=20
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmli=
nux.lds.h
> index 9c59409104f6..9e19234bbf97 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -63,8 +63,8 @@
>   * up in the PT_NOTE Program Header.
>   */
>  #ifdef EMITS_PT_NOTE
> -#define NOTES_HEADERS		:text :note
> -#define NOTES_HEADERS_RESTORE	__restore_ph : { *(.__restore_ph) } :text
> +#define NOTES_HEADERS : text : note
> +#define NOTES_HEADERS_RESTORE	__restore_ph : { *(.__restore_ph) } : text

Personally I prefer macro arguments to be aligned.

>  #else
>  #define NOTES_HEADERS
>  #define NOTES_HEADERS_RESTORE
> @@ -98,10 +98,10 @@
>   */
>  #if defined(CONFIG_LD_DEAD_CODE_DATA_ELIMINATION) || defined(CONFIG_LTO_=
CLANG)
>  #define TEXT_MAIN .text .text.[0-9a-zA-Z_]*
> -#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundlit=
eral* .data.$__unnamed_* .data.$L*
> +#define DATA_MAIN .data .data.[0-9a-zA-Z_] * .data..L * .data..compoundl=
iteral * .data.$__unnamed_ * .data.$L*
>  #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*
> -#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L*
> -#define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral*
> +#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_] * .rodata..L*
> +#define BSS_MAIN .bss .bss.[0-9a-zA-Z_] * .bss..compoundliteral*
>  #define SBSS_MAIN .sbss .sbss.[0-9a-zA-Z_]*

Is it taking a pointer or changing to multiplication?

>  #else
>  #define TEXT_MAIN .text
> @@ -462,7 +462,7 @@
>  	. =3D ALIGN((align));						\
>  	.rodata           : AT(ADDR(.rodata) - LOAD_OFFSET) {		\
>  		__start_rodata =3D .;					\
> -		*(.rodata) *(.rodata.*)					\
> +		*(.rodata) * (.rodata.*)					\
>  		SCHED_DATA						\
>  		RO_AFTER_INIT_DATA	/* Read only after init */	\
>  		. =3D ALIGN(8);						\
> @@ -494,28 +494,28 @@
>  	/* Kernel symbol table: Normal symbols */			\
>  	__ksymtab         : AT(ADDR(__ksymtab) - LOAD_OFFSET) {		\
>  		__start___ksymtab =3D .;					\
> -		KEEP(*(SORT(___ksymtab+*)))				\
> +		KEEP(*(SORT(___ksymtab+ *)))				\
>  		__stop___ksymtab =3D .;					\
>  	}								\
>  									\
>  	/* Kernel symbol table: GPL-only symbols */			\
>  	__ksymtab_gpl     : AT(ADDR(__ksymtab_gpl) - LOAD_OFFSET) {	\
>  		__start___ksymtab_gpl =3D .;				\
> -		KEEP(*(SORT(___ksymtab_gpl+*)))				\
> +		KEEP(*(SORT(___ksymtab_gpl+ *)))			\
>  		__stop___ksymtab_gpl =3D .;				\
>  	}								\
>  									\
>  	/* Kernel symbol table: Normal symbols */			\
>  	__kcrctab         : AT(ADDR(__kcrctab) - LOAD_OFFSET) {		\
>  		__start___kcrctab =3D .;					\
> -		KEEP(*(SORT(___kcrctab+*)))				\
> +		KEEP(*(SORT(___kcrctab+ *)))				\
>  		__stop___kcrctab =3D .;					\
>  	}								\
>  									\
>  	/* Kernel symbol table: GPL-only symbols */			\
>  	__kcrctab_gpl     : AT(ADDR(__kcrctab_gpl) - LOAD_OFFSET) {	\
>  		__start___kcrctab_gpl =3D .;				\
> -		KEEP(*(SORT(___kcrctab_gpl+*)))				\
> +		KEEP(*(SORT(___kcrctab_gpl+ *)))			\
>  		__stop___kcrctab_gpl =3D .;				\
>  	}								\

Same here.

Confused...

--=20
An old man doll... just what I always wanted! - Clara

--bEqKWIA1685n+LKp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZR3/mAAKCRD2uYlJVVFO
oxvuAQCkXx9+njnvII0+xKHGRERMrYm8sxrQQXTQ3J6EHyC8dQEAlc3kXaAJwrV9
I8WIium3NvzhTHvv8hayacA5UwGjgAA=
=dqD1
-----END PGP SIGNATURE-----

--bEqKWIA1685n+LKp--