Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <CAHk-=wjrZgxjHZuXwrGeFnng_whUmtToCWE5GQ+HORhGSeiX8g@mail.gmail.com>
 <ZRhKq6e5nF/4ZIV1@fedora> <CAB=+i9QiJ=BXkQuCFJTh3dMXrkKQvVA2EM51Mj6SsDMimWQ71g@mail.gmail.com>
 <CAHk-=whosoBSLAWzSGUZ8s=UwAVG9rsQ9OVPvw97S2RRFGfk2A@mail.gmail.com> <5427bc3d-1e14-781a-53a2-f702774715f4@linaro.org>
In-Reply-To: <5427bc3d-1e14-781a-53a2-f702774715f4@linaro.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 4 Oct 2023 17:46:22 -0700
Message-ID: <CAHk-=whJjhoq2wGOx9e0zK7-EouqdaRREvmJJLN+HX-Zht3miQ@mail.gmail.com>
Subject: Re: Linux 6.6-rc3 (DEBUG_VIRTUAL is unhappy on x86)
To:     Sumit Garg <sumit.garg@linaro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mimi Zohar <zohar@linux.ibm.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        James Bottomley <jejb@linux.ibm.com>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        David Kaplan <David.Kaplan@amd.com>,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
        x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 3 Oct 2023 at 05:06, Sumit Garg <sumit.garg@linaro.org> wrote:
>
> However, on the flip side I think there are security benefits here. We
> wouldn't like any indirect branch speculation attack to leak the trusted
> key material contents here.

No. Turning *one* indirect call static isn't a security benefit. That
argument is just bogus.

This code needs to be fixed. No static call rewriting for call-sites
that are just used once.

               Linus